Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 7 Feb 2018 20:38:05 -0600
From:   Bin Liu <b-liu@ti.com>
To:     Maxim Uvarov <muvarov@gmail.com>
CC:     Yegor Yefremov <yegorslists@googlemail.com>,
        kernel list <linux-kernel@vger.kernel.org>,
        linux-usb <linux-usb@vger.kernel.org>,
        Greg KH <gregkh@linuxfoundation.org>,
        <sergei.shtylyov@cogentembedded.com>,
        Tomas Paukrt <tomas.paukrt@advantech-bb.cz>
Subject: Re: [PATCHv2] musb_host: fix lockup on rxcsr_h_error
Message-ID: <20180208023805.GE223@LTA0271908.dhcp.ti.com>
Mail-Followup-To: Bin Liu <b-liu@ti.com>, Maxim Uvarov <muvarov@gmail.com>,
        Yegor Yefremov <yegorslists@googlemail.com>,
        kernel list <linux-kernel@vger.kernel.org>,
        linux-usb <linux-usb@vger.kernel.org>,
        Greg KH <gregkh@linuxfoundation.org>,
        sergei.shtylyov@cogentembedded.com,
        Tomas Paukrt <tomas.paukrt@advantech-bb.cz>
References: <20160427212823.GA14645@uda0271908>
 <CAJGZr0JwefevBRxbG_k5jPqf8Bi9ndMMieTcAKfkgCRGcbfjrg@mail.gmail.com>
 <20160428143714.GA7222@uda0271908>
 <CAGm1_ksaa8P1fs03-DSsjvVQu_=cg4yqw7xumb9Gbm+t19O01w@mail.gmail.com>
 <20160503134813.GA690@uda0271908>
 <CAGm1_kvLh-+kJVdtv+7i_1nVsPTQ67uE_5ZizRRfK2iEoWcj+w@mail.gmail.com>
 <20180125154508.GB6590@uda0271908>
 <CAJGZr0+8FRhbMEsKke=DoCAQ7-7gqDKCNJZ+oE==aovqm1kHBw@mail.gmail.com>
 <20180125163146.GD6590@uda0271908>
 <CAJGZr0LcMpdNea+VMZs-0Ln+2ScQK+4oWB95qQFt4uF9V=f9ww@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <CAJGZr0LcMpdNea+VMZs-0Ln+2ScQK+4oWB95qQFt4uF9V=f9ww@mail.gmail.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Maxim,

On Fri, Jan 26, 2018 at 12:24:54PM +0300, Maxim Uvarov wrote:
> Bin,
> 
> I looked to my local git and code does not have this latest line "goto
> finish".  It was tested without it and everything worked. Right now I
> can not get access to that hardware to check with and without. But
> only can confirm that without "goto finish" function works with bunch
> of drivers (usb ethernet, hids, hdd).

Thanks for the confirmation. The revert patch has been sent out.

Regards,
-Bin.

> 
> Best regards,
> Maxim.
> 
> 2018-01-25 19:31 GMT+03:00 Bin Liu <b-liu@ti.com>:
> > Maxim,
> >
> > On Thu, Jan 25, 2018 at 07:24:02PM +0300, Maxim Uvarov wrote:
> >> [1] says that issue is with back ported driver to 3.12.10. Can the
> >> latest kernel be tested on the same hw?
> >
> > Agreed that it should be tested with the latest kernel. But my concern
> > now is if stopping scheduling urbs on errors is a right thing to do,
> > that is why I asked if you can re-test your usecase with reverting the
> > commit. I am unable to reproduce the original issue you had.
> >
> > Thanks,
> > -Bin.
> 
> 
> 
> -- 
> Best regards,
> Maxim Uvarov