Received: by 10.223.176.5 with SMTP id f5csp1682936wra; Thu, 8 Feb 2018 01:33:07 -0800 (PST) X-Google-Smtp-Source: AH8x226NqBabOzoQmQ+Y9IP35jJtiGhWM9vKd756z8FcrxOMGI4fM2GDQQGVwLQ0ErbzVRTlYLSJ X-Received: by 2002:a17:902:229:: with SMTP id 38-v6mr35781plc.429.1518082387121; Thu, 08 Feb 2018 01:33:07 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1518082387; cv=none; d=google.com; s=arc-20160816; b=Arxkn50UweAY2dlzMq+s5j5XMBqlEXGWPwcvViDyNXxe4ThaXuC3AUkL2xIoTJ3gVx F2TCoxWptaiqOD8jSODnMA18g6ZxFAAaWqaYaG+Hfqa6xFacPc+xMvcZuCnSH/fDv62I mUwUoP28lJsnVbfr7mD5JoSd4ydfm69CdWLuwp/6Pd55Z9CvwBIMbH42p39TtLPVoWFZ IAe3ueryl8YFWvh/0wyEdZ561Avnn/g7RmKOKet4ks0AhB4p8NpzpX/P0ssSLBW4/i5k a8YShYWsKcVJgku5jvskmIXqCsqDLMQWIW2ihhdmrN/y38VYX82r55/cy8vekWU0d5en cScA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature :arc-authentication-results; bh=IOeHSR4dlVUpykJ4CvP9NKholFkx1rjAGiycirL7d5I=; b=hqtzSh8ukBuo8XECqjzxoptrKJj53YpXTPVlfHpXaboG+PHu5YqinXm3GtqSel33k+ LenNGy9KEN3UYnB2O7XLJW7oAlm4ctcQ392LWZjNxfSJALgu7loN9QOdrJQxY3G5on80 Jqwu7FTx7JiHIZ5HFii+vMNS7TuSTY9rCDkr/KsOS6rMT3RgbTDynQ1OJpNiadFF0qXK YB8g2tlN4q0WaZTFwZFcF9WaCth6th8FBiHG8n0QGkf+0T1Y3Zc5e5AlsfUhbQ1/FP1Y 5TLoZ746WXy1FS6IQeBTXg8MiSNNBGojbGjQeSSjqXX2SpHlHVrZ6jaBaecrvG5exuqh zNeg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=SHFmPreu; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j9si1056549pfe.97.2018.02.08.01.32.53; Thu, 08 Feb 2018 01:33:07 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=SHFmPreu; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750982AbeBHJcO (ORCPT + 99 others); Thu, 8 Feb 2018 04:32:14 -0500 Received: from fllnx210.ext.ti.com ([198.47.19.17]:44081 "EHLO fllnx210.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750749AbeBHJcK (ORCPT ); Thu, 8 Feb 2018 04:32:10 -0500 Received: from dlelxv90.itg.ti.com ([172.17.2.17]) by fllnx210.ext.ti.com (8.15.1/8.15.1) with ESMTP id w189UqdL001340; Thu, 8 Feb 2018 03:30:52 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ti.com; s=ti-com-17Q1; t=1518082252; bh=7LLs/UM6W8mXN0y1W+OanKeezZ7oAOmzCD+DC6qDpes=; h=Subject:To:CC:References:From:Date:In-Reply-To; b=SHFmPreuvowyH5FxNBRFnoR4jhqbCBorvLIYLj/UZfSA45SFzJrdukRmyn+hY2Cya 1ha3fX54C42FtMA8o/AiOutKE3PDa8OCmJ29a+fjcAoQPTGXd/Xf0+kmV0QY60Tdv1 4WOgjJUELw/aN5gG5zPRUUsnBqy+T8a/E7FGzpYs= Received: from DLEE102.ent.ti.com (dlee102.ent.ti.com [157.170.170.32]) by dlelxv90.itg.ti.com (8.14.3/8.13.8) with ESMTP id w189UqAw030418; Thu, 8 Feb 2018 03:30:52 -0600 Received: from DLEE115.ent.ti.com (157.170.170.26) by DLEE102.ent.ti.com (157.170.170.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1261.35; Thu, 8 Feb 2018 03:30:52 -0600 Received: from dlep32.itg.ti.com (157.170.170.100) by DLEE115.ent.ti.com (157.170.170.26) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.1261.35 via Frontend Transport; Thu, 8 Feb 2018 03:30:52 -0600 Received: from [172.24.190.171] (ileax41-snat.itg.ti.com [10.172.224.153]) by dlep32.itg.ti.com (8.14.3/8.13.8) with ESMTP id w189Uluv018044; Thu, 8 Feb 2018 03:30:49 -0600 Subject: Re: [PATCH 2/7] soc: davinci: new genpd driver To: Bartosz Golaszewski , Rob Herring , Mark Rutland , Kevin Hilman , Russell King , David Lechner CC: , , , Bartosz Golaszewski References: <20180207134553.13510-1-brgl@bgdev.pl> <20180207134553.13510-3-brgl@bgdev.pl> From: Sekhar Nori Message-ID: <65f2690c-c605-3c66-9d8a-9a882aaf446d@ti.com> Date: Thu, 8 Feb 2018 15:00:47 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <20180207134553.13510-3-brgl@bgdev.pl> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wednesday 07 February 2018 07:15 PM, Bartosz Golaszewski wrote: > + /* > + * DaVinci always uses a single clock for power-management. We assume > + * it's the first one in the clocks property. > + */ > + clk = of_clk_get(dev->of_node, 0); > + if (IS_ERR(clk)) > + return PTR_ERR(clk); We already get this today with drivers/base/power/clock_ops.c once .con_ids list is dropped from pm_clk_notifier_block (which I think it should). If there is no reason to introduce thus functionality at this stage, perhaps we should wait till such a time when its clearly needed? Thanks, Sekhar