Received: by 10.223.176.5 with SMTP id f5csp1939441wra; Thu, 8 Feb 2018 06:04:34 -0800 (PST) X-Google-Smtp-Source: AH8x224ePxQ2d6ruOV0OqWgbQlCDsdQLnnSUP+O5aiiraHn2EbbVnu+VajSnQdT2jll9O3/zvjfI X-Received: by 10.98.236.65 with SMTP id k62mr752870pfh.223.1518098674120; Thu, 08 Feb 2018 06:04:34 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1518098674; cv=none; d=google.com; s=arc-20160816; b=y3nuUxf+0b6PJo2OrUJc5NUBN6N6yerUpzEDE643QB8oAc+sYkt5Jav2nckksoMoKK 4TkeGJQDiCBENqMNBTPcI8Ep2Mw1xj2gQYzuRS91GuEysnNebu7fMAlT+mUZ965TknCu 7S9GUiiMriYKIXh6GZQJ3QPEpnXQ7Sso7ZOCaZT90MSL7d/1Kc9No8YqbsVpWexwd5aM VGAZBObEQK3HkIL1RErncoYM3KhlqSR/VFn6I4Gi0VTBE7znB6vjwU96OI4Wr2PbQJlI JmrUBsclFbAoYdgHHX/P6NDSPQ9M5p1RSAGV+RCdaGTKJ5JEroNEXhSYam88IXakwZsJ H3dQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dmarc-filter :dkim-signature:dkim-signature:arc-authentication-results; bh=4Eu4w8NEZdBEXdimJMgfKmNIMMoh7NemU/QVyze56pc=; b=FajGXSMG2/Z0pRON4pWHbgSfc6gE7WX5iRkrjCRWTi6Y/Rgb1oZop73V+foEk658cN KQr46cO16IEzpc0y6DRj1BZA/RLXHxAoPct3sK7tmleQ5M+uCVdSB7yKjp4fd4h8NOLL dyuKDQzguDfQlpeZ5OhxzFJaAAkXry3yWOufRwJSRwS2oIA9xdcSlYbyhz0wDkLCtHz+ wD30jm0Uu9Ng0H+xPOFMZbqP72etaPUA4FlUoHOKb0RQ/ry0klYmYOWhGolfSCIqpNAq jumL2pvC0y6ncpo/ReLNsZlZL8gBrj3FsRO92oX4qOHwFnC6t2gd7OO9uvEL5MMclcZI hkcQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=Lo2uMjtZ; dkim=pass header.i=@codeaurora.org header.s=default header.b=iCYj4UOt; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 1-v6si11276plj.456.2018.02.08.06.04.18; Thu, 08 Feb 2018 06:04:34 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=Lo2uMjtZ; dkim=pass header.i=@codeaurora.org header.s=default header.b=iCYj4UOt; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752290AbeBHODY (ORCPT + 99 others); Thu, 8 Feb 2018 09:03:24 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:44100 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750882AbeBHODU (ORCPT ); Thu, 8 Feb 2018 09:03:20 -0500 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 123AA6076A; Thu, 8 Feb 2018 14:03:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1518098600; bh=vg0aNStWVzeLsunvlp5X2bBE1uesO/IbRM/7PuS8rac=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=Lo2uMjtZPsXzelcAIKmrCllvtH7z5o/AAx83fJYTV5RfzwQ5SMlpEB8dNLCaWnaXl RsWZ/moSU+HL/s162NgdW3HjB2hmGGiP0gByJVN+N8BcpWrG1krg4a1EIGkng16KXC 5wGJzaKsEiTa6WyqEJLJjUNjx1tvulomkIAq3f6M= X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on pdx-caf-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=2.0 tests=ALL_TRUSTED,BAYES_00, DKIM_SIGNED,T_DKIM_INVALID autolearn=no autolearn_force=no version=3.4.0 Received: from [10.201.3.39] (blr-c-bdr-fw-01_globalnat_allzones-outside.qualcomm.com [103.229.19.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: sricharan@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 44B2E60112; Thu, 8 Feb 2018 14:03:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1518098599; bh=vg0aNStWVzeLsunvlp5X2bBE1uesO/IbRM/7PuS8rac=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=iCYj4UOt870z931Hbv25dk6YoVN5C21B8obm8hhGZ8Ls0zkcKIr/Vt93ZLrCDaWzB JtR0zbY75CJNep93TOiXywMVLfAVHT9H6OR9flFvpC6JUUQuAW9Z8d7L7ohoxooLDc kf3buHDvoXjGrJM+UcHSf8IxWrnvhhQGmALu6ZVs= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 44B2E60112 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=sricharan@codeaurora.org Subject: Re: [PATCH 01/12] i2c: qup: fixed releasing dma without flush operation completion To: Abhishek Sahu , Andy Gross , Wolfram Sang Cc: David Brown , linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org, linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org References: <1517644697-30806-1-git-send-email-absahu@codeaurora.org> <1517644697-30806-2-git-send-email-absahu@codeaurora.org> From: Sricharan R Message-ID: <0ff28076-b105-9280-a7e0-767f923768fa@codeaurora.org> Date: Thu, 8 Feb 2018 19:33:14 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <1517644697-30806-2-git-send-email-absahu@codeaurora.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Abhishek, On 2/3/2018 1:28 PM, Abhishek Sahu wrote: > The QUP BSLP BAM generates the following error sometimes if the > current I2C DMA transfer fails and the flush operation has been > scheduled > > “bam-dma-engine 7884000.dma: Cannot free busy channel” > > If any I2C error comes during BAM DMA transfer, then the QUP I2C > interrupt will be generated and the flush operation will be > carried out to make i2c consume all scheduled DMA transfer. > Currently, the same completion structure is being used for BAM > transfer which has already completed without reinit. It will make > flush operation wait_for_completion_timeout completed immediately > and will proceed for freeing the DMA resources where the > descriptors are still in process. > > Signed-off-by: Abhishek Sahu > --- > drivers/i2c/busses/i2c-qup.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/i2c/busses/i2c-qup.c b/drivers/i2c/busses/i2c-qup.c > index 08f8e01..9faa26c41a 100644 > --- a/drivers/i2c/busses/i2c-qup.c > +++ b/drivers/i2c/busses/i2c-qup.c > @@ -1,5 +1,5 @@ > /* > - * Copyright (c) 2009-2013, The Linux Foundation. All rights reserved. > + * Copyright (c) 2009-2013, 2016-2018, The Linux Foundation. All rights reserved. Not sure, if this was an intended change. But given that you are fixing this, you can change the header to the new SPDX one. > * Copyright (c) 2014, Sony Mobile Communications AB. > * > * > @@ -844,6 +844,8 @@ static int qup_i2c_bam_do_xfer(struct qup_i2c_dev *qup, struct i2c_msg *msg, > } > > if (ret || qup->bus_err || qup->qup_err) { > + reinit_completion(&qup->xfer); > + > if (qup_i2c_change_state(qup, QUP_RUN_STATE)) { > dev_err(qup->dev, "change to run state timed out"); > goto desc_err; > Except for the above nit, Acked-by: Sricharan R Regards, Sricharan -- "QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation