Received: by 10.223.176.5 with SMTP id f5csp1985879wra; Thu, 8 Feb 2018 06:44:38 -0800 (PST) X-Google-Smtp-Source: AH8x2242IzSBxw0i/9slsw9CNJGQTbzNHg8jeEvUaTfm0w2Z6dfuWPZiNXRd0n3PEeCjVUhQAF8L X-Received: by 10.99.122.13 with SMTP id v13mr743822pgc.128.1518101077974; Thu, 08 Feb 2018 06:44:37 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1518101077; cv=none; d=google.com; s=arc-20160816; b=C25N5RnDRG+yCprcW5jmpDz8QGDNLqg2/zI6WkMCkIC9Lz84iyFW4Eco4CdN826Rpf 13UPjNLQ2pqfZT6suKcxtXJqOmbz4U921/xRWnl2DB+TTdtO93vZ1aoTdXvNVBHbwGsw dqNAO58dX7/i39qJEMPZ+uHO0MBXKDWvE3wki7I+3gHXyumOREIMaTPRelyhkUq5CZ4Z DCAKTzjN09EOLgMzx0AWk+FMjd67U+GD2cRV40vIutlA2d2LwcnV5ISa2k3NpV9+VysK 1PkGdR9y69oTmPr7Lw4rCEWhlkkn9mLGxM0RXBEdjeG3etJXEN8KTU/lu2PUdlF/t0OP i7cA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:arc-authentication-results; bh=kBhbI23jcmizUYRPVH6K+1ex9v0TS8LnvwPz95wYJW8=; b=zpN8jy0KTVTTNqfFq2TwJgMouqP1zZgvggBCnESh8woBUEYqJe6484yqOnDN9jnWM2 9PTmkkTujW6r+zjXzzLkBBMadCfcXnMUiOuPzkKo5tyMTK/ej/leFCYiJ4572wK4b6vh awjp+j82tWVnFLBZtPe+Ytxm4kt/k1OsSHHDeu5JErD6YPqPy74/x0usEoLrJ5Yk6QAp beUujWWUJCtI31AgJtZ8fEuga5fV0jYzKLO2Kj/DPy+ez5yx0LJj2TgVE5R2HzJx87XG XtEyEhtuNcHJ37XaS/pcKRBIBKL9HIoJefieRK8y/MMb5YEaWpVDupLdNno3lkRxBHS+ Ma2g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n79si18705pfa.148.2018.02.08.06.44.24; Thu, 08 Feb 2018 06:44:37 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752116AbeBHOni (ORCPT + 99 others); Thu, 8 Feb 2018 09:43:38 -0500 Received: from metis.ext.pengutronix.de ([85.220.165.71]:58747 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750882AbeBHOnh (ORCPT ); Thu, 8 Feb 2018 09:43:37 -0500 Received: from gallifrey.ext.pengutronix.de ([2001:67c:670:201:5054:ff:fe8d:eefb] helo=bjornoya.blackshift.org) by metis.ext.pengutronix.de with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1ejnQE-0004HI-MB; Thu, 08 Feb 2018 15:43:34 +0100 Received: from [IPv6:2001:470:7eea:1122:dc84:99c1:396c:9792] (unknown [IPv6:2001:470:7eea:1122:dc84:99c1:396c:9792]) (using TLSv1.2 with cipher ECDHE-RSA-CHACHA20-POLY1305 (256/256 bits)) (Client CN "mkl@blackshift.org", Issuer "StartCom Class 1 Client CA" (not verified)) (Authenticated sender: mkl@blackshift.org) by smtp.blackshift.org (Postfix) with ESMTPSA id D60692D935B; Thu, 8 Feb 2018 14:43:33 +0000 (UTC) Subject: Re: [PATCH] can: m_can: change comparison to bitshift when dealing with a mask To: Wolfram Sang , linux-kernel@vger.kernel.org Cc: linux-renesas-soc@vger.kernel.org, Wolfgang Grandegger , linux-can@vger.kernel.org, netdev@vger.kernel.org References: <20180206085207.3882-1-wsa+renesas@sang-engineering.com> From: Marc Kleine-Budde Message-ID: Date: Thu, 8 Feb 2018 15:42:55 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <20180206085207.3882-1-wsa+renesas@sang-engineering.com> Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="L3QZrDHeHWdmduPP8K6NTogOucdTWDtx4" X-SA-Exim-Connect-IP: 2001:67c:670:201:5054:ff:fe8d:eefb X-SA-Exim-Mail-From: mkl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --L3QZrDHeHWdmduPP8K6NTogOucdTWDtx4 Content-Type: multipart/mixed; boundary="glwg4TysMLh9Tqp1Gw8ayyXwr3iIaA7fQ"; protected-headers="v1" From: Marc Kleine-Budde To: Wolfram Sang , linux-kernel@vger.kernel.org Cc: linux-renesas-soc@vger.kernel.org, Wolfgang Grandegger , linux-can@vger.kernel.org, netdev@vger.kernel.org Message-ID: Subject: Re: [PATCH] can: m_can: change comparison to bitshift when dealing with a mask References: <20180206085207.3882-1-wsa+renesas@sang-engineering.com> In-Reply-To: <20180206085207.3882-1-wsa+renesas@sang-engineering.com> --glwg4TysMLh9Tqp1Gw8ayyXwr3iIaA7fQ Content-Type: text/plain; charset=utf-8 Content-Language: de-DE Content-Transfer-Encoding: quoted-printable On 02/06/2018 09:52 AM, Wolfram Sang wrote: > Due to a typo, the mask was destroyed by a comparison instead of a bit > shift. >=20 > Reported-by: Geert Uytterhoeven > Signed-off-by: Wolfram Sang > --- > Only build tested. Applied to can. Luckily that define is not used :) Tnx, Marc --=20 Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions | Phone: +49-231-2826-924 | Vertretung West/Dortmund | Fax: +49-5121-206917-5555 | Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de | --glwg4TysMLh9Tqp1Gw8ayyXwr3iIaA7fQ-- --L3QZrDHeHWdmduPP8K6NTogOucdTWDtx4 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEENrCndlB/VnAEWuH5k9IU1zQoZfEFAlp8Ye8ACgkQk9IU1zQo ZfE5ngf9FfC2VYJ1KD8HcsAYc0Hh9ByscFKRPNMGoAPeLKG5EMvDI8CN0oZXUZCg CxZfqEXjcrzHor9YaJAX/mAKNcoPGrypXEtS6jQ1KCNh6mnSNUXGlueLgZ9N8a7c rAVey3wSfQA0c2vlZH0u5eoFC9pCDIAai1TXn+wrvolQPcYVBpmOyqNJGwlERF0Q SPEXCCHCn3tO+BR2vc4vJYRvTkqGyPUKF5b+dlaBWncbRo64E0TCpAmjfiToPt3o Fpp8YCO42IY2cdXFM7tEN4LHzC/TJFggWQyccba7CwtwR3vf93keFGiMlor53wCn 4RwxobFxSvBypIqy1s9lh50Ky0XLkg== =jnP7 -----END PGP SIGNATURE----- --L3QZrDHeHWdmduPP8K6NTogOucdTWDtx4--