Received: by 10.223.176.5 with SMTP id f5csp2010446wra; Thu, 8 Feb 2018 07:05:52 -0800 (PST) X-Google-Smtp-Source: AH8x226cdimtFJ5JovwDflsDkAl/RE4WVIHjxKNYo9SmnVsueNG1B6kP2HXZ/ZVDbbIloef84a97 X-Received: by 10.99.124.89 with SMTP id l25mr770550pgn.324.1518102352565; Thu, 08 Feb 2018 07:05:52 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1518102352; cv=none; d=google.com; s=arc-20160816; b=Rv8DQJ4q/6MJo37Qz1EJbGu8u+vrBzxS+vjAi5bUta4Ddk5avPpqhGERcPkodJfk5V 423tFogYC6XrNPo+2DfmMLPBLK4TElCEsuba39nYM/TimqqYSn0PICvxVdPBNQ+xiPWj zEa8Jaz/UOctvlhe1eQ2CnZ2Xeez5xKvOF+LS/lWcMgq+Tp4BhcuvhYe0O4q9kdpdGOS oY9If/zWrXtoDHVx2tG9wC94yQDBA5h/GvEP++d8fkNrmm43bwGiANNIo52d7wH5dFkW FpPRzeAiHHAsIi7t5uk7/oGc0Q1RXn4IbGNUrP+N8P8qIW8p2qReKkqMJAJUCJZzD5kl nL/g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=HkpmBTFf9V/YfvlLLo8nriUBwmJk2AJYeH9EvWH55Yo=; b=CmcYFt6Q37cefRv/NCyGCSEsijUAOp2qEntMzOytzh+2UFwTeGdSO9TVC8E/MNC8Bx SVY2fLYqSKQncebZossm1aYv5XFw5NJiLn0Aimz2P+ihJmsvwWi9qgMjCYVHJVak2GOA ts6Y/9gBEHFfNpb0Lru5BPx5vQGIatMTky+i03DVI4IOkMgrf6Jv3dayHHUSPlOFINjO Gvd4TQe7X8z/U3LaBfzYPzUPyOStFhFEXsnKmk8HUfQh1gX1WRVzY71lhI0eMD6ngBH6 WPMPIhkMGElO3oykZM3oBVdwa9O5lmXXGV9l+/W8/fuU5rOPx9Ex/aO1S7KRDPsSrt6c 9pYw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t29si78170pfa.359.2018.02.08.07.05.37; Thu, 08 Feb 2018 07:05:52 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751995AbeBHPE4 (ORCPT + 99 others); Thu, 8 Feb 2018 10:04:56 -0500 Received: from mail.skyhub.de ([5.9.137.197]:49090 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750847AbeBHPEz (ORCPT ); Thu, 8 Feb 2018 10:04:55 -0500 X-Virus-Scanned: Nedap ESD1 at mail.skyhub.de Received: from mail.skyhub.de ([127.0.0.1]) by localhost (blast.alien8.de [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id 9nAh69Wo9IhJ; Thu, 8 Feb 2018 16:04:53 +0100 (CET) Received: from pd.tnic (p200300EC2BCCF10078C005B42741A0DC.dip0.t-ipconnect.de [IPv6:2003:ec:2bcc:f100:78c0:5b4:2741:a0dc]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 729F11EC0104; Thu, 8 Feb 2018 16:04:53 +0100 (CET) Date: Thu, 8 Feb 2018 16:04:33 +0100 From: Borislav Petkov To: Yazen Ghannam Cc: linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org, bp@suse.de, tony.luck@intel.com, x86@kernel.org Subject: Re: [PATCH 1/3] x86/MCE/AMD: Redo function to get SMCA bank type Message-ID: <20180208150433.GD7964@pd.tnic> References: <20180201184813.82253-1-Yazen.Ghannam@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20180201184813.82253-1-Yazen.Ghannam@amd.com> User-Agent: Mutt/1.9.3 (2018-01-21) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 01, 2018 at 12:48:11PM -0600, Yazen Ghannam wrote: > arch/x86/kernel/cpu/mcheck/mce_amd.c | 15 +++++++-------- > 1 file changed, 7 insertions(+), 8 deletions(-) > > diff --git a/arch/x86/kernel/cpu/mcheck/mce_amd.c b/arch/x86/kernel/cpu/mcheck/mce_amd.c > index 0f32ad242324..4e16afc0794d 100644 > --- a/arch/x86/kernel/cpu/mcheck/mce_amd.c > +++ b/arch/x86/kernel/cpu/mcheck/mce_amd.c > @@ -110,14 +110,14 @@ const char *smca_get_long_name(enum smca_bank_types t) > } > EXPORT_SYMBOL_GPL(smca_get_long_name); > > -static enum smca_bank_types smca_get_bank_type(struct mce *m) > +static enum smca_bank_types smca_get_bank_type(unsigned int bank) > { > struct smca_bank *b; > > - if (m->bank >= N_SMCA_BANK_TYPES) > + if (bank >= ARRAY_SIZE(smca_banks)) MAX_NR_BANKS -- Regards/Gruss, Boris. Good mailing practices for 400: avoid top-posting and trim the reply.