Received: by 10.223.176.5 with SMTP id f5csp2052628wra; Thu, 8 Feb 2018 07:43:49 -0800 (PST) X-Google-Smtp-Source: AH8x2243W/pwhfLSpFlsEiQX3Lcbk/a8ZLFAQ2UO/KLLa2FBl8SffuKvcq3hjYhzAEJXlIk8vU+i X-Received: by 10.98.70.17 with SMTP id t17mr1133813pfa.14.1518104629247; Thu, 08 Feb 2018 07:43:49 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1518104629; cv=none; d=google.com; s=arc-20160816; b=c/pN6YSvDY9fyIkwQ1f8HjUZmN8fZubb7m7rryuu1lZnKVQ7HdlZR8v/+u+qZHCkz4 /3O3TUUslJZGW5AWaBPkoQ08x8R68kvqT7YifIKB+KLUa+TtNTuiPEvPWEl5w29nrC19 x8RKJClNbMTacbCQuja2SYP1o1LzWjULsX6hAbbQlMpLsAA9M9kJMGsLYLRKHtRmmNmS n0VS7sPQZ2J97kwXJPBYwK1UprgUO3cVyUS5R8khg6Oh34LclyqwgXzTDnI9Ig/Cu2xw P9MM1g65voWlUNdElwMIWcl/DcKn9UjKER+0+snN9NWXneIRaUbleV1mbGpMCa4V0RGy LfuA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:date:message-id:in-reply-to:subject:cc:to :from:dkim-signature:arc-authentication-results; bh=BOsVEKMcNS2QUbk3PwJtlK0ZRUB0pD7GncqukDWtGKs=; b=vXoXSEVxCCXsIeMVBLcmrbj2W8HqrE6fJB556mFuiuZohpw0zdjf8sNjTfMY6dtdcF IZO5nLQ5ALLD1JowC5N8MR2i9mDrRzOoPsWSAZ5CBsy1TG9dTlBQntTVizanepJghzYj vPdX5ud6CD0S7XlMBPagfd+Tm0CX1yN3ArEvUr0hmwBdBeBEgzhTLAbDfF3TBlMI2emb yDgrhXVwj/L7A4YtFUBXWV6Ss3TGpb8PTAnaNlzYMJzgRsU6eAf955EDQ1wso9Vxm4gr gz99PnpEvgBzLbMeZo/UnR3uj6BtKAyOYxhEtI/+Zw8hKl53bWSlsg57qXn9rEOuYlrE c+YQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=Qlk9wntX; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u76si137974pfa.294.2018.02.08.07.43.33; Thu, 08 Feb 2018 07:43:49 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=Qlk9wntX; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752386AbeBHPmf (ORCPT + 99 others); Thu, 8 Feb 2018 10:42:35 -0500 Received: from heliosphere.sirena.org.uk ([172.104.155.198]:35822 "EHLO heliosphere.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752268AbeBHPmF (ORCPT ); Thu, 8 Feb 2018 10:42:05 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sirena.org.uk; s=20170815-heliosphere; h=Date:Message-Id:In-Reply-To: Subject:Cc:To:From:Sender:Reply-To:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Id:List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner: List-Archive; bh=BOsVEKMcNS2QUbk3PwJtlK0ZRUB0pD7GncqukDWtGKs=; b=Qlk9wntXGenb tC9rCt77q8achl9D732WzL8gPGxTx99zmQlC7eu2k5KTvOES1ZuYvM6XTIOrGCZ3fIfyk0NG6o7j/ gJW1RQACKnsVjg6g2es8GVHrj2aDcmLRiuX5RIiwk7o99Fki30d9nAVIvcpANecR65eM3aK7MfNTS 1jpv4=; Received: from debutante.sirena.org.uk ([2001:470:1f1d:6b5::3] helo=debutante) by heliosphere.sirena.org.uk with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1ejoKk-00036P-Ay; Thu, 08 Feb 2018 15:41:58 +0000 Received: from broonie by debutante with local (Exim 4.90) (envelope-from ) id 1ejoKj-00006C-SN; Thu, 08 Feb 2018 15:41:57 +0000 From: Mark Brown To: Fabrice Gasnier Cc: Mark Brown , stable@vger.kernel.org, broonie@kernel.org, lgirdwood@gmail.com, alexandre.torgue@st.com, mcoquelin.stm32@gmail.com, fabrice.gasnier@st.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Applied "regulator: stm32-vrefbuf: fix check on ready flag" to the regulator tree In-Reply-To: <1518097385-7449-1-git-send-email-fabrice.gasnier@st.com> Message-Id: Date: Thu, 08 Feb 2018 15:41:57 +0000 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The patch regulator: stm32-vrefbuf: fix check on ready flag has been applied to the regulator tree at https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark From f63248fac563125fd5a2f0bc780ce7a299872cab Mon Sep 17 00:00:00 2001 From: Fabrice Gasnier Date: Thu, 8 Feb 2018 14:43:05 +0100 Subject: [PATCH] regulator: stm32-vrefbuf: fix check on ready flag stm32_vrefbuf_enable() wrongly checks VRR bit: 0 stands for not ready, 1 for ready. It currently checks the opposite. This makes enable routine to exit immediately without waiting for ready flag. Fixes: 0cdbf481e927 ("regulator: Add support for stm32-vrefbuf") Signed-off-by: Fabrice Gasnier Signed-off-by: Mark Brown Cc: stable@vger.kernel.org --- drivers/regulator/stm32-vrefbuf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/regulator/stm32-vrefbuf.c b/drivers/regulator/stm32-vrefbuf.c index 72c8b3e1022b..e0a9c445ed67 100644 --- a/drivers/regulator/stm32-vrefbuf.c +++ b/drivers/regulator/stm32-vrefbuf.c @@ -51,7 +51,7 @@ static int stm32_vrefbuf_enable(struct regulator_dev *rdev) * arbitrary timeout. */ ret = readl_poll_timeout(priv->base + STM32_VREFBUF_CSR, val, - !(val & STM32_VRR), 650, 10000); + val & STM32_VRR, 650, 10000); if (ret) { dev_err(&rdev->dev, "stm32 vrefbuf timed out!\n"); val = readl_relaxed(priv->base + STM32_VREFBUF_CSR); -- 2.15.1