Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Reply-To: minyard@acm.org
Subject: Re: ipmi_si fails to get BMC ID
To:     Chris Chiu <chiu@endlessm.com>, arnd@arndb.de,
        gregkh@linuxfoundation.org,
        openipmi-developer@lists.sourceforge.net,
        Linux Kernel <linux-kernel@vger.kernel.org>,
        Linux Upstreaming Team <linux@endlessm.com>
References: <CAB4CAwfino0JaeeZV1byp3aoaRrOGL1=BYgkruvxYMr6=c=5PQ@mail.gmail.com>
From:   Corey Minyard <minyard@acm.org>
Message-ID: <3b812894-46a0-3c87-1b9f-468fc63ea5bd@acm.org>
Date:   Thu, 8 Feb 2018 09:53:22 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.6.0
MIME-Version: 1.0
In-Reply-To: <CAB4CAwfino0JaeeZV1byp3aoaRrOGL1=BYgkruvxYMr6=c=5PQ@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-GB
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 02/07/2018 09:01 PM, Chris Chiu wrote:
> Hi,
>      We are working with a new desktop Acer Veriton Z4640G and get
> stumbled on failing to enter S3 suspend with kernel version 4.14 even
> the latest 4.15+. Here's the kernel log
> https://gist.github.com/mschiu77/76888f1fd4eb56aa8959d76759a912bb.

This is a little strange, nobody had reported this before.  Can you 
reproduce this
at will, or was it a one-time thing?

Does the IPMI driver always take this long to issue that error, even if 
you are not
entering sleep state?

And it started with 4.14, and didn't occur before then, right?

There's a bug in the PCI utils database, I submitted a report a while 
ago.  This is
a KCS, not a SMIC interface.

It looks like the driver is trying to detect that there is a device out 
there and
there is something that kind of works, but doesn't work completely. The 
interface
specific code was all split out into separate files in 4.14.  It is 
possible the
detection code got messed up in the process.  Nothing jumps out looking at
the code differences, and I know it works on some PCI machines.

Assuming this is reproducible, can you send the the output of a pre-4.14
kernel?  If that doesn't make it obvious I may have to have access to the
machine itself.

-corey

>      As you see, it is due to "ipmi_probe+0x430/0x430 [ipmi_si]". After
> the message "ipmi_si 0000:02:00.3: There appears to be no BMC at this
> location" shows up, then it can really go to suspend w/o problem.
> Although it took around 3 mins. The IPMI device is probed from PCI and
> here's the output of lspci
> https://gist.github.com/mschiu77/33f0372be41670d8a69c97e64f833087. The
> IPMI device is "02:00.3 IPMI SMIC interface [0c07]". We get stuck here
> because we don't really know why it took so long in try_get_dev_id() /
> ipmi_si_intf.c. Any suggestion about this to help us moving forward?
> Thanks
>
>
> Chris