Received: by 10.223.176.5 with SMTP id f5csp2064542wra; Thu, 8 Feb 2018 07:55:52 -0800 (PST) X-Google-Smtp-Source: AH8x227OIomeiLeBcdXRTJtfFht/h8Uzvp7KYeKZKW6pFG1++kURKEYqH4sWCAdlA27KlRyNWbLq X-Received: by 10.99.47.132 with SMTP id v126mr860742pgv.129.1518105351913; Thu, 08 Feb 2018 07:55:51 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1518105351; cv=none; d=google.com; s=arc-20160816; b=bzJz2IBMN1aVvf4QgIJbQGlxHgpT6ck61s8DV/keCmkhegMA9Q2bxKi+g/7zfkJDwW +V3GpR7jPOTD+4f5H3WH9kF0B5g8d3TZdKSzBBSxXYjUn/U54MtSPWRQesO8+eaZ18th pnB6vkinruPHmwUQZkBnZh3bCMbxxf0qlpLXhmsPrnUucPBoAZ4uhylD3JiOpVATe8wK 5MZbPCV/H7p2EKKkM3y53ZNuLRwweNOwmwbLkBwEdU8FbrRJYYzfw0nTZY3KmYaM9pR/ r/Npwa6aAg/Dkz6jIRNMs+/1ImnWFeebNco4yLyhheBs/9dfDOpCR9tNPCEieKbeD3Fp Mqnw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :references:in-reply-to:mime-version:dkim-signature :arc-authentication-results; bh=jPeiXLg9LBReMpdY+LKA5mMcPSkGDHl0XH9yVgaInoA=; b=sVAgkwybM2YGpBdn96XtmLpou5+G2HQ5GY6OEpwzReer/8R/JIXkdLKmY64JErZcZy h1Ts2ztQDck/9NCzsd9AgpO3ky2V/SNwwYQYedcvOlx5bTqPP2osuTJMogta6dBpGD9A QOTDSnxy05KSzUuLGcrnSuowwjJhrjb8QApITCXe6pmog0ybH8+wMreqwJQT5mzLzpDC FjhIaruT2OKRPVJYAim5yqxKyrtASmW3mfezcyO50Bknd04hneHuOmrHm2/z3UioASpk teL1dXr8WvfaiJSl56w3DLnmxBAPT3Ho2ODoIRO2csVpidjIZuk/rbfd5ATprCnzyjQ1 stzw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=vt4hyYD9; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s196si93894pgc.650.2018.02.08.07.55.36; Thu, 08 Feb 2018 07:55:51 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=vt4hyYD9; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752203AbeBHPyK (ORCPT + 99 others); Thu, 8 Feb 2018 10:54:10 -0500 Received: from mail-io0-f172.google.com ([209.85.223.172]:40362 "EHLO mail-io0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750961AbeBHPyI (ORCPT ); Thu, 8 Feb 2018 10:54:08 -0500 Received: by mail-io0-f172.google.com with SMTP id t22so6266676ioa.7 for ; Thu, 08 Feb 2018 07:54:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=jPeiXLg9LBReMpdY+LKA5mMcPSkGDHl0XH9yVgaInoA=; b=vt4hyYD9ps+sky4GOMFL7YwzKWlfx8rT4VbmfNp0/OWSVIdCBNJSm1ZrIPv2tIhp6s ZIeNGARIaIDPvneBDcU6UKCGGA8NetztjJnXBQHo2GIqWmgevljeSy4Ktz+ykdNGMa/W /nqET5Kp/+8EmTS3eG4LkoOkmPHruFz3DO0MLa60190yt+J4NOPwMQqI4iCfqNdAkRmw U0cpNAf1NGRdpCybJObUxcZiaEpIZq5tJ/vqx29nnBeMQnV9FstAiX9JbO97ug4IKEWs qeRwk0dQo5k66rkS9Q+ZhEQVZjmuTUtBkahg4cG0NURizyURV6xZZ1ayVLqwcE0NyRP1 L3tw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=jPeiXLg9LBReMpdY+LKA5mMcPSkGDHl0XH9yVgaInoA=; b=tMdbiCI5kHV3uYSIf6V1OhmN773jZr8qR3b2MM9UnTXxcUcs+a7C0P/rCGuDMMTyG/ nczBFZb4Rwh//nRSuaXiLnNdxjvEXeJZUIDGNF3dP46pO5175iEiJZMt2FTr3y+Zys7h B3qjzt6TH2ESSYZLk+soHlmQ5Ykd0RufrE+YaPHRrpJ3bbe8zJA9b8Nsfx03oXMboDkc ngUNeejc2hEyLVei38O1p4y0aRpqTPRys0ohVvKZ8TFrC61nTfotEygbVjel4Lol0jK+ Tdia5l9D8iCw6q4V8jLPo+TGZ4M3nSCHNMV1nxOD4KHbIygvPZX1Xf7Da9lmwuAcrLYx g9NQ== X-Gm-Message-State: APf1xPBR76MNi7bVYe33rhHMb/eLLgIkwfQ10XNQ3Ks9g1yWG5JIzPSw vFySdX/UqqLP0ddUOOKCn/dJfqRU244vjhFv2OalyA== X-Received: by 10.107.28.201 with SMTP id c192mr1381518ioc.26.1518105247538; Thu, 08 Feb 2018 07:54:07 -0800 (PST) MIME-Version: 1.0 Received: by 10.107.128.7 with HTTP; Thu, 8 Feb 2018 07:54:07 -0800 (PST) In-Reply-To: References: <1517828686-29070-1-git-send-email-wanpengli@tencent.com> From: Jim Mattson Date: Thu, 8 Feb 2018 07:54:07 -0800 Message-ID: Subject: Re: [PATCH] KVM: nVMX: Fix CR4 after VMLAUNCH/VMRESUME failure To: Wanpeng Li Cc: kvm list , LKML , Radim Krcmar , Paolo Bonzini Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 8, 2018 at 7:29 AM, Jim Mattson wrote: > Similarly, the correct L1 CR4 value should be in vmcs01's CR4 > read shadow field. Sorry; that's wrong. L1's CR4 value has to be reconstructed from the vmcs01 guest CR4 field and CR4 shadow field using the cr4 guest/host mask. But there is no way to get it from any field(s) in vmcs12.