Received: by 10.223.176.5 with SMTP id f5csp2317078wra; Thu, 8 Feb 2018 11:59:02 -0800 (PST) X-Google-Smtp-Source: AH8x226YK7qhorEM3OxPd2iEUnkytGtnxatqTOln2rAC2kpJ+I4KaA0dxShaOZ6imkZT4lqSTmrj X-Received: by 10.98.219.68 with SMTP id f65mr187972pfg.25.1518119942283; Thu, 08 Feb 2018 11:59:02 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1518119942; cv=none; d=google.com; s=arc-20160816; b=WA/liN1A0A8shR+v8adyR7TJY/4hjToBa2BgCMpItR/o4DUmJM4AYFQ9RQkPH5y+Mr CV7JdRYTEQorKnUzhnk3IP2P0BqZ3NrwqzBGrUNBjt/s+dTgdQH/QjlWiivBtaR0qZvE 6niWwgqal9fJgc//5C710GY2/XHoCLQ0E2ykILQeYPxaRZFjH+A4nfgeRfUei6RzEdJw 0XhXU7p1Z6rcJZilGSotP0et8Wv9tYp16yNgsfo8VVKuUpzeiLsLOOOz400EtgMMu7S1 8be+pkgBFVIjOUOiMYBuHWyCY78cyrVGgZLBomgMWGEoxm7aqVmXTz+Xynyh3ENqpv/X zWyA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :organization:references:in-reply-to:message-id:subject:cc:to:from :date:arc-authentication-results; bh=2lxFdtA5pjiihvpqemFyi+MNKjeKapCrZof+RAsbSMQ=; b=vgyzhP6VBREH5hV4lTHkh/XekIFYEZIAd6YSb5nfMIXHfCvuEbgR3OUvorKSzgTBRS nKuKpNocAaPQsBaB5gL78Z5u5yv4nSvbjnC+YKRAg5JLJK5v5NvHImqjvRS0Kl2ADe/V KA5hYYHyZDsqcUJrW0iaXqbIER5kq8ReFpENJ77OZATlH4LNUF6qhJV+3KbmuAcKcuSF q8jadf+eJnEV5Ehke8Y5T98293CnE9QRzpzo6JyuiLf8gQDFaUkfUAt35sQ4ZsQ0nLXQ N0dskfkbmzw8JTDHcsy/qTyYVVBqLfpyiv35wHlYEK5e1Ev33rF/SPXTJ2dAu5rSq3LQ 3Qrw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e13si344810pgq.476.2018.02.08.11.58.46; Thu, 08 Feb 2018 11:59:02 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752179AbeBHT6E (ORCPT + 99 others); Thu, 8 Feb 2018 14:58:04 -0500 Received: from ms.lwn.net ([45.79.88.28]:55636 "EHLO ms.lwn.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751094AbeBHT6D (ORCPT ); Thu, 8 Feb 2018 14:58:03 -0500 Received: from localhost.localdomain (localhost [127.0.0.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ms.lwn.net (Postfix) with ESMTPSA id 9B4232DD; Thu, 8 Feb 2018 19:58:02 +0000 (UTC) Date: Thu, 8 Feb 2018 12:58:00 -0700 From: Jonathan Corbet To: "Tobin C. Harding" Cc: linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, mchehab@kernel.org Subject: Re: [PATCH 7/8] docs: kernel-doc: Finish moving STATE_* code out of process_file() Message-ID: <20180208125800.3dae9456@lwn.net> In-Reply-To: <20180208022953.GB3304@eros> References: <20180207172624.24555-1-corbet@lwn.net> <20180207172624.24555-8-corbet@lwn.net> <20180208022953.GB3304@eros> Organization: LWN.net X-Mailer: Claws Mail 3.15.1-dirty (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 8 Feb 2018 13:29:53 +1100 "Tobin C. Harding" wrote: > It doesn't appear to be introduced by you but the brace positions are > non-uniform in this patch. > > if > { > ... > } > else > { > ... > } > > instead of > > if { > ... > } else { > eee > } True, that's worth fixing up while I'm in the neighborhood. I'll do that before I commit the set. Thanks, jon