Received: by 10.223.176.5 with SMTP id f5csp2339175wra; Thu, 8 Feb 2018 12:19:24 -0800 (PST) X-Google-Smtp-Source: AH8x226E9l9KWA7GXqEfIAO7ZLwa7EgN7VD/r3513DECiWUHeqof1l/GH8JgUqWuuOk0df1XBN1X X-Received: by 10.99.102.1 with SMTP id a1mr308292pgc.452.1518121164852; Thu, 08 Feb 2018 12:19:24 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1518121164; cv=none; d=google.com; s=arc-20160816; b=xNZLC/mEH1JFk9lAPyDKEpwOm5Yeta/OepHJ34TQFn1pdLlGuyqnP50+0xMvKOgTFk aIRr+h0x6FDdQJ2XHw4+mAS4+W8E4Now5eVvelbddC2HmTxZUbNxfG16VUIwzBqvLqG9 JWKTewoA4oo+FWZ3WvOvoR9vb5mecUGcKDAwl3DBLUWgKjwqlyhzCAUhVYVebnjYWyLW VEagWIAZQ97n7+nu3lflEQ6RxHXmzR0xpLva1tpVNjFAJNO0+r0840P8jSHuW2TAY/UH mIm+fQv+FQwWDrwW1SKyhQT6UxbUMnxTsLfCPzC+imFRx2FoWkyPgSaYUC93hacFKoUN uFRg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :arc-authentication-results; bh=Fcm1N6GH5Tkj3ITu2YM914JJ746Q3WTXWnda3/B15qk=; b=ef/it5Bkyjlwo0Ws4khhBltqMvp5puGhWUYF66LfgfKuASTR62gXjQmMJmQqsFrhpr lE1zT+rf2z5MDqeL4aS0s7Dp/zaEbGF0X+cAD+7QQlc66foOxKw0uwzdLSrG4C2nBD+S MGfSqD0xiB+3zZFz5BnAMg26AOz7amuDFLWdrloucU0L4IllTojLING3lpXGsc4KPcrL Pf96yPWi5qCrNe9C4jK2aRvvxpyec7W/81wvNlo4sEbmaotExH7FPEsG45/5lz/dq77E f917215NDgwVMLtj3N1iC5I0B6Rnpq+uLi790sEjXAlKE4ihj2+8h+gQZo+uENRuPm2m TjbQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h3-v6si426001pld.110.2018.02.08.12.19.09; Thu, 08 Feb 2018 12:19:24 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752537AbeBHURw (ORCPT + 99 others); Thu, 8 Feb 2018 15:17:52 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:34492 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752208AbeBHURv (ORCPT ); Thu, 8 Feb 2018 15:17:51 -0500 Received: from akpm3.svl.corp.google.com (unknown [104.133.9.92]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id 798EB1048; Thu, 8 Feb 2018 20:17:50 +0000 (UTC) Date: Thu, 8 Feb 2018 12:17:49 -0800 From: Andrew Morton To: Punit Agrawal Cc: Naoya Horiguchi , "linux-mm@kvack.org" , Michal Hocko , Mike Kravetz , "Aneesh Kumar K.V" , Anshuman Khandual , "linux-kernel\@vger.kernel.org" , Benjamin Herrenschmidt , Michael Ellerman Subject: Re: [PATCH v2] mm: hwpoison: disable memory error handling on 1GB hugepage Message-Id: <20180208121749.0ac09af2b5a143106f339f55@linux-foundation.org> In-Reply-To: <87fu6bfytm.fsf@e105922-lin.cambridge.arm.com> References: <20180130013919.GA19959@hori1.linux.bs1.fc.nec.co.jp> <1517284444-18149-1-git-send-email-n-horiguchi@ah.jp.nec.com> <87inbbjx2w.fsf@e105922-lin.cambridge.arm.com> <20180207011455.GA15214@hori1.linux.bs1.fc.nec.co.jp> <87fu6bfytm.fsf@e105922-lin.cambridge.arm.com> X-Mailer: Sylpheed 3.4.1 (GTK+ 2.24.23; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 08 Feb 2018 12:30:45 +0000 Punit Agrawal wrote: > > > > So I don't think that the above test result means that errors are properly > > handled, and the proposed patch should help for arm64. > > Although, the deviation of pud_huge() avoids a kernel crash the code > would be easier to maintain and reason about if arm64 helpers are > consistent with expectations by core code. > > I'll look to update the arm64 helpers once this patch gets merged. But > it would be helpful if there was a clear expression of semantics for > pud_huge() for various cases. Is there any version that can be used as > reference? Is that an ack or tested-by? Mike keeps plaintively asking the powerpc developers to take a look, but they remain steadfastly in hiding. Folks, this patch fixes a BUG and is marked for -stable. Can we please prioritize it?