Received: by 10.223.176.5 with SMTP id f5csp129356wra; Thu, 8 Feb 2018 18:08:36 -0800 (PST) X-Google-Smtp-Source: AH8x226GtOxE3zvkE8nHXSIW6wjn0RqcACiEOxp+OQEpcUYnQ9sW3LPuTMjWlFkEBDnLFRLCVUqY X-Received: by 10.99.140.18 with SMTP id m18mr1020796pgd.320.1518142116351; Thu, 08 Feb 2018 18:08:36 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1518142116; cv=none; d=google.com; s=arc-20160816; b=pqsZOxTd8k0tJzm5aAFudo64aGRsolVx/i+fSVei5Qr24iQ2jUA4EcDpRyURjNvuv9 i8X5s87Tw4Z5e0MpScpYUvns5UM4RvmgWefVFlITSVqcndALxkh6HVHV22Pha4lRz2V7 R0ThrZyjRtSEOIFFxRehe+JhFw+CBcXm6BRWwBWIbLK+9awl7VPA52b0SnvWZ3ox734m 0NzsLwaX9yPeA99prKWh5SVsKxZV5i13EMKYyoieB42VVWfjV0oJAIrI32l/Xsk5dExK I0KWhgRbYH9auVFWi+J6mYNEXOKa1dqN2QFLIsU3hc/QsrzBGYKnLig81/b133ylbxJD hzzg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:arc-authentication-results; bh=JJvtuM40z3g/pOnTvCpf2O9Yd2/wq1rz2/tTyC75RGk=; b=gVZYZLse2EFyMPVr0CA6RqTXikdVtvNzrUuBhUVQSbNvfaywWgooCjOlLFLJjb9sa2 rq3Aq2hr2LbU9o7BJEsnTb+2xCYOKWfcw+OIKH/gUil64o3308bmWE021xht+GPJiLUE pCacNCqa3u/Tt1/mH9/wkoDQVqXZwvdl3DxXz8Vg29J1IzLgmkmXXAt3FhxUxvb19DSr enaNDxbRuDb2DXY3irq4h9s8vyVgBZXo8aDNzwoG8/qHlhl4+eEmFyhcE1cWJD/XeJOu 9Yv16yGqSY5qRrCZ0oMfG/1JeRPaVlqGJG33NDxma/lenYEnv54uHJ8X8WyXvFkrbLfd u/Iw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e90-v6si792628plb.749.2018.02.08.18.08.21; Thu, 08 Feb 2018 18:08:36 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752374AbeBICHo (ORCPT + 99 others); Thu, 8 Feb 2018 21:07:44 -0500 Received: from smtp-proxy004.phy.lolipop.jp ([157.7.104.45]:53944 "EHLO smtp-proxy004.phy.lolipop.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752172AbeBICHn (ORCPT ); Thu, 8 Feb 2018 21:07:43 -0500 Received: from smtp-proxy004.phy.lolipop.lan (HELO smtp-proxy004.phy.lolipop.jp) (172.19.44.45) (smtp-auth username m12129643-o-takashi , mechanism plain) by smtp-proxy004.phy.lolipop.jp (qpsmtpd/0.82) with ESMTPA; Fri, 09 Feb 2018 11:07:41 +0900 Received: from 127.0.0.1 (127.0.0.1) by smtp-proxy004.phy.lolipop.jp (LOLIPOP-Fsecure); Fri, 09 Feb 2018 11:07:41 +0900 (JST) X-Virus-Status: clean(LOLIPOP-Fsecure) Subject: Re: [PATCH] ASoC: Intel: Skylake: make function skl_clk_round_rate static To: Colin King , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Sriram Periyasamy , Stephen Boyd , "Subhransu S . Prusty" , alsa-devel@alsa-project.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org References: <20180208143530.11450-1-colin.king@canonical.com> From: Takashi Sakamoto Message-ID: <88ad9256-5c68-1e36-dd72-eba8ecba66e7@sakamocchi.jp> Date: Fri, 9 Feb 2018 11:07:41 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <20180208143530.11450-1-colin.king@canonical.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Feb 8 2018 23:35, Colin King wrote: > From: Colin Ian King > > The function skl_clk_round_rate is local to the source and does not > need to be in global scope, so make it static. > > Cleans up sparse warning: > sound/soc/intel/skylake/skl-ssp-clk.c:250:6: warning: symbol > 'skl_clk_round_rate' was not declared. Should it be static? > > Signed-off-by: Colin Ian King > --- > sound/soc/intel/skylake/skl-ssp-clk.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Takashi Sakamoto > diff --git a/sound/soc/intel/skylake/skl-ssp-clk.c b/sound/soc/intel/skylake/skl-ssp-clk.c > index 7fbddf5e3b00..cda1b5fa7436 100644 > --- a/sound/soc/intel/skylake/skl-ssp-clk.c > +++ b/sound/soc/intel/skylake/skl-ssp-clk.c > @@ -247,8 +247,8 @@ static unsigned long skl_clk_recalc_rate(struct clk_hw *hw, > } > > /* Not supported by clk driver. Implemented to satisfy clk fw */ > -long skl_clk_round_rate(struct clk_hw *hw, unsigned long rate, > - unsigned long *parent_rate) > +static long skl_clk_round_rate(struct clk_hw *hw, unsigned long rate, > + unsigned long *parent_rate) > { > return rate; > } Thanks Takashi Sakamoto