Received: by 10.223.176.5 with SMTP id f5csp167374wra; Thu, 8 Feb 2018 18:57:53 -0800 (PST) X-Google-Smtp-Source: AH8x226xV1eGvsGYZ+Il2SKUay1ghlOswrl9vSlauD+ffWavGTWHJSjGNkIH2VaVKCHb3sW0GDd1 X-Received: by 10.98.238.2 with SMTP id e2mr1244689pfi.206.1518145073499; Thu, 08 Feb 2018 18:57:53 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1518145073; cv=none; d=google.com; s=arc-20160816; b=o36YX19jeboFnr4Wwnw8WGpBp4dfat8Bsya++C0UXBIOZE7/5wxx8qrfiM3Vc4U8zY BkJSAsnFxPckc0yNdyq1giqo1jQaZf6dD8TUbSJ36g9mz4w84A3ar8Kqe7+koKezNgM6 bM4dSbNhX7gJXm4Qr/PD6Mv/s1Ou6Ap3pr2wnPhkcKUzt7uV9yTIQSMQo42kP9+nSf32 ouv6KI1z4FpAt2V3X6uc+2CYhrG51awLCxdYAbUD8gW+8HoKXB0O9S2ZFGgBnb8vXNIx Cu6APu6gqjKN04885F4BoJc2HEdllceOH0XPx1lYej+3kw5J7dlHQfV1AFx6s7VpWuh4 ciAA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature:arc-authentication-results; bh=C+Z/qX7XXolxal+f+p7YeXboeD67lqFgwYGuQu/+dv4=; b=aeEMDbzlYiEo4B7YtFvEIc+Ly0KEUgM34IiJ0sPHY2yHwUKP9d8F2LO2moIIulsKpt fw24WPOx2odGqv7rAlaUFAodWucVMwUz+zhwazhL5ohhXPIDoOF8zzzQjPCaGZrh3luT UG3YLJeZTycTvFcFRsc4twzLfiFmDRj1GuD9dRKZJt0fj0PH5WKhs+cwkHRxh3AFqj9w j7CNUfzEyknHUXOXjuXycNSOGio2abGoyx+fI+bka76r621CwwFJA58ab/uTJAZoemKl +7IwNGDjJvAgGW1cOIM6pcNqVMFbQQJupQz7500lP9EI+SvU8sqwCxVNHc2zF0GHY60y F8aA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=jjtDaZ+m; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 1-v6si920410plw.164.2018.02.08.18.57.39; Thu, 08 Feb 2018 18:57:53 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=jjtDaZ+m; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752570AbeBICz0 (ORCPT + 99 others); Thu, 8 Feb 2018 21:55:26 -0500 Received: from mail-pl0-f66.google.com ([209.85.160.66]:34708 "EHLO mail-pl0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752547AbeBICzY (ORCPT ); Thu, 8 Feb 2018 21:55:24 -0500 Received: by mail-pl0-f66.google.com with SMTP id q17so854744pll.1 for ; Thu, 08 Feb 2018 18:55:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=C+Z/qX7XXolxal+f+p7YeXboeD67lqFgwYGuQu/+dv4=; b=jjtDaZ+m5lLwKVmP/wvK9/LhMduI3pZAbHtazEXAaVG/QLfzvUnLhQU8cvD+cQePST oIOxQa789Ey6oKATrhlu55GFprQoZOguuefbnMo1nQ/eLUz1xBhMI/kWsKire9J/jRA2 wCN0MK6OjkbIQ5q5Zj5w2XatCdMzxjbxuQkvzaQWJFoHM0lx8M2VTfWVTDDBC1yLSJYp N+P7ZdNVC1Qu/bsZLWAcf85ImWdv77amsh7Q9I9+uX4OsAcaK8ew33XGEGV6P3JPwvpV BoyP96Mdq8Zyf6P5uK1FULf3lcqiK+gk/dZWLDykgivIeP9gWPda1RpNnSZXQOP78EYf Z/Tg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=C+Z/qX7XXolxal+f+p7YeXboeD67lqFgwYGuQu/+dv4=; b=QJaahhszfueB9bkyiqPVVrAe7//RT0+VDYeJWZU1U+xvHv6SQzpPROvWFF8ygyWHBM NW9E1I/L+IJUUpCfNAoLugxYbDUfkZvVs/7vk/BGz1lYEpKt0fLIEzLbuqrkB6Yw+T8B 8DIeE07QNiQkuW/YAVoaTBQ+pMwdW8yuw7HCJW1tkwoIY0Rtd3aUH7K+lKpP9WzfAsqg tpTKFZl62/1bLGxwOPYL16D9uRLCzsz9FtFYoNuqwwH457GCNywi2pUZzYeBE3ETEORe xnLlrg4A1CgaXHiPIZLjV80XyO7o8nHGujh+hD50VSLkfWVWwnR4+WsEbTHgTApXZfTL MKlw== X-Gm-Message-State: APf1xPDkCJkKcE4LawrSyPsGCoSKspSVxCjRnqeGNXwPs2wqteDZuriK D+f09+DxLBxS9z8vbzQhfDo= X-Received: by 2002:a17:902:d904:: with SMTP id c4-v6mr655853plz.203.1518144924510; Thu, 08 Feb 2018 18:55:24 -0800 (PST) Received: from localhost ([110.70.51.39]) by smtp.gmail.com with ESMTPSA id q2sm2167531pgf.10.2018.02.08.18.55.22 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 08 Feb 2018 18:55:23 -0800 (PST) Date: Fri, 9 Feb 2018 11:55:20 +0900 From: Sergey Senozhatsky To: Mike Rapoport Cc: Sergey Senozhatsky , Minchan Kim , Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Sergey Senozhatsky Subject: Re: [PATCH 1/2] zsmalloc: introduce zs_huge_object() function Message-ID: <20180209025520.GA3423@jagdpanzerIV> References: <20180207092919.19696-1-sergey.senozhatsky@gmail.com> <20180207092919.19696-2-sergey.senozhatsky@gmail.com> <20180208163006.GB17354@rapoport-lnx> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180208163006.GB17354@rapoport-lnx> User-Agent: Mutt/1.9.3 (2018-01-21) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On (02/08/18 18:30), Mike Rapoport wrote: [..] > > > > +/* > > + * Check if the object's size falls into huge_class area. We must take > > + * ZS_HANDLE_SIZE into account and test the actual size we are going to > > + * use up. zs_malloc() unconditionally adds handle size before it performs > > + * size_class lookup, so we may endup in a huge class yet zs_huge_object() > > + * returned 'false'. > > + */ > > Can you please reformat this comment as kernel-doc? Is this - Documentation/doc-guide/kernel-doc.rst - the right thing to use as a reference? -ss