Received: by 10.223.176.5 with SMTP id f5csp209791wra; Thu, 8 Feb 2018 20:01:32 -0800 (PST) X-Google-Smtp-Source: AH8x225WXTof6pe+BnfSs21BFUgIXbqRQ9gGq+cXp/SYqflZ0fuEVcVWW/e6eF6Xdna8HEMP1Niz X-Received: by 10.98.155.141 with SMTP id e13mr1367887pfk.89.1518148892127; Thu, 08 Feb 2018 20:01:32 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1518148892; cv=none; d=google.com; s=arc-20160816; b=mhSjoLwRhO3Vwd7d9NeXCgunHFyq6B2lHRL4vSZlUe5Kvd9X5hgqtcXZ4fqJkF/K15 8xNcmweuqMmUlBzErUvwZmhxx4uAS9aByF1u/XM0iPmLVFY6wIskRrTl7AsXjDSTX+qk frYRCKU/yz5CXIn3R6b1JOElh7Xym89/afjoep+j0goK/t9hlOekuK6wLVBT5ZHFbscq Tf2JoDpjD/4O2tDpJasbEx8YAQiO7xfXEhURARjFsWBTpsHOXQNOyGF7mINIY678sxW8 i+U3Hth4XrgXjwEalicB5YlyONp8toezpM/valNq+VQc52Sypkx0PVsl2YNwfSDmIzO0 zuPg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:date:message-id:subject:cc:from:to :in-reply-to:arc-authentication-results; bh=N1Vpr0wKfeyiD5PSRrA95fr3NrynWfQOkWIOCvcOo4w=; b=h6xTpxLEImlpfWtwHe8SRHrmC+7qig8QzxdtbRjsnrU8a9K3vcrwVZws+RZCkirFw5 uysz2e0VIVK6wMHdTp9W1hBIQWnaYbnM+q+2WhUZ11hHZLadtOEPjEo5m+wD6yKyTQ1R nZP5ytIUDngqU4KA9uH89OoYPWu2v/yEfYzGdUbHeF27C9KmpGfGzxgpRXsE5NJRetwP v+4bMiklIVMcB79qCVbwwWts9xxYhRqvwywqAggouZtcETsjLndqWq5ncGWaduwLn5nu DCZ7zU+1V0Hlsm0CzaMQ3zW2AowoniNGy978Y+a/sgZCRce1SmgdIYjxybkn1SFQlogm 69iw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a1-v6si978027plt.588.2018.02.08.20.01.17; Thu, 08 Feb 2018 20:01:32 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752559AbeBIEAh (ORCPT + 99 others); Thu, 8 Feb 2018 23:00:37 -0500 Received: from ozlabs.org ([103.22.144.67]:41475 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752201AbeBIEAg (ORCPT ); Thu, 8 Feb 2018 23:00:36 -0500 Received: by ozlabs.org (Postfix, from userid 1034) id 3zd1Ys6HkGz9sRm; Fri, 9 Feb 2018 15:00:33 +1100 (AEDT) X-powerpc-patch-notification: thanks X-powerpc-patch-commit: dedab7f0d3137441a97fe7cf9b9ca5dbd20ca9a5 In-Reply-To: <20180130151144.32544-1-colin.king@canonical.com> To: Colin King , Frederic Barrat , Andrew Donnellan , Arnd Bergmann , Greg Kroah-Hartman , linuxppc-dev@lists.ozlabs.org From: Michael Ellerman Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: ocxl: fix signed comparison with less than zero Message-Id: <3zd1Ys6HkGz9sRm@ozlabs.org> Date: Fri, 9 Feb 2018 15:00:33 +1100 (AEDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2018-01-30 at 15:11:44 UTC, Colin King wrote: > From: Colin Ian King > > Currently the comparison of used < 0 is always false because > uses is a size_t. Fix this by making used a ssize_t type. > > Detected by Coccinelle: > drivers/misc/ocxl/file.c:320:6-10: WARNING: Unsigned expression > compared with zero: used < 0 > > Fixes: 5ef3166e8a32 ("ocxl: Driver code for 'generic' opencapi devices") > Signed-off-by: Colin Ian King > Acked-by: Andrew Donnellan > Acked-by: Frederic Barrat Applied to powerpc fixes, thanks. https://git.kernel.org/powerpc/c/dedab7f0d3137441a97fe7cf9b9ca5 cheers