Received: by 10.223.176.5 with SMTP id f5csp256881wra; Thu, 8 Feb 2018 21:15:05 -0800 (PST) X-Google-Smtp-Source: AH8x2269x0Kpye6d57Kr4oqvTzjjd9NU5EFDiNxCREjFD7dsRAsxsErWEDPupGvhJTGsa2T6Sgnx X-Received: by 10.98.225.20 with SMTP id q20mr1548823pfh.23.1518153305688; Thu, 08 Feb 2018 21:15:05 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1518153305; cv=none; d=google.com; s=arc-20160816; b=qluwXMz8gx26spWSQKVmdLSTtTl31NuNvAmrwlu5CP/lOQ1cPW33XvTc81HZZiCm8M BIgYzdZ0Gbu71cGaoKA1GdRhhpKhAl3EQlxpcYpLmMU9oR2dPTEthGuuAtmcQ757LBvw O0NCYM81xFrcEAe/uByGTREfNOPILib/mmtdCpWhIYzZUpMs0JKwiOPMTlj9pFmVX+HM FX+xUXCtNydEdKrgbRUSlJCoUOslJojBCyQkvo5yyXgds5Agv38zsRZwaocCP0qMRmiH S/WTqXOO48vI0XH9yYyRpT/cwq1h/j6AbpR69B3ESm10ztsiQYLbi30cx6Nx/4wHfRMC 2/Lg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=XY2mYL+3CXRq9CSu9aOTkGVeJl5rFRuOd7J0aLQgqiI=; b=pdiMoMVrMvZaWEq3wuXaU8PbvjFH+8lkZNUqqgp+1fBQLaYSVbVlJc+Nk+4jBIi9kv s9jqbkwUOsahhggD3IUoG55+VOFayo06a6FR+OdVbmGHVj9nL2yQ7AE1SKJrCPP8dKcS ymtSgWfPiaA+hOUupwvOFB2b9KMd6TuV9mcnNHd9QpYbiVdLfaOgNLtv70DBoU7YYexN JqgDZoHX3nwNH2/GS4Hhqkg8Bh7OqLWi39EQ3Ka9ilTpvt7Z4OAxFYXyO+Y3s+pPPDxv zqurR7kEsjbGNxuDHFo1gtYBgjM2J6rHLlnGABS0YCXyrZ8A7CXAJTyn1NOX9XHt+fwV 78Pg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 1-v6si1048826plz.410.2018.02.08.21.14.51; Thu, 08 Feb 2018 21:15:05 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751133AbeBIFNW (ORCPT + 99 others); Fri, 9 Feb 2018 00:13:22 -0500 Received: from mga05.intel.com ([192.55.52.43]:65215 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751097AbeBIFNU (ORCPT ); Fri, 9 Feb 2018 00:13:20 -0500 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 Feb 2018 21:13:20 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,482,1511856000"; d="scan'208";a="30075744" Received: from vkoul-udesk7.iind.intel.com (HELO localhost) ([10.223.84.143]) by orsmga001.jf.intel.com with ESMTP; 08 Feb 2018 21:13:16 -0800 Date: Fri, 9 Feb 2018 10:46:48 +0530 From: Vinod Koul To: Colin King Cc: Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Sriram Periyasamy , Stephen Boyd , "Subhransu S . Prusty" , alsa-devel@alsa-project.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [alsa-devel] [PATCH] ASoC: Intel: Skylake: make function skl_clk_round_rate static Message-ID: <20180209051647.GA3666@localhost> References: <20180208143530.11450-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180208143530.11450-1-colin.king@canonical.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 08, 2018 at 02:35:30PM +0000, Colin King wrote: > From: Colin Ian King > > The function skl_clk_round_rate is local to the source and does not > need to be in global scope, so make it static. > > Cleans up sparse warning: > sound/soc/intel/skylake/skl-ssp-clk.c:250:6: warning: symbol > 'skl_clk_round_rate' was not declared. Should it be static? Acked-By: Vinod Koul -- ~Vinod