Received: by 10.223.176.5 with SMTP id f5csp370359wra; Fri, 9 Feb 2018 00:00:28 -0800 (PST) X-Google-Smtp-Source: AH8x226IlmAQP533r/wsFXKCDMo2QG+9FNCCWSfCZZgPCCfEZ4gTiySDqO60Gp5tjYjsbiwuQx+A X-Received: by 10.101.82.1 with SMTP id o1mr1614843pgp.259.1518163228405; Fri, 09 Feb 2018 00:00:28 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1518163228; cv=none; d=google.com; s=arc-20160816; b=rqf7oZ6PCSgeiyszFD55GII7XCmiw0lzQcGp5OQ4XHm/h/ExhQLVnKHKrLhOpLlz5d 8T9dFYzppxpMzLPC+KPaKLXXlCYKGgVDzYzeu4oNdjgkAbV1nMruBNo+MOqFd2/zy5c6 M9VLkKEuJ+5gZqnIUBcA3sWGOCltRT526Yq6cO9kVJrIapHXvHimiFBvgWqDQ/vOqLdL 5rCiZEob+xOiyEtqcfP3HkmlS+VSN3wFHOnqvAJyL609WSTGUP4QASH2+hfqPz+zhe3P vdysyXtiCbWJjufzNM1rGU8DUXK4vmXgc23auPfJdDn4RjgSDuCG+t3dCf1eClY4IBfp ygdA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-transfer-encoding:content-disposition:mime-version :references:message-id:subject:cc:to:from:date :arc-authentication-results; bh=9F8zeAjGVnasgU+YGMbzXjLR9XEk16tiwHHcO/YqKCg=; b=DjSZct9WUlda7Ja1ip6zYQUUqpdVDB0nZJTxvarhqnT3zUiGyBUUz+BngvJ+fk3KGy LEfvjQy00FmUkChxNuJycbL8fxqZaXfykZ7aXjcCgWXdhlez/+XeNjz2J+8hMhcGm8qo Kzl+P0VbSB7VGaz1+c0wFHIzUnt6SXj4yoVDKI8CVa2/AhSIVzZhpA31qZNG3Bn3a1ik xP3rLVG6GBGphDSpgYmKXfZ98EKakRzfcZSRVXZhG9K2jMjca4AmjSwpUGmW4VUm9eby tQf2q64dqczLBjTlgY3J09J8DNGOma93QPsvIodrplO4Ccy24itbN9m8PPh3z1z85uXA jwCw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u8si1077725pgp.78.2018.02.09.00.00.13; Fri, 09 Feb 2018 00:00:28 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750997AbeBIH7A (ORCPT + 99 others); Fri, 9 Feb 2018 02:59:00 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:60302 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750770AbeBIH67 (ORCPT ); Fri, 9 Feb 2018 02:58:59 -0500 Received: from localhost (LFbn-1-12258-90.w90-92.abo.wanadoo.fr [90.92.71.90]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id 4D4FA15E6; Fri, 9 Feb 2018 07:58:58 +0000 (UTC) Date: Fri, 9 Feb 2018 08:58:56 +0100 From: Greg KH To: Paolo Bonzini Cc: "Woodhouse, David" , Jim Mattson , Radim =?utf-8?B?S3LEjW3DocWZ?= , linux-kernel@vger.kernel.org, kvm@vger.kernel.org, KarimAllah Ahmed , stable@vger.kernel.org Subject: Re: [STABLE 4.9.y PATCH 0/9] Backport of KVM Speculation Control support Message-ID: <20180209075856.GA13110@kroah.com> References: <1517938181-15317-1-git-send-email-dwmw@amazon.co.uk> <9ea4d52a-7ae6-a179-2f86-1e7b77255387@redhat.com> <1517951146.3677.34.camel@amazon.co.uk> <20180208024959.GA16399@kroah.com> <20180208171436.GA3521@kroah.com> <20180208175737.GA22067@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20180208175737.GA22067@kroah.com> User-Agent: Mutt/1.9.3 (2018-01-21) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 08, 2018 at 06:57:38PM +0100, Greg KH wrote: > On Thu, Feb 08, 2018 at 06:42:03PM +0100, Paolo Bonzini wrote: > > On 08/02/2018 18:14, Greg KH wrote: > > > On Thu, Feb 08, 2018 at 03:49:59AM +0100, Greg KH wrote: > > >> On Tue, Feb 06, 2018 at 09:05:46PM +0000, Woodhouse, David wrote: > > >>> > > >>> > > >>> On Tue, 2018-02-06 at 19:01 +0100, Paolo Bonzini wrote: > > >>>> On 06/02/2018 18:29, David Woodhouse wrote: > > >>>>> I've put together a linux-4.9.y branch at? > > >>>>> http://git.infradead.org/retpoline-stable.git/shortlog/refs/heads/linux-4.9.y > > >>>>> ? > > >>>>> Most of it is fairly straightforward, apart from the IBPB on context? > > >>>>> switch for which Tim has already posted a candidate. I wanted some more > > >>>>> review on my backports of the KVM bits though, including some extra > > >>>>> historical patches I pulled in. > > >>>> > > >>>> Looks good!? Thanks for the work, > > >>>> > > >>>> Paolo > > >>> > > >>> Thanks. In that case, Greg, the full set is lined up in > > >>> http://git.infradead.org/retpoline-stable.git/shortlog/refs/heads/linux-4.9.y > > >>> or git://git.infradead.org/retpoline-stable linux-4.9.y > > >> > > >> Many thanks for all of this work. I've now queued up all of these. > > > > > > There's a problem with the backport of 6342c50ad12e ("KVM: nVMX: > > > vmx_complete_nested_posted_interrupt() can't fail") as there is still a > > > check in the function that can fail: > > > > > > vapic_page = kmap(vmx->nested.virtual_apic_page); > > > if (!vapic_page) { > > > WARN_ON(1); > > > return -ENOMEM; > > > } > > > > > > Do we need something else before this patch in order to fix this? I > > > guess kmap really can't fail, should I just drop the whole (!vapic_page) > > > check? > > > > Yes, that would be commit 42cf014d38d8822cce63703a467e00f65d000952. > > Should David or I respin? > > No need, I can sneak it into the middle of the series :) I'll do it > later tonight and let you know if I have any problems, thanks for > pointing out the needed commit. Now queued up.