Received: by 10.223.176.5 with SMTP id f5csp439408wra; Fri, 9 Feb 2018 01:25:01 -0800 (PST) X-Google-Smtp-Source: AH8x227v8WE2uBG4URmR4a1UUK6c1YIDctClLkboVyNBi1VMbH6L3HxgS0UnQOSc6Uveh5GP7AEN X-Received: by 10.99.112.89 with SMTP id a25mr1824666pgn.138.1518168301365; Fri, 09 Feb 2018 01:25:01 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1518168301; cv=none; d=google.com; s=arc-20160816; b=wF9LMRbDFYxOkcubcykw3x0OgZfVhNnwtFZBCdn+qxuqXd57No2WVNzuqTRjLxxeqh AwD5klfRn7+5qdpw4xIU85La0KBioLobLyx/at4uqv5WG9nHHxoQxVYG1aNlehorny+O p/6xaDifyErh2uZFTuK65tuaPbBinYvko5umoxBk3GQOI1/lNEfmpIMyXis8qdQlr3+3 3CqnJgptaPMrvcrZWZe+bGFXGM6axTgFFG5YIsZnGV6uoq2NXF7ZnZCBV7Jc92L0K5kf 7/1o3p4ekTpwwmFO5GPXYQW4bHl6ZMRAWIg039TPOTBqY6n3L6TFMoG8pTjGqtn7c6lf WO9g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :references:in-reply-to:mime-version:dkim-signature :arc-authentication-results; bh=gmkDcRQvk2lJEXmdf/TXcztwA2EvwK9RlCji6NxVIDU=; b=nPJtErDP98mU46J40QWK/ZDQAoN1uaiKEjOboVXm2/T+JDsyZGz4jPmo4QcsN2Cev2 ieAUggVj79su3/jUI3tLUlXT9nNrwJU4WiKEkSBBqpg4Qc5gp5ow5G5ODkd6jMQ7yXYJ B3qLZDHknShhmVIIujdzUtijlRXU3mVGsnvRTOMLu7X/JyW2e6O75J9yB6ax/9XbtRDe b0xmYXZsjbm8qqk7dQ67aH5D1iYftnRkv9nK+t19lMH95baLn0TefDKBnZbLXauLUWhh ZtJUfQON1b1hDIXlIAh3olaKcrb149QVdIzyyUYUn90kxVAN2aHZ9cuq8pK2bQi+QeEo /oDQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=L8aJk8f4; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x11-v6si1293586plm.734.2018.02.09.01.24.43; Fri, 09 Feb 2018 01:25:01 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=L8aJk8f4; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751124AbeBIJXS (ORCPT + 99 others); Fri, 9 Feb 2018 04:23:18 -0500 Received: from mail-ot0-f178.google.com ([74.125.82.178]:41521 "EHLO mail-ot0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751030AbeBIJXQ (ORCPT ); Fri, 9 Feb 2018 04:23:16 -0500 Received: by mail-ot0-f178.google.com with SMTP id r23so7118202ote.8 for ; Fri, 09 Feb 2018 01:23:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=gmkDcRQvk2lJEXmdf/TXcztwA2EvwK9RlCji6NxVIDU=; b=L8aJk8f40OeTHhCtolL+PYXEqcPh29JQl8qSDYYf19HpQ+SSr7XX4uV9LGgd8WvqTk 9cizvjnemIkmjX1Bejq5mdGfh8/plAUIH5lTb3RV8a5oQ3MRrg2aftaWsJ8fdNGlQwke UmG+MabsGj4oxJcO5dQH1hAbhzAtOm1MPES0Y= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=gmkDcRQvk2lJEXmdf/TXcztwA2EvwK9RlCji6NxVIDU=; b=tIg2wmoNQHLvsLNPaTrXSc6ziDymxlNzdqyuRTco2pEQ3s1rMBcHnw++2ktIEVmiko 7QO3DxIvZsIqhHTOUu5KgMdXxCQ1BKFIS2+S/gv0H4e1AOwXo1rbq5lQ18Z5qORPB60G kYXoDJfdn2cMNyUiKZ/0cKcU9RtJhjdLRxJ/6rDTRLIuc+5mHHlrVcYcWMYNPWKe/Rbu fGibymlwgaW8ME4kSHwvwuvf8P0VUVxDebbycAKLapBVPQ4+uESu2HJpML2hzqjPJHiE zg1U1Q1u+QazXNEkR8odh3/KyVFA66dMtub7luIFMNgIYN2kYfdpkGiOu4+I2GzX//OQ DycQ== X-Gm-Message-State: APf1xPDDErLwJKjdGzpeACfcXb1s6PR9CXdVtdiJ09F11k4XWuO9fMav 4AXi2C1m8boPG0UcobUNs7tF+vGy70BjYAI2m/sIlQ== X-Received: by 10.157.8.161 with SMTP id 30mr1804405otf.223.1518168195622; Fri, 09 Feb 2018 01:23:15 -0800 (PST) MIME-Version: 1.0 Received: by 10.157.28.174 with HTTP; Fri, 9 Feb 2018 01:23:15 -0800 (PST) In-Reply-To: References: <6c53b9ccfd4a56fc1b00e243bb9e7cae9e124932.1518155780.git.baolin.wang@linaro.org> From: Baolin Wang Date: Fri, 9 Feb 2018 17:23:15 +0800 Message-ID: Subject: Re: [PATCH] Input: gpio_keys: Add level trigger support for GPIO keys To: Dmitry Torokhov Cc: Rob Herring , Mark Rutland , Greg Kroah-Hartman , stephen lu , Arvind Yadav , Joseph Lo , Kate Stewart , Philippe Ombredanne , Thomas Gleixner , "linux-input@vger.kernel.org" , DTML , lkml , Mark Brown , Linus Walleij Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 9 February 2018 at 14:39, Dmitry Torokhov wrote: > On Thu, Feb 8, 2018 at 10:08 PM, Baolin Wang wrote: >> On some platforms (such as Spreadtrum platform), the GPIO keys can only >> be triggered by level type. > > How do you stop the interrupt from re-triggering as long as the key > stays pressed? We will set the level type irq handler as handle_level_irq(), in this function, it will mask and ack the irq firstly. -- Baolin.wang Best Regards