Received: by 10.223.176.5 with SMTP id f5csp440217wra; Fri, 9 Feb 2018 01:26:03 -0800 (PST) X-Google-Smtp-Source: AH8x2268I/pEs4x5KsjgGLs97H5lwcx6HPZUdFJeaMG/snJvzk/Va1j/Y34i9gdsml0/cghKI3Uj X-Received: by 2002:a17:902:43:: with SMTP id 61-v6mr1930030pla.73.1518168363665; Fri, 09 Feb 2018 01:26:03 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1518168363; cv=none; d=google.com; s=arc-20160816; b=Aq8WAOQOwHET392HcGBakNPHGF6SY51E0MGviJtXXSLA8VB3S+Ud4GzhgZxV4DkyLS aaWojnkjuHuajT3jTTKcUlbmtfXx+5ZN/9xbxQEdZIlMLDuzqW8YV3m4Z5TZDOl4k/+G YH1lOB7/AyknnuQSWQRb6lg+jtDcf6FSrnNpf4CMFwOwDA6laet7p5QzBMgmFOL9c6QF 7nXMtE92gvJrTb7RPNddm0TkNEmO1hYJ+tKhzxRZbQXVvam14iO4vEUgHaTdybph4lw5 hwVkZ9j0pxLMBOxpXmn7g6sMFHuoHr3LZnUn0l0jzSrZRwKmmP2sofcu/z/H5a/GK+51 Jkmg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:message-id:date:references :organization:in-reply-to:subject:cc:to:from :arc-authentication-results; bh=N+EBKsa15G/YXcCqi4lSC022xipwwzrfBl3Hl7m3S5s=; b=TUzKpGP7P97tj5taGvXZn6R3EYi4kTVZpFM3nZE4jG9Lrtg+R8aXxoteVzSMpou78L sj+kc2bH5VWmGyixPDaFQh8rkjC+WK1O5c7b0+1eB1T2PJueKNh2hJrNTtp7gagqWoPy 5ywxdby6H6WPZfWKW3kY72m/iPAMQDOo6XwdMvRTRriLMkeUBRvYqS3CRHCcIfpbTfGw pbnPVhyBlSIEnnWhn/ry6gdH6SntqHYVzKGoyFkLO02upqqfFEKrlN721bp9y1wNGR3K SN5ExvXAHITUwoZJrI7JvX7vh4z9qdeO4tWCK49FA9UpVWUcRNFX/kwtnZP3OFl74aDb 2NHw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id k13si1133151pgs.339.2018.02.09.01.25.46; Fri, 09 Feb 2018 01:26:03 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751317AbeBIJX1 (ORCPT + 99 others); Fri, 9 Feb 2018 04:23:27 -0500 Received: from mga04.intel.com ([192.55.52.120]:60052 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750942AbeBIJXY (ORCPT ); Fri, 9 Feb 2018 04:23:24 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Feb 2018 01:23:24 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,482,1511856000"; d="scan'208";a="29436691" Received: from jnikula-mobl2.fi.intel.com (HELO localhost) ([10.237.72.62]) by fmsmga001.fm.intel.com with ESMTP; 09 Feb 2018 01:23:22 -0800 From: Jani Nikula To: Jonathan Corbet , linux-doc@vger.kernel.org Cc: linux-kernel@vger.kernel.org, mchehab@kernel.org, me@tobin.cc, Jonathan Corbet Subject: Re: [PATCH 3/8] docs: kernel-doc: Move STATE_NORMAL processing into its own function In-Reply-To: <20180207172624.24555-4-corbet@lwn.net> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20180207172624.24555-1-corbet@lwn.net> <20180207172624.24555-4-corbet@lwn.net> Date: Fri, 09 Feb 2018 11:23:17 +0200 Message-ID: <87d11ea54q.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 07 Feb 2018, Jonathan Corbet wrote: > Begin the process of splitting up the nearly 500-line process_file() > function by moving STATE_NORMAL processing to a separate function. > > Signed-off-by: Jonathan Corbet > --- > scripts/kernel-doc | 21 ++++++++++++++++----- > 1 file changed, 16 insertions(+), 5 deletions(-) > > diff --git a/scripts/kernel-doc b/scripts/kernel-doc > index ad30c52f91ef..65150b7c8472 100755 > --- a/scripts/kernel-doc > +++ b/scripts/kernel-doc > @@ -1780,6 +1780,21 @@ sub process_export_file($) { > close(IN); > } > > +# > +# Parsers for the various processing states. > +# > +# STATE_NORMAL: looking for the /** to begin everything. > +# > +sub process_normal() { > + if (/$doc_start/o) { > + $state = STATE_NAME; # next line is always the function name > + $in_doc_sect = 0; > + $declaration_start_line = $. + 1; > + } > +} > + > + > + Superfluous whitespace, but fixed in the next patch so I'll look the other way. Reviewed-by: Jani Nikula > sub process_file($) { > my $file; > my $identifier; > @@ -1807,11 +1822,7 @@ sub process_file($) { > # Replace tabs by spaces > while ($_ =~ s/\t+/' ' x (length($&) * 8 - length($`) % 8)/e) {}; > if ($state == STATE_NORMAL) { > - if (/$doc_start/o) { > - $state = STATE_NAME; # next line is always the function name > - $in_doc_sect = 0; > - $declaration_start_line = $. + 1; > - } > + process_normal(); > } elsif ($state == STATE_NAME) {# this line is the function name (always) > if (/$doc_block/o) { > $state = STATE_DOCBLOCK; -- Jani Nikula, Intel Open Source Technology Center