Received: by 10.223.176.5 with SMTP id f5csp448343wra; Fri, 9 Feb 2018 01:35:40 -0800 (PST) X-Google-Smtp-Source: AH8x224g90IJpBc0uuYmWl2y+gh1hTkLT6HrQlFpclGZQTMvRFwCviJF9+RmDWo2Gqg24s1uarS9 X-Received: by 10.98.254.21 with SMTP id z21mr2219022pfh.48.1518168940493; Fri, 09 Feb 2018 01:35:40 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1518168940; cv=none; d=google.com; s=arc-20160816; b=xk38RwFP2vUo/iP+Nfdie4PA5KqMJC5cEwLiag7gfWqGWU/etUT//zQF9nMaFX0qL2 FH+1ikS+NhUsVakGIUx2qBO6J6dk3chmYsHQPxlTns8Kkr9Kk4rPl69KLZJnV3jVqJb3 Gfdp9WjoKMWvam6VUP9GIBVQXUCLaLgLrwEvUwSAI1OYRMFTm6/C8wNqwyBpwCsQNkyr p4dkTBJyPqtE2eW8EgyzD2j1rCZmrO78NwRM9hGI++QjahhncwLn/peP0/CsbILAGkeG q4vU+E0wu/W2MBXkXDL06x9f0tXaDlCZbvHkivHvpUSvWos8aOmMr6Iss7KXETMwkEIB 2RBA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:arc-authentication-results; bh=iNi3ozSu6hzNBUfRiaDyqHTFW/rnLWBdKx/P7bSqJi8=; b=CJ01fDnj2QBxJZhoI1iXggMugiYE8r7DguLli9g3SSzaRss0bVCBzkXNHw2JqqhLxL 08mo05dBNv2iXWXyxT/sO/mSgVWP8C4Sg9z3PLvC1U6JNxOqgApSp/iZSIeuvGLkVdEl Vq967YOE4c4JxTC894qOo3jgIM5Cn5m4EpcKWfaVinAMF3pBzQKlKayHPNkvsBimKit+ a2y0n/2Pzg58ag/2VY0qOY/+ktr0nJiTjGdbegauE0xJDN0bjMGjy3OpGIirch4OhgLt u0/KKLLkTuyoNml2WzJgblf5ixBQVkXfZBNIIMikK+etbvoGJJi+64xDwaR0mN6xOom7 UpCQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail (test mode) header.i=@8bytes.org header.s=mail-1 header.b=HEyg9TOD; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=8bytes.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p128si1158243pga.15.2018.02.09.01.35.23; Fri, 09 Feb 2018 01:35:40 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail (test mode) header.i=@8bytes.org header.s=mail-1 header.b=HEyg9TOD; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=8bytes.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752814AbeBIJcB (ORCPT + 99 others); Fri, 9 Feb 2018 04:32:01 -0500 Received: from 8bytes.org ([81.169.241.247]:43174 "EHLO theia.8bytes.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752218AbeBIJ0C (ORCPT ); Fri, 9 Feb 2018 04:26:02 -0500 Received: by theia.8bytes.org (Postfix, from userid 1000) id EF4988BA; Fri, 9 Feb 2018 10:25:52 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=8bytes.org; s=mail-1; t=1518168353; bh=SE4G/ZG5ZbTyTgET/WoVOkB+8fLvti7cg8cP4T0eQrI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=HEyg9TODDT9389jMta9fgagX59Qt9g51091z0Rm/EYHzQyQTcWjFwl9sF6xo6IQnw 3Iji+JsNLT+Np+S9jzx7SwXMoFLw5E1uvSpgkDySGAOAbBN/VkA6GCKEVmgWirnPdo IbKJWqExDaOzF48e8FziEOl2YcP4ZnCjD4iFfb9r/IuX0zFER0SYVDDrpp5D5s1fGF dCHXUu5hkJsraZOojnewR7IHin+ZG9yH2dIJcf32wAnZjkKo7C/jaKzoevaQjGieXX 301AVXoblF+MFjuaFnikUIZzQ29EkrxBzibs0hSWhAjTeNcDN46bsmXzo6lCIedD/m PRUGsyEJPNFMw== From: Joerg Roedel To: Thomas Gleixner , Ingo Molnar , "H . Peter Anvin" Cc: x86@kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Linus Torvalds , Andy Lutomirski , Dave Hansen , Josh Poimboeuf , Juergen Gross , Peter Zijlstra , Borislav Petkov , Jiri Kosina , Boris Ostrovsky , Brian Gerst , David Laight , Denys Vlasenko , Eduardo Valentin , Greg KH , Will Deacon , aliguori@amazon.com, daniel.gruss@iaik.tugraz.at, hughd@google.com, keescook@google.com, Andrea Arcangeli , Waiman Long , Pavel Machek , jroedel@suse.de, joro@8bytes.org Subject: [PATCH 16/31] x86/pgtable: Move pgdp kernel/user conversion functions to pgtable.h Date: Fri, 9 Feb 2018 10:25:25 +0100 Message-Id: <1518168340-9392-17-git-send-email-joro@8bytes.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1518168340-9392-1-git-send-email-joro@8bytes.org> References: <1518168340-9392-1-git-send-email-joro@8bytes.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Joerg Roedel Make them available on 32 bit and clone_pgd_range() happy. Signed-off-by: Joerg Roedel --- arch/x86/include/asm/pgtable.h | 49 +++++++++++++++++++++++++++++++++++++++ arch/x86/include/asm/pgtable_64.h | 49 --------------------------------------- 2 files changed, 49 insertions(+), 49 deletions(-) diff --git a/arch/x86/include/asm/pgtable.h b/arch/x86/include/asm/pgtable.h index e42b894..0a9f746 100644 --- a/arch/x86/include/asm/pgtable.h +++ b/arch/x86/include/asm/pgtable.h @@ -1109,6 +1109,55 @@ static inline int pud_write(pud_t pud) return pud_flags(pud) & _PAGE_RW; } +#ifdef CONFIG_PAGE_TABLE_ISOLATION +/* + * All top-level PAGE_TABLE_ISOLATION page tables are order-1 pages + * (8k-aligned and 8k in size). The kernel one is at the beginning 4k and + * the user one is in the last 4k. To switch between them, you + * just need to flip the 12th bit in their addresses. + */ +#define PTI_PGTABLE_SWITCH_BIT PAGE_SHIFT + +/* + * This generates better code than the inline assembly in + * __set_bit(). + */ +static inline void *ptr_set_bit(void *ptr, int bit) +{ + unsigned long __ptr = (unsigned long)ptr; + + __ptr |= BIT(bit); + return (void *)__ptr; +} +static inline void *ptr_clear_bit(void *ptr, int bit) +{ + unsigned long __ptr = (unsigned long)ptr; + + __ptr &= ~BIT(bit); + return (void *)__ptr; +} + +static inline pgd_t *kernel_to_user_pgdp(pgd_t *pgdp) +{ + return ptr_set_bit(pgdp, PTI_PGTABLE_SWITCH_BIT); +} + +static inline pgd_t *user_to_kernel_pgdp(pgd_t *pgdp) +{ + return ptr_clear_bit(pgdp, PTI_PGTABLE_SWITCH_BIT); +} + +static inline p4d_t *kernel_to_user_p4dp(p4d_t *p4dp) +{ + return ptr_set_bit(p4dp, PTI_PGTABLE_SWITCH_BIT); +} + +static inline p4d_t *user_to_kernel_p4dp(p4d_t *p4dp) +{ + return ptr_clear_bit(p4dp, PTI_PGTABLE_SWITCH_BIT); +} +#endif /* CONFIG_PAGE_TABLE_ISOLATION */ + /* * clone_pgd_range(pgd_t *dst, pgd_t *src, int count); * diff --git a/arch/x86/include/asm/pgtable_64.h b/arch/x86/include/asm/pgtable_64.h index 81462e9..58d7f10 100644 --- a/arch/x86/include/asm/pgtable_64.h +++ b/arch/x86/include/asm/pgtable_64.h @@ -131,55 +131,6 @@ static inline pud_t native_pudp_get_and_clear(pud_t *xp) #endif } -#ifdef CONFIG_PAGE_TABLE_ISOLATION -/* - * All top-level PAGE_TABLE_ISOLATION page tables are order-1 pages - * (8k-aligned and 8k in size). The kernel one is at the beginning 4k and - * the user one is in the last 4k. To switch between them, you - * just need to flip the 12th bit in their addresses. - */ -#define PTI_PGTABLE_SWITCH_BIT PAGE_SHIFT - -/* - * This generates better code than the inline assembly in - * __set_bit(). - */ -static inline void *ptr_set_bit(void *ptr, int bit) -{ - unsigned long __ptr = (unsigned long)ptr; - - __ptr |= BIT(bit); - return (void *)__ptr; -} -static inline void *ptr_clear_bit(void *ptr, int bit) -{ - unsigned long __ptr = (unsigned long)ptr; - - __ptr &= ~BIT(bit); - return (void *)__ptr; -} - -static inline pgd_t *kernel_to_user_pgdp(pgd_t *pgdp) -{ - return ptr_set_bit(pgdp, PTI_PGTABLE_SWITCH_BIT); -} - -static inline pgd_t *user_to_kernel_pgdp(pgd_t *pgdp) -{ - return ptr_clear_bit(pgdp, PTI_PGTABLE_SWITCH_BIT); -} - -static inline p4d_t *kernel_to_user_p4dp(p4d_t *p4dp) -{ - return ptr_set_bit(p4dp, PTI_PGTABLE_SWITCH_BIT); -} - -static inline p4d_t *user_to_kernel_p4dp(p4d_t *p4dp) -{ - return ptr_clear_bit(p4dp, PTI_PGTABLE_SWITCH_BIT); -} -#endif /* CONFIG_PAGE_TABLE_ISOLATION */ - /* * Page table pages are page-aligned. The lower half of the top * level is used for userspace and the top half for the kernel. -- 2.7.4