Received: by 10.223.176.5 with SMTP id f5csp456539wra; Fri, 9 Feb 2018 01:45:33 -0800 (PST) X-Google-Smtp-Source: AH8x2247XDFrqfAu30f1N0B35CkLw3OypXwjc/S9RJmlQ6OaQlazfbvXzOU8CWuixh2CxcxoG90o X-Received: by 10.99.154.10 with SMTP id o10mr1833889pge.377.1518169533707; Fri, 09 Feb 2018 01:45:33 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1518169533; cv=none; d=google.com; s=arc-20160816; b=JujOZGbrWZaPMRWXv5CYaGIugndFhM8cgLFATmXSsNSnjfMDUSQ7bZ72OEdml37DQn Y2YIj13aMlTTV4H+WFO7OG7DqUhjTHuLXF0WT9YxnPvGu3DVo00PoJpeFVKqKOw2/LP7 RpHdqAFhtZEmfQ5nRLZJmi0NqqnFcL7qEIyEnMMuAC8N1YmY5Eq6FG7sE2nqHFgs3B14 WhAgITCvC/L3uWIo5P26366/eZki+2wJ0YU8T9o7Jhj44oHyaiC568xxYlM0IcxDeTTJ 7OV5afTquXXXqkCP7kuaFoAg+bRns6sLiOhMHAHn7aY0HgTvKOHolEFhoElWs5rTARlo tcUw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature:arc-authentication-results; bh=DzmKBkr7+tDBxDBGmMxT7wVjaSwVT5rIvCGV32q5GV8=; b=jCN03s2+E+MjWcWvscAS4vhTHVbjGcjj65VXssC5YZMkDZDmFkyfmIP6TUAqTTCgdx xIkPSHdgqPk5rR/nJLK3qXjDO68iDUsWkMs1JOsLuJ+Vw3qYgBRIsvPTAYTim2fcCKpT P/0dbsZtmgiJAGeqD8TySOXqUtwDJwMlpp8ILTyEnTZpY8vtXq5kYkRyyW7IL0QbGcKg /HKSMnEeHmZza1T1jgSarncydh0hwTKWsVXRRJ2+fYmzVU9lI4L7Rwu2Y/EqEkdzspOo vPGuIwqI5jkyg01WeVzPOIFRLQII9u/ZqdGFaWvdbS8b17FA3ZtzwJDlbIdqXwFXbp19 g5WA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=d8aLTwFl; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r5si1161938pgt.92.2018.02.09.01.45.20; Fri, 09 Feb 2018 01:45:33 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=d8aLTwFl; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751313AbeBIJoZ (ORCPT + 99 others); Fri, 9 Feb 2018 04:44:25 -0500 Received: from mail-it0-f46.google.com ([209.85.214.46]:50252 "EHLO mail-it0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751133AbeBIJoW (ORCPT ); Fri, 9 Feb 2018 04:44:22 -0500 Received: by mail-it0-f46.google.com with SMTP id x128so10251982ite.0 for ; Fri, 09 Feb 2018 01:44:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=DzmKBkr7+tDBxDBGmMxT7wVjaSwVT5rIvCGV32q5GV8=; b=d8aLTwFlv7zQLS8Df6ADw3asCXNTxLdjd9ZHZOJi7B+GpwhtsLArWCCTJQtriVXzc4 3fdUQYOzkOI9Wu2FZ6wUeu3vKXUTlqqbBfTPisuvaKHfKk/g8SmSJieIvuLRgwDYJaSK L+O435GMUZCFxOwr6kPzPJK/rZpmxcPeBFguQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=DzmKBkr7+tDBxDBGmMxT7wVjaSwVT5rIvCGV32q5GV8=; b=VGhPa/Tps8nGjJ0QVVxnOJy29jnWopo3Yd2C9zJz/yQAHwRu1ND4CRHFdNyKFMlHd2 WPIucS9Kp4PwmM4opiXr6ur4l8+sCv93D2oH8E8SrANLZbHiMA7r55MXgeQhYMOUFa5w EPEWtwjPXJm9MSs/eVve0BE8fxYdPPSOJTLPOIc7/QigMXQHRtb1WG0Ny9UyV6LhkO3P mp1EYx/6+qmUgPIZJ+y5fcAjgWfTBV3TovrLESexCrURmegfgKofnxkM9xZJoe99/YBh O7qNfciOamwy3bhWxSAW7p7E+Yc07ylRGgr/m31pLcZMvOwUtjVy1WpIPPhpqwF+n0FW iWyA== X-Gm-Message-State: APf1xPAfaPWLCAt0PXn96VkYdsOoSpuBcuvnR/7T2WEYGHenjGzFhYN7 DOTi4Q+1Uj6J4YMipI1p5z4MHQ== X-Received: by 10.36.44.194 with SMTP id i185mr2584678iti.37.1518169461752; Fri, 09 Feb 2018 01:44:21 -0800 (PST) Received: from localhost ([122.172.61.199]) by smtp.gmail.com with ESMTPSA id b185sm2415220itb.20.2018.02.09.01.44.20 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 09 Feb 2018 01:44:21 -0800 (PST) Date: Fri, 9 Feb 2018 15:14:19 +0530 From: Viresh Kumar To: Daniel Lezcano Cc: edubezval@gmail.com, kevin.wangtao@linaro.org, leo.yan@linaro.org, vincent.guittot@linaro.org, amit.kachhap@gmail.com, linux-kernel@vger.kernel.org, Zhang Rui , Javi Merino , "open list:THERMAL" , daniel.thompson@linaro.org Subject: Re: [PATCH 8/8] thermal/drivers/cpu_cooling: Add the combo cpu cooling device Message-ID: <20180209094419.GN28462@vireshk-i7> References: <1516721671-16360-1-git-send-email-daniel.lezcano@linaro.org> <1516721671-16360-9-git-send-email-daniel.lezcano@linaro.org> <20180202104259.GA28462@vireshk-i7> <8dadd854-25ac-68aa-aa9f-33ba76a137a4@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8dadd854-25ac-68aa-aa9f-33ba76a137a4@linaro.org> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02-02-18, 15:30, Daniel Lezcano wrote: > Agree the cpufreq driver can be unloaded and this part needs some > adjustments. Also note that the cpufreq cooling device has two separate set of callbacks, one for the power-specific callbacks. You haven't taken care of them in the combo thing. -- viresh