Received: by 10.223.176.5 with SMTP id f5csp587217wra; Fri, 9 Feb 2018 04:04:40 -0800 (PST) X-Google-Smtp-Source: AH8x225npSoNLMb4gK48Uf6seX93UvhJkxS4uYbN4+xWeaENKFsxvmI5YN3RUYv0C8L+8daIn7NJ X-Received: by 10.98.63.15 with SMTP id m15mr2589654pfa.221.1518177879973; Fri, 09 Feb 2018 04:04:39 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1518177879; cv=none; d=google.com; s=arc-20160816; b=rZQFb6IGaHr9PUsGPvLMVU4/BnBuSy4sZ9Ws3VAOoixJlHMeLv0FuS+vXIqgvcVb1b Td1DTjKpbwuGoqqzYabC5A9E379Sd/jmToNLeaVT/erFcg+QHDrzP4xOpMQg7+Fy5U/2 FtCTw5EcZVIKJFmWrV3WYZvxnVN+ySW3ZJ+hQs6U9sGL1RVD1ym7AErRz3j8xg4g7dNE sfs+2qwgDnU9JdonerPw5OR/0ADoQ4c83DBqtQROiaiZpy1ti/BoCEiJHeg0IZde6khm u9UMZhbK70eSi3pfM3gL/NO93Ts4UHCukB5AWeZz6ZgU7pdf4dBLMpvUKZwqWjpUH3XN oB+g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=NooaMBF/GX7sgPZgs6XzhsR/nQJDGykjEOunonUHw+s=; b=lHQDD4RHpIZIMZt0mUIyWx3MG4pmDwwcCSsvMXVqK7Oic40HR3QvIldYfw1/mmEfnh /31K+Fx3l7IY6fhzoMQ7KvUYZmHFqnZzNVPdV+J9o4t0cdpTIdAmI9D85FvN/thASj3S gCZmhlj/wA0kTxhlFci4yi9zoCJ1Jqo3yQA37FF9sdr1jk9G/yI1E9St9W0XrDfStpe6 ygzkTeLqppFOCxjSsr1sZffENpmm6pcaXFMpNhb+EMq+Vnbrn78oL3J3UUXeXqiSrKuZ SIBZrHclDEQO602WOQcLG9DMZrYqalI4S4Q9+k3O+93Uj+pKGvQI9Xgrhpowlpl0jxMg n+2w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m10si1311372pgn.120.2018.02.09.04.04.10; Fri, 09 Feb 2018 04:04:39 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751024AbeBIMDS (ORCPT + 99 others); Fri, 9 Feb 2018 07:03:18 -0500 Received: from mx2.suse.de ([195.135.220.15]:40258 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750895AbeBIMDR (ORCPT ); Fri, 9 Feb 2018 07:03:17 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay1.suse.de (charybdis-ext.suse.de [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id C5DD0ABE0; Fri, 9 Feb 2018 12:03:15 +0000 (UTC) Date: Fri, 9 Feb 2018 13:03:13 +0100 From: Petr Mladek To: Andy Shevchenko Cc: Geert Uytterhoeven , Adam Borowski , Kees Cook , "Tobin C. Harding" , Sergey Senozhatsky , Steven Rostedt , LKML , Andrew Morton , Joe Perches , "Roberts, William C" , Linus Torvalds , David Laight , Randy Dunlap Subject: Re: [PATCH] vsprintf: avoid misleading "(null)" for %px Message-ID: <20180209120313.rckq3s54nr6yyus4@pathway.suse.cz> References: <20180204174521.21383-1-kilobyte@angband.pl> <20180205094438.pfd7ffymlvklpxe7@pathway.suse.cz> <20180205201555.GQ29988@eros> <20180205205817.72dy7e7xzjcnwmhs@angband.pl> <20180207150328.nuk7f76nutq2trcg@pathway.suse.cz> <20180207154116.xvojw3bzmnmexkav@pathway.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170421 (1.8.2) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu 2018-02-08 17:29:14, Andy Shevchenko wrote: > On Wed, Feb 7, 2018 at 5:41 PM, Petr Mladek wrote: > > On Wed 2018-02-07 16:11:13, Geert Uytterhoeven wrote: > > > To make it clear. I was talking about "%p" format that is handled > > in the pointer() function in lib/vsprintf.c. The "(null)" makes > > sense only for the many modifiers that do deference of > > the pointer, e.g. "%pa", "%pE", "%ph". > > JFYI: I have a patch to eliminate those for %pE & %ph. > > Google for "lib/vsprintf: Remove useless NULL checks" as a first in > the series for new extension to print times. I am slightly confused. IMHO, it makes sense to printk "(null)" for %pE and %ph. Or do you just want to avoid the duplicit check in hex_string() and escaped_string()? Well, it might be better to discuss this once you send the patch. > I just need time to address comments and resend the series. Good to know. Best Regards, Petr