Received: by 10.223.176.5 with SMTP id f5csp597127wra; Fri, 9 Feb 2018 04:13:50 -0800 (PST) X-Google-Smtp-Source: AH8x2263qT6tfmF4M6ek0IdDAw+EIaC0QwSpNVsPweIjRD76g2WxvODo4Q0OFtFuoz9txB4liUaR X-Received: by 10.99.49.84 with SMTP id x81mr2194819pgx.371.1518178430862; Fri, 09 Feb 2018 04:13:50 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1518178430; cv=none; d=google.com; s=arc-20160816; b=zxDJn+yTDPwgiXa5F3bQ+PP1dasJ45rAO4jcS4J7sQLVPoTJr6OaRnyO0GDjOZLsXf IDrEXF5ZkrCK290eE1qO0cH3UIB6h8Oclq4hAOY2Vz5QEyFIdwHJLhUMIuKUk2f8T9iU mD2vSyQK/fF9ziw9Ip+0GJSEQwKaUXNeNBpGopM/NR+sjDGEucGdLLPcwCqY9u1WkEzd wquk7GuCZNQMfUEGSA4cbaAyrhdi0SaDbehY6BH862qeYzcG7BFqvRQVjs+Z9GHn5KB8 eztrQVAgjxx1joSTjOMvEVTYaB+TUpxhbdacUWTvr7iKFqHQRKBgbFowY+QeqOKzPU17 TcUQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :arc-authentication-results; bh=GX9MGty9tpYYCjkrUqLYdJ1J4o4oBQdQj3HFmZHUmow=; b=DWRWfND1Q/XnnD7slBhFFE5e0E64dj3ClhnHzehaS29de3zXvdOCQFjSRBLmbFvtWF R2/8N9TlliQvQkHLvyMW/37wBM8NlV7TwzuoYZ06ocz2SgANV0+Y1eGQwwBWls++ik3X 9hZv6NtlVrotREIFu8U7NyuzACzeiibFUoyJBr8GM4BMAGcxyE+8QF2wxYwuBe+NO1J+ 61Z9X/lMnBXVHvVgOcPOFQM+AuNivD68wk5QSauRdZsVbnq+yZFTU83TSjDUJGy4FWHp KCefR4oi+QNatcVMO6T/LByus8+g6r5LZEX+kfcQT+fy5Ra789u0yB1nlYNddXVAntdr hITg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y184si1316633pgd.291.2018.02.09.04.13.36; Fri, 09 Feb 2018 04:13:50 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751070AbeBIMKT (ORCPT + 99 others); Fri, 9 Feb 2018 07:10:19 -0500 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:50688 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750945AbeBIMKS (ORCPT ); Fri, 9 Feb 2018 07:10:18 -0500 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 8590A4022905; Fri, 9 Feb 2018 12:10:17 +0000 (UTC) Received: from localhost.localdomain.com (ovpn-8-18.pek2.redhat.com [10.72.8.18]) by smtp.corp.redhat.com (Postfix) with ESMTP id 3413C2026DFD; Fri, 9 Feb 2018 12:10:12 +0000 (UTC) From: Baoquan He To: linux-kernel@vger.kernel.org, ebiederm@xmission.com Cc: mingo@kernel.org, tglx@linutronix.de, x86@kernel.org, douly.fnst@cn.fujitsu.com, joro@8bytes.org, uobergfe@redhat.com, prarit@redhat.com, Baoquan He Subject: [PATCH v3 0/5] x86/apic: Fix restoring boot irq mode in reboot and kexec/kdump Date: Fri, 9 Feb 2018 20:10:03 +0800 Message-Id: <20180209121008.28980-1-bhe@redhat.com> X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.6]); Fri, 09 Feb 2018 12:10:17 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.6]); Fri, 09 Feb 2018 12:10:17 +0000 (UTC) for IP:'10.11.54.4' DOMAIN:'int-mx04.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'bhe@redhat.com' RCPT:'' Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org A regression bug was introduced in below commit. commit 522e66464467 ("x86/apic: Disable I/O APIC before shutdown of the local APIC") It caused the action to fail which we try to restore boot irq mode in reboot and kexec/kdump. Details can be seen in patch 0002. Warning can always be seen during kdump kernel boot on qemu/kvm platform. Our customer even saw casual kdump kernel hang once in ~30 attempts during stress testing of kdump on KVM machine. This is v3 post, patches are rearranged and changed according to Eric's suggestions. Baoquan He (5): x86/apic: Split out restore_boot_irq_mode from disable_IO_APIC x86/apic: Fix restoring boot irq mode in reboot and kexec/kdump x86/apic: Remove useless disable_IO_APIC x86/apic: Rename variable/function related to x86_io_apic_ops x86/apic: Set up through-local-APIC on boot CPU if 'noapic' specified arch/x86/include/asm/io_apic.h | 9 +++++---- arch/x86/include/asm/x86_init.h | 8 ++++---- arch/x86/kernel/apic/apic.c | 2 +- arch/x86/kernel/apic/io_apic.c | 16 ++++------------ arch/x86/kernel/crash.c | 3 ++- arch/x86/kernel/machine_kexec_32.c | 7 +++---- arch/x86/kernel/machine_kexec_64.c | 7 +++---- arch/x86/kernel/reboot.c | 3 ++- arch/x86/kernel/x86_init.c | 6 +++--- arch/x86/xen/apic.c | 2 +- drivers/iommu/irq_remapping.c | 4 ++-- 11 files changed, 30 insertions(+), 37 deletions(-) -- 2.13.6