Received: by 10.223.176.5 with SMTP id f5csp698973wra; Fri, 9 Feb 2018 05:54:24 -0800 (PST) X-Google-Smtp-Source: AH8x225GyQvcIceNsDAOmQKZDtHy42DyAh7CJBhssw584/54Bp/Y7g2UvoA7QNnf003y8ZcH/xzo X-Received: by 10.98.64.132 with SMTP id f4mr2899932pfd.232.1518184464478; Fri, 09 Feb 2018 05:54:24 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1518184464; cv=none; d=google.com; s=arc-20160816; b=fyiCHJ7abndHp1/SqbETpdh3XUUz8vSWSl/xHl4vqDi4nD4zEDkuBtCU5NQ23bUWUu 3lQyCNAeI/zftHxhb3O4L7AxkJsVvPRF168LygEg0rdgftPsM6z5pZsv925kzxPAtRt+ bCF4Tfwx6Cm4trmkq/nJu9zk602VkvOIxSlKDzCKrcBPVnhqHRKdSqXozMSnsi36F1kU HYoTKcEhiQ4zR7R+J0nONoJYhDmaokHRvL/qNxTJjtfNbeIEz/vmHq/vhdj4UPzXvsYc xn2YP5M2LlTcaOdq4iLUyQfhXQpkqnWFZyz4e45PwUAKw4JFZiFeM/e2UaIsS2VuvPg7 7lOg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:references :in-reply-to:message-id:date:subject:cc:to:from :arc-authentication-results; bh=hI+308x+y5NM9k2SUQ5AkHRyuQ0QyetEYxWn7yNVBfw=; b=TxugupY1e2fOAW3iB1QrFhb9GKPHoVIPJe9XSgtay1r/tfMBerbjl94Kbyyt/HZ+y0 QaNIufeqaC/frymBCfB6SUSZDDSv+76fS8L4T3L3Im7/cyevVH79ydr3oCzCa/P+g5RE YCcIk0hvPqUkLfqBpKeU21dGbH4BXQ8YQVWdYmCGwf8rQYrW/0kg13PXuIj4b/C26+rJ 9zvHYBvoFbnZ6a6EsaN1Y3YAFQ9JihVWyJL+CyBPvkh0VQqGp933ghVnJbSvipIc/85W HDRbXAEruHnaeBCmN4TUODTaAQsPxAvoqdM+FZUB0u079uO593LYyMKTMzt7EbYOBcez oGDw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p9-v6si1546045pls.317.2018.02.09.05.54.10; Fri, 09 Feb 2018 05:54:24 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753742AbeBINqF (ORCPT + 99 others); Fri, 9 Feb 2018 08:46:05 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:52412 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753707AbeBINqC (ORCPT ); Fri, 9 Feb 2018 08:46:02 -0500 Received: from localhost (LFbn-1-12258-90.w90-92.abo.wanadoo.fr [90.92.71.90]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id D7BC0111C; Fri, 9 Feb 2018 13:46:01 +0000 (UTC) From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Li RongQing , Eric Dumazet , "David S. Miller" Subject: [PATCH 4.14 09/22] tcp: release sk_frag.page in tcp_disconnect Date: Fri, 9 Feb 2018 14:39:58 +0100 Message-Id: <20180209133934.727817804@linuxfoundation.org> X-Mailer: git-send-email 2.16.1 In-Reply-To: <20180209133934.024795822@linuxfoundation.org> References: <20180209133934.024795822@linuxfoundation.org> User-Agent: quilt/0.65 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.14-stable review patch. If anyone has any objections, please let me know. ------------------ From: Li RongQing [ Upstream commit 9b42d55a66d388e4dd5550107df051a9637564fc ] socket can be disconnected and gets transformed back to a listening socket, if sk_frag.page is not released, which will be cloned into a new socket by sk_clone_lock, but the reference count of this page is increased, lead to a use after free or double free issue Signed-off-by: Li RongQing Cc: Eric Dumazet Signed-off-by: David S. Miller Signed-off-by: Greg Kroah-Hartman --- net/ipv4/tcp.c | 6 ++++++ 1 file changed, 6 insertions(+) --- a/net/ipv4/tcp.c +++ b/net/ipv4/tcp.c @@ -2379,6 +2379,12 @@ int tcp_disconnect(struct sock *sk, int WARN_ON(inet->inet_num && !icsk->icsk_bind_hash); + if (sk->sk_frag.page) { + put_page(sk->sk_frag.page); + sk->sk_frag.page = NULL; + sk->sk_frag.offset = 0; + } + sk->sk_error_report(sk); return err; }