Received: by 10.223.185.116 with SMTP id b49csp21020wrg; Sat, 10 Feb 2018 01:21:52 -0800 (PST) X-Google-Smtp-Source: AH8x224CTlh4di4vCGON2UecSVakUjcpySKJY77v4wsIhqj8hDdJOluy/sGbfE66L913w1FwgqxF X-Received: by 10.99.172.66 with SMTP id z2mr3260746pgn.273.1518254512842; Sat, 10 Feb 2018 01:21:52 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1518254512; cv=none; d=google.com; s=arc-20160816; b=heyagycKasOBR4lxyQ7Dg6V+vAJhoFTXapXbpRdKLcTAPo4WGra9jXZcUiodX5gEaX oz68A5cT4GbsXDc7hWR7TvRaYx7gXPSp9JaLNvyiaKu9KXaERmotpPFq6LuynhDBoei+ 6fG8ilvzo/gi5Mx+6q+4sTbR7tOkSkxi2fUEN99Bld8LI5BJCkRxjPadIgBLlY2P9G5A r7JLzqIrDBhfDx7fHnjjUUZaONqip0qW0Wu3+CTAAHA8dCxgmWWIRVC+IXDuFCUu26CC MYoxwaBaDKsKTkjX5uzTINTtOT4GLcU8HaFNXvojFwpQDO+Lt4CwlQHzXv0ueOaitiuI Jm7g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:arc-authentication-results; bh=H2Wg9nRuNX02l7bkxEYKY/cnVmAhcd/Ie5xGJ5iD9OM=; b=UrDI3uQWIoKDObjoHvrM/91wtIc8WCI9RiLTjpRM78upu9n8hwSL0XR9QuxtwptmOg 04/O4CnOi3rYRGvg141l8+I9HXPJRbY322VCQuu1CA2/N1OgURabwOkPDpzNZAH5maGr dRcZKR6+k3gG05/eGY6vvPp4wrSi/l01J3uxYiyJVLcXcz8Ap4wwSG0uKe4QcuB0TbT0 dXE8CRVtYGlFTv0I3aYchNLQ+0VFMO05T3Oe+rf57tJqSUf75dVDb8rnRWH7tOTe+nK1 IBz8cfam37gqq2EmYNQ36OsqC+ExP+T8leM5NxnnjSMox1huL48dkFgi0fIGOOwxgpWD YE/Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=eK4VSauh; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w22-v6si1030853plk.66.2018.02.10.01.21.39; Sat, 10 Feb 2018 01:21:52 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=eK4VSauh; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752037AbeBJJTl (ORCPT + 99 others); Sat, 10 Feb 2018 04:19:41 -0500 Received: from mail-lf0-f66.google.com ([209.85.215.66]:46453 "EHLO mail-lf0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751851AbeBJJTh (ORCPT ); Sat, 10 Feb 2018 04:19:37 -0500 Received: by mail-lf0-f66.google.com with SMTP id q194so14351827lfe.13; Sat, 10 Feb 2018 01:19:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=H2Wg9nRuNX02l7bkxEYKY/cnVmAhcd/Ie5xGJ5iD9OM=; b=eK4VSauhUWn0kkRZvta7w/rr8gIWtodVrUSz7prHhaZGRkxRjSvApQq68vzlQfP299 KG3IpRhJ4ph8JBbD+bqHyl8sR9Jg1MTobg8yS63IXILu8ajadSg80eE9HZj4fmQuSDvJ Q/YyXH0B3dZ48w4yHLqTtDe/pDQjrBWtwgJsxrTcQ4PkQs+4Z0AGrHwt7WIW756RhcCa rxzCTc/KUkX34u0jdnlSMBtuYCx7ffajNhxfR5j2UeBuRQThghn8RTmKf65QcVB1E7vs WJuSXw7Dfx/esmFKPyuajeIl/HwFVJhMd/HErzmhuRWHp+OdrnTLoDz7xyVVUv2gVEsy UrTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=H2Wg9nRuNX02l7bkxEYKY/cnVmAhcd/Ie5xGJ5iD9OM=; b=EjG/AzmRHr8NiJkBWWh5aM6ODgZnqSB8/JncuWBPD4xHCeqR8JBCDmGEIdd4S67qLC s9QOOEurLwoLF1HMf0U5gvpLD0ePA5CAlrfYBhqt+ERDkYgVwn8IoOU3m54n+zGeuwsN twhB3eGVTgq/LUhKng/NGsSqCWJTZqThkoOwSUyvvLmhlYfv2XKKb6ScQHR6bHJQ5m6n xPldV/PTDdVtcY6VtGaQjp4Y0jscSEbz7tIKj8ffPejzqxw4sObXo9ISGDEV95fOMuxz LJiHqqdQE6Xx67bBmrOK9WyuwsPNDfLM4DGORshDAYPn/NxjkMatEkBFpIDtpm85elw/ yHsA== X-Gm-Message-State: APf1xPA/azuNyuosPe/jXrl/NT8jvhQUDZF6RWA0VUdi/lP9TZEQ3B4J mGnSWUdVoaBXw6mLPQDpH7g= X-Received: by 10.46.44.21 with SMTP id s21mr3986426ljs.117.1518254375287; Sat, 10 Feb 2018 01:19:35 -0800 (PST) Received: from localhost.localdomain ([46.194.112.145]) by smtp.gmail.com with ESMTPSA id s9sm794551lfe.48.2018.02.10.01.19.32 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 10 Feb 2018 01:19:34 -0800 (PST) From: Marcus Folkesson To: Wim Van Sebroeck , Guenter Roeck , Rob Herring , Mark Rutland , Carlo Caione , Kevin Hilman , Matthias Brugger , Barry Song , Maxime Ripard , Chen-Yu Tsai , Linus Walleij , Vladimir Zapolskiy , Sylvain Lemieux , Nicolas Ferre , Alexandre Belloni Cc: linux-watchdog@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, Marcus Folkesson Subject: [PATCH v2 4/7] watchdog: pnx4008: make use of timeout-secs provided in devicetree Date: Sat, 10 Feb 2018 10:19:08 +0100 Message-Id: <20180210091911.3644-4-marcus.folkesson@gmail.com> X-Mailer: git-send-email 2.15.1 In-Reply-To: <20180210091911.3644-1-marcus.folkesson@gmail.com> References: <20180210091911.3644-1-marcus.folkesson@gmail.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org watchdog_init_timeout() will allways pick timeout_param since it defaults to a valid timeout. Following best practice described in Documentation/watchdog/watchdog-kernel-api.txt to make use of the parameter logic. Signed-off-by: Marcus Folkesson Reviewed-by: Guenter Roeck --- drivers/watchdog/pnx4008_wdt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/watchdog/pnx4008_wdt.c b/drivers/watchdog/pnx4008_wdt.c index 0529aed158a4..8e261799c84e 100644 --- a/drivers/watchdog/pnx4008_wdt.c +++ b/drivers/watchdog/pnx4008_wdt.c @@ -78,7 +78,7 @@ #define WDOG_COUNTER_RATE 13000000 /*the counter clock is 13 MHz fixed */ static bool nowayout = WATCHDOG_NOWAYOUT; -static unsigned int heartbeat = DEFAULT_HEARTBEAT; +static unsigned int heartbeat; static DEFINE_SPINLOCK(io_lock); static void __iomem *wdt_base; -- 2.15.1