Received: by 10.223.185.116 with SMTP id b49csp22073wrg; Sat, 10 Feb 2018 01:23:38 -0800 (PST) X-Google-Smtp-Source: AH8x226KwKG/bShNyvCUTtg6s18qfNTo/E8+Tz4AsZj/rBlYLdOdP/hqheP0WB5Ej0repn9enTtU X-Received: by 10.99.127.21 with SMTP id a21mr4516226pgd.178.1518254618049; Sat, 10 Feb 2018 01:23:38 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1518254618; cv=none; d=google.com; s=arc-20160816; b=vgabS0C4cUuoRKaDS+W9+kqAciF9Cf4p6rsrsf6mOVFCEXGxCwDLjorh/LodsoX5+r lRMwmi3PO/yC5/XxVCq4kE6eat4sXzoZnCGhkhghA3FbVRf2CdXbigzFsiPDbkigjUTu /wf8ZQshDC8HRDQj90CqOhnPcd9J2Xa3AODtp0fLtQKYO2zNGbtgcsOvpDJeknC2Ffyu LUsbIhdtG3xKChXwtXzHYN867rs1yllhIwbHoBlUBragjmtYIa0MQH61rNh4nQSQzs5C DjNM2wM9arAK2EQISytwhHW3pmTcOtFcli12wnz7HuTTfZzAYr2sSS93P0uQxhTMHkAN IEkA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :dkim-signature:arc-authentication-results; bh=g7Rb9scUjH6WY2ooNjKyKkhPY0Sz7KX83XiIvEa9qe4=; b=gxycGnGwuSgbjWaEaf5XZCLBYKfOMtsJz3DowFM0BFd4np42+DzVcssknw7y0qO6cP FjrQmaO9GOCjxMqeTNFfrP6Xp62Ip6XdXLiL917G2hDSbeigVFXeJyYEkY7ETcPhY5l1 zXSioOBifASyEYe8/tKezeOAQXy6x9VG8lAe4Y9j9dKawMb/0M9I3Sae1TQ+/EIZE9b5 e87ZM1Jl34DhiCrGGMxUrPqa24AP5GOy03xpNZebZ3TFJDnd304DcfMaD8TP2WeYEvbJ 9DQgt4ao+ZjxGPYfSeGzd9T81abQkhkLB1LcyKABhr6rKT80xMqPL/DU8HKbTmcR4Ybq xnEw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=kA5Zklst; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t15si603917pgf.370.2018.02.10.01.23.24; Sat, 10 Feb 2018 01:23:38 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=kA5Zklst; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751253AbeBJJTb (ORCPT + 99 others); Sat, 10 Feb 2018 04:19:31 -0500 Received: from mail-lf0-f67.google.com ([209.85.215.67]:45262 "EHLO mail-lf0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750909AbeBJJT2 (ORCPT ); Sat, 10 Feb 2018 04:19:28 -0500 Received: by mail-lf0-f67.google.com with SMTP id x196so14338046lfd.12; Sat, 10 Feb 2018 01:19:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=g7Rb9scUjH6WY2ooNjKyKkhPY0Sz7KX83XiIvEa9qe4=; b=kA5ZklstmdijfEHe9bRBuRPtau6fKWn/qfRamrH8fUpvVnk5Vjx95ZsNUee6L+5LSt f3c7UcM5qk3KD7TRuRTQQ1B49O6SA82Hxh5nMuNLBRE1n1fADQaDRnT+Z9/mbcxHbM2a +ZzJnqorUfDkb3xF6SKFbVrcPulJBNnldUeMhRQ56Gfq6GqLRv4VlF96tx2d7qHkxN/I wW8S4zentB+w1B+mwBLTqRzNhj/SaMuyENKSuYCm+oiVTbXDIV7M4Dp2nnIUr7O6lRY4 KJqkBm4soHUiSGF5ZXnCCzVHfIpqQFeRzvETENXPg+zQ0m8saD9/UnvVOjVCqyu4oRcI lnuQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=g7Rb9scUjH6WY2ooNjKyKkhPY0Sz7KX83XiIvEa9qe4=; b=cmif+xF2E5yL82NonoCSKrIHSSHr2rkB731vpV5kcle/727YixLcVnzjSIETf6zauK Bo7e0ItKgNlRo9iTAMlLiOjFlo0J/ggq47gOedpvfWZRy7cJALctT8ZefpnHQRkFYu2P 0j3nHxcEmT3BNfoymkTyJcOg1gfB6+gaOEGktQFhAfpy2LfN8QdZZjZHNhFgTSwctTAr Lhip0hYDDT7k6ccyUCrVbYkaHJ2yxZL4SJ36/17ap7+O2bBeIBfORw2zZiD4jDOACI5x uoZBylNtdNT+Q0QZwE35EQwX/nC8sVYOYECfoe4MwfIH8WX7bp5Y5h82W9gGHhSEgX9K grpg== X-Gm-Message-State: APf1xPAdXMOXdpFHa9OwoS6Cj8K9U/hgUdLibj44YZCGFMi/VEWeqXVb JoJCd+ijbl+fX8aA2K2UuOWANLBW X-Received: by 10.25.178.207 with SMTP id t76mr3808615lfk.111.1518254367038; Sat, 10 Feb 2018 01:19:27 -0800 (PST) Received: from localhost.localdomain ([46.194.112.145]) by smtp.gmail.com with ESMTPSA id s9sm794551lfe.48.2018.02.10.01.19.24 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 10 Feb 2018 01:19:25 -0800 (PST) From: Marcus Folkesson To: Wim Van Sebroeck , Guenter Roeck , Rob Herring , Mark Rutland , Carlo Caione , Kevin Hilman , Matthias Brugger , Barry Song , Maxime Ripard , Chen-Yu Tsai , Linus Walleij , Vladimir Zapolskiy , Sylvain Lemieux , Nicolas Ferre , Alexandre Belloni Cc: linux-watchdog@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, Marcus Folkesson Subject: [PATCH v2 1/7] watchdog: sama5d4: make use of timeout-secs provided in devicetree Date: Sat, 10 Feb 2018 10:19:05 +0100 Message-Id: <20180210091911.3644-1-marcus.folkesson@gmail.com> X-Mailer: git-send-email 2.15.1 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org watchdog_init_timeout() will allways pick timeout_param since it defaults to a valid timeout. Following best practice described in Documentation/watchdog/watchdog-kernel-api.txt to make use of the parameter logic. Signed-off-by: Marcus Folkesson Reviewed-by: Guenter Roeck --- drivers/watchdog/sama5d4_wdt.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/watchdog/sama5d4_wdt.c b/drivers/watchdog/sama5d4_wdt.c index 0ae947c3d7bc..e6c679383734 100644 --- a/drivers/watchdog/sama5d4_wdt.c +++ b/drivers/watchdog/sama5d4_wdt.c @@ -33,7 +33,7 @@ struct sama5d4_wdt { unsigned long last_ping; }; -static int wdt_timeout = WDT_DEFAULT_TIMEOUT; +static int wdt_timeout; static bool nowayout = WATCHDOG_NOWAYOUT; module_param(wdt_timeout, int, 0); @@ -212,7 +212,7 @@ static int sama5d4_wdt_probe(struct platform_device *pdev) return -ENOMEM; wdd = &wdt->wdd; - wdd->timeout = wdt_timeout; + wdd->timeout = WDT_DEFAULT_TIMEOUT; wdd->info = &sama5d4_wdt_info; wdd->ops = &sama5d4_wdt_ops; wdd->min_timeout = MIN_WDT_TIMEOUT; -- 2.15.1