Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
In-Reply-To: <CAMz4kuK9GAR8Ao7RbN5+QUo2-v-bDXaCbtGrzE7Qx_TY=xfTng@mail.gmail.com>
References: <6fff71482ed7bb63afa46c024638c0a72810ce29.1517913264.git.baolin.wang@linaro.org>
 <CAAfSe-uQqVPB5B0OYij-bx6Q7AnGnONNqYtwWkU_b2rSJfCpfw@mail.gmail.com> <CAMz4kuK9GAR8Ao7RbN5+QUo2-v-bDXaCbtGrzE7Qx_TY=xfTng@mail.gmail.com>
From:   Chunyan Zhang <zhang.lyra@gmail.com>
Date:   Sun, 11 Feb 2018 19:41:06 +0800
Message-ID: <CAAfSe-v_i=EnrvKWKmWsi4wSx=EiHK_0Q7KfouaQ8o5iYo+yrA@mail.gmail.com>
Subject: Re: [PATCH] arm64: Enable SPRD_TIMER
To:     Baolin Wang <baolin.wang@linaro.org>
Cc:     Catalin Marinas <catalin.marinas@arm.com>,
        Will Deacon <will.deacon@arm.com>,
        Arnd Bergmann <arnd@arndb.de>,
        Linux ARM <linux-arm-kernel@lists.infradead.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Mark Brown <broonie@kernel.org>,
        =?UTF-8?B?T3Jzb24gWmhhaSAo57+f5LqsKQ==?= 
        <orson.zhai@spreadtrum.com>, nianfu.bai@spreadtrum.com,
        geng.ren@spreadtrum.com
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Baolin,

On 7 February 2018 at 11:12, Baolin Wang <baolin.wang@linaro.org> wrote:
> On 7 February 2018 at 10:31, Chunyan Zhang <zhang.lyra@gmail.com> wrote:
>> Hi Baolin,
>>
>> On 6 February 2018 at 18:36, Baolin Wang <baolin.wang@linaro.org> wrote:
>>> Enable Spreadtrum timer driver for Spreadtrum plaform, which will be used
>>> as tick broadcast device.
>>>
>>> Signed-off-by: Baolin Wang <baolin.wang@linaro.org>
>>> ---
>>>  arch/arm64/Kconfig.platforms |    1 +
>>>  1 file changed, 1 insertion(+)
>>>
>>> diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms
>>> index fbedbd8..3e0bbb0 100644
>>> --- a/arch/arm64/Kconfig.platforms
>>> +++ b/arch/arm64/Kconfig.platforms
>>> @@ -224,6 +224,7 @@ config ARCH_TEGRA
>>>
>>>  config ARCH_SPRD
>>>         bool "Spreadtrum SoC platform"
>>> +       select SPRD_TIMER
>>
>> Do we have to select SPRD_TIMER here? SC9836, SC9860 have been working
>> with a minimum system without SPRD TIMER.
>
> Yes, we need register this timer as the tick broadcast device,
> otherwise we will use one hrtimer to be registered the broadcast
> device, which will affect the No-Hz of CPU attaching the
> broadcast-hrtimer.

Again, Spreadtrum's two boards - SC9836/SC9860 - can run into console
without SPRD_TIMER, we can also debug some kernel origianl feature or
some basic drivers on these two boards, such as CoreSight, clock
driver, etc.

In my opinion we should keep the kernel as simple as possible, the
above information can go to the 'help' graph of SPRD_TIMER in its
Kconfig.

Thanks,
Chunyan

>
> --
> Baolin.wang
> Best Regards