Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH 2/2] xen: xenbus: WARN_ON XS_TRANSACTION_{START,END}
 misuse
To:     Simon Gaiser <simon@invisiblethingslab.com>,
        xen-devel@lists.xenproject.org
Cc:     Juergen Gross <jgross@suse.com>, linux-kernel@vger.kernel.org
References: <20180207222236.7434-1-simon@invisiblethingslab.com>
 <20180207222236.7434-2-simon@invisiblethingslab.com>
 <8a0fd059-7acf-3279-10f9-649c19522e2a@oracle.com>
 <66103cca-321e-6950-2083-6f5d068e12e6@invisiblethingslab.com>
From:   Boris Ostrovsky <boris.ostrovsky@oracle.com>
Message-ID: <0bf1782a-b7c4-1775-c2cb-6e68fe62a199@oracle.com>
Date:   Sun, 11 Feb 2018 10:28:38 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.6.0
MIME-Version: 1.0
In-Reply-To: <66103cca-321e-6950-2083-6f5d068e12e6@invisiblethingslab.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On 02/10/2018 08:27 PM, Simon Gaiser wrote:
> Boris Ostrovsky:
>> On 02/07/2018 05:22 PM, Simon Gaiser wrote:
>>> +    users_old = xs_state_users;
>>>        xs_state_users--;
>>>        if ((req->type == XS_TRANSACTION_START && req->msg.type == XS_ERROR) ||
>>>            req->type == XS_TRANSACTION_END)
>>>            xs_state_users--;
>>> +    if (WARN_ON(xs_state_users > users_old))
>>
>>
>> WARN_ON_ONCE()?
> 
> Since we "fix" the wrong decrement by clamping at zero it should not
> happen immediately again. But if you prefer _ONCE I can change it.
> 


If this error can happen once then someone at least theoretically can 
construct a case when it is repeated. So let's switch to _ONCE() variant.

Thanks.
-boris