Received: by 10.223.185.116 with SMTP id b49csp1482810wrg; Sun, 11 Feb 2018 13:10:20 -0800 (PST) X-Google-Smtp-Source: AH8x225BD5+atLK6q//9WlIDUmXG9va+PrzkRvFLpJm2vaHqCi9l57/vGQME0tBVUVABoiZYV6te X-Received: by 10.98.234.19 with SMTP id t19mr9676305pfh.74.1518383420051; Sun, 11 Feb 2018 13:10:20 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1518383420; cv=none; d=google.com; s=arc-20160816; b=o8PLABn3ETnRFSeptxYd0xlLCjuLyE+qgzFnsmUUIjM6Qpjw8YPLOJNY8hVh6lFsbo Bnwg6pq/G3SjH87ImVFJ9k0t1D2gA0MbShNXxqP1/9/SrIhKm8g1DZt/ruUzrulaPs5g XI3kOIyuyqn0KqLuiZ4uohpjAzFzxy9pwfmX2+RXjWm3gWegOmHOV30JRGswWP4l94Re zzrvwdyuG/B9HRPGba6sWYLvL8cJFVJ5rM3kh5ABoPK0IklSY0VOulDdrK+3bqqOY5XL kyobkQUSMj+2hIhdZYiTAppLSPxwiXFzFI15tM43mcXv0BqUWxz2A8jZpveVBdsV0KUj w32g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature:arc-authentication-results; bh=IOUGHiBBACiwNchu13ulbIro5Dnf+tNmVWwx71tfrXI=; b=H7kG5tJzEG42jiqdVFnoUhBa1BkMXCa1JA1BowUXRLOfCLJpImcNYGcVdBmNEv6wdK xdvQfX3QDR8WdoIdzIdIyst7Mn6BtNZb2O+TWsB/NwSyPpdeAwU4ZjlfXI3unjxlHdyA fTscqlD4RQnk9muMVWY29Meq4Qvs4s5bk2kNZ3vE4eaXiZ2Rcujav4tYgTa4xdaY4N/w OAXARkS/yBHZdvXaLnK3w06B+ax2LecyF/QQePbotE/HFulb8D1Nkt5lVeonTOZi7LCo Q4HgwpHzUe4b7et2iRJetkU+2styorwLVDjevDbtjXYrRBBkE+RzJxGgdzenc0nOtRDV Dlsg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kempniu.pl header.s=google header.b=gwcn8zcW; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=kempniu.pl Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c11-v6si1354810pll.95.2018.02.11.13.10.06; Sun, 11 Feb 2018 13:10:20 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kempniu.pl header.s=google header.b=gwcn8zcW; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=kempniu.pl Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932219AbeBKVHp (ORCPT + 99 others); Sun, 11 Feb 2018 16:07:45 -0500 Received: from mail-lf0-f65.google.com ([209.85.215.65]:34291 "EHLO mail-lf0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932132AbeBKVHm (ORCPT ); Sun, 11 Feb 2018 16:07:42 -0500 Received: by mail-lf0-f65.google.com with SMTP id k19so17935045lfj.1 for ; Sun, 11 Feb 2018 13:07:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kempniu.pl; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=IOUGHiBBACiwNchu13ulbIro5Dnf+tNmVWwx71tfrXI=; b=gwcn8zcWTniQGmoG9GdA5MBHk6AVpQq/eo83fgZ2GcRmjzRxTRxXK0afmYfAqNkze/ frZ3pffSKoGDpvQmkYoYSopJyRU27XqaT8v0BwC+0gKWpZ2TB5sxSvNzTIfJ34xY/NNf aWyCxEDG32wBI5B8fymXZYWfkX1NIUsHmxIEk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=IOUGHiBBACiwNchu13ulbIro5Dnf+tNmVWwx71tfrXI=; b=I/mNuajpPYOCRpR4fG/QptdyFejdYpXFCLLlQuNW4HraDuOP1A6VGYJ9xAdd6SZD/G 4dz6iX4T1mgt+N6VBxPKGvItrkDuDmT3H0d+3dPoQ7r3/aYy5Qx6kLAo0xjEaN0CxitZ uNIbtONenBTo/wyjsqFiel7KacsV4IPDqLJK6Wd1s1OSoGdVXAGruzNdW/9Twi6hAL9b pAY+i40Iob+OMArkzLVXvVpFpGZGgc+6UvMO/4UFbINV7EcL0V4aOCw5zU5cSB5LEHV6 YJIc4EJb3F6SDU2JLRz8wblSKLW7iqninBnyCouQmYHwCWRSgW4HMqvAREKcdJIif0Q9 qQTg== X-Gm-Message-State: APf1xPBlS2jJOxrFEhaiUFQHAE7rYiEHr+di4vBE/WtdEuOvvKxjVY15 FNrB4wvHCsdYry/8qQ6wUb0ykQ== X-Received: by 10.25.77.212 with SMTP id a203mr6241733lfb.14.1518383261447; Sun, 11 Feb 2018 13:07:41 -0800 (PST) Received: from kmp-mobile.hq.kempniu.pl (kmp-mobile.hq.kempniu.pl. [2001:470:64df:111::1b01]) by smtp.googlemail.com with ESMTPSA id y198sm1390477lfd.62.2018.02.11.13.07.40 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 11 Feb 2018 13:07:40 -0800 (PST) From: =?UTF-8?q?Micha=C5=82=20K=C4=99pie=C5=84?= To: Jonathan Woithe , Darren Hart , Andy Shevchenko Cc: platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 4/7] platform/x86: fujitsu-laptop: Clearly distinguish module parameters Date: Sun, 11 Feb 2018 22:07:24 +0100 Message-Id: <20180211210727.12130-5-kernel@kempniu.pl> X-Mailer: git-send-email 2.16.1 In-Reply-To: <20180211210727.12130-1-kernel@kempniu.pl> References: <20180211210727.12130-1-kernel@kempniu.pl> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org In order to improve code clarity, move declarations of variables that are module parameters higher up and add a comment. Signed-off-by: Michał Kępień --- drivers/platform/x86/fujitsu-laptop.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/platform/x86/fujitsu-laptop.c b/drivers/platform/x86/fujitsu-laptop.c index 94ff7f86fa8f..7888b779d6c5 100644 --- a/drivers/platform/x86/fujitsu-laptop.c +++ b/drivers/platform/x86/fujitsu-laptop.c @@ -112,6 +112,10 @@ #define MAX_HOTKEY_RINGBUFFER_SIZE 100 #define RINGBUFFERSIZE 40 +/* Module parameters */ +static int use_alt_lcd_levels = -1; +static bool disable_brightness_adjust; + /* Device controlling the backlight and associated keys */ struct fujitsu_bl { struct input_dev *input; @@ -122,8 +126,6 @@ struct fujitsu_bl { }; static struct fujitsu_bl *fujitsu_bl; -static int use_alt_lcd_levels = -1; -static bool disable_brightness_adjust; /* Device used to access hotkeys and other features on the laptop */ struct fujitsu_laptop { -- 2.16.1