Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Sun, 11 Feb 2018 21:39:05 +0000 (GMT)
From:   James Simmons <jsimmons@infradead.org>
To:     Sumit Pundir <pundirsumit11@gmail.com>
cc:     oleg.drokin@intel.com, andreas.dilger@intel.com,
        gregkh@linuxfoundation.org, lustre-devel@lists.lustre.org,
        devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: lustre: lnet: return of an error code should
 be negative
In-Reply-To: <1517117095-12643-1-git-send-email-pundirsumit11@gmail.com>
Message-ID: <alpine.LFD.2.21.1802112138340.21780@casper.infradead.org>
References: <1517117095-12643-1-git-send-email-pundirsumit11@gmail.com>
User-Agent: Alpine 2.21 (LFD 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


> Return value of error codes should typically be negative.
> Issue reported by checkpatch.pl
>

Reviewed-by: James Simmons <jsimmons@infradead.org>
 
> Signed-off-by: Sumit Pundir <pundirsumit11@gmail.com>
> ---
>  drivers/staging/lustre/lnet/selftest/framework.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/lustre/lnet/selftest/framework.c b/drivers/staging/lustre/lnet/selftest/framework.c
> index c7697f6..0ca1e3a 100644
> --- a/drivers/staging/lustre/lnet/selftest/framework.c
> +++ b/drivers/staging/lustre/lnet/selftest/framework.c
> @@ -187,7 +187,7 @@ sfw_del_session_timer(void)
>  		return 0;
>  	}
>  
> -	return EBUSY; /* racing with sfw_session_expired() */
> +	return -EBUSY; /* racing with sfw_session_expired() */
>  }
>  
>  static void
> -- 
> 2.7.4
> 
>