Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   NeilBrown <neilb@suse.com>
To:     James Simmons <jsimmons@infradead.org>,
        Oleg Drokin <oleg.drokin@intel.com>
Date:   Mon, 12 Feb 2018 10:50:04 +1100
Cc:     devel@driverdev.osuosl.org,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        wang di <di.wang@intel.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Lustre Development List <lustre-devel@lists.lustre.org>
Subject: Re: [lustre-devel] [PATCH 41/80] staging: lustre: lmv: separate master object with master stripe
In-Reply-To: <alpine.LFD.2.21.1802102027560.5700@casper.infradead.org>
References: <1471378773-24590-1-git-send-email-jsimmons@infradead.org> <1471378773-24590-42-git-send-email-jsimmons@infradead.org> <87r2pvkkl5.fsf@notabene.neil.brown.name> <09CE6CEC-52BC-4B29-B609-40DE68A64A33@intel.com> <87o9kylux7.fsf@notabene.neil.brown.name> <FC7E817D-BA15-4D0A-9976-F1343F9B022A@intel.com> <alpine.LFD.2.21.1802102027560.5700@casper.infradead.org>
Message-ID: <87eflrrsr7.fsf@notabene.neil.brown.name>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
        micalg=pgp-sha256; protocol="application/pgp-signature"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

--=-=-=
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

On Sat, Feb 10 2018, James Simmons wrote:

>> > On Feb 8, 2018, at 10:10 PM, NeilBrown <neilb@suse.com> wrote:
>> >=20
>> > On Thu, Feb 08 2018, Oleg Drokin wrote:
>> >=20
>> >>> On Feb 8, 2018, at 8:39 PM, NeilBrown <neilb@suse.com> wrote:
>> >>>=20
>> >>> On Tue, Aug 16 2016, James Simmons wrote:
>> >>=20
>> >> my that=E2=80=99s an old patch
>> >>=20
>> >>>=20
>> > ...
>> >>>=20
>> >>> Whoever converted it to "!strcmp()" inverted the condition.  This is=
 a
>> >>> perfect example of why I absolutely *loathe* the "!strcmp()" constru=
ct!!
>> >>>=20
>> >>> This causes many tests in the 'sanity' test suite to return
>> >>> -ENOMEM (that had me puzzled for a while!!).
>> >>=20
>> >> huh? I am not seeing anything of the sort and I was running sanity
>> >> all the time until a recent pause (but going to resume).
>> >=20
>> > That does surprised me - I reproduce it every time.
>> > I have two VMs running a SLE12-SP2 kernel with patches from
>> > lustre-release applied.  These are servers. They have 2 3G virtual dis=
ks
>> > each.
>> > I have two over VMs running current mainline.  These are clients.
>> >=20
>> > I guess your 'recent pause' included between v4.15-rc1 (8e55b6fd0660)
>> > and v4.15-rc6 (a93639090a27) - a full month when lustre wouldn't work =
at
>> > all :-(
>>=20
>> More than that, but I am pretty sure James Simmons is running tests all =
the time too
>> (he has a different config, I only have tcp).
>
> Yes I have been testing and haven't encountered this problem. Let me try=
=20
> the fix you pointed out.=20

Yeah, I guess I over reacted a bit in suggesting that no-one can have
been testing - sorry about that.  It seemed really strange though as the
bug was so easy for me to hit.

Maybe - as you suggest in another email - it is due to some
client/server incompatibility.  I guess it is unavoidable with an fs
like lustre to have incompatible protocol changes.  Is there any
mechanism for detecting the version of other peers in the cluster and
refusing to run if versions are incompatible?

If you haven't hit the problem in testing, I suspect you aren't touching
that code path at all.  Maybe put a BUG() call in there to see :-)

>=20=20
>> > Do you have a list of requested cleanups?  I would find that to be
>> > useful.
>>=20
>> As Greg would tell you, =E2=80=9Cif you don=E2=80=99t know what needs to=
 be done,
>> let=E2=80=99s just remove the whole thing from staging now=E2=80=9D.
>>=20
>> I assume you saw drivers/staging/lustre/TODO already, it=E2=80=99s only =
partially done.
>
> Actually the complete list is at :
>
> https://jira.hpdd.intel.com/browse/LU-9679
>
> I need to move that to our TODO list. Sorry I have been short on cycles.

Just adding that link to TODO would be a great start.  I might do that
when I next send some patches.

Thanks,
NeilBrown


--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEG8Yp69OQ2HB7X0l6Oeye3VZigbkFAlqA1qwACgkQOeye3VZi
gbmo5BAApGghV6KLAR/6FiZKwEpZANBWJHmEsIZBDbsxSt0SUAlioDBFZ4XGV8zn
VP7uNSdZbtLsEc8TEkJtVN+rKmZ0cCTDqihCvXb5vRI6A1iAoh8tAmcREyXwUCjg
N0EQ9G0migDNruWk+y8IR2GoTBTdBFb0Qng4d48GK9Ki3nxippb02zYn/fXn228X
2etAk36KVw5UW4pkGyM5KF3YFtsGEOtO4T4Mfwwy18ALTiMJXjBUd5zhbp8D6zyW
JP3MzgqDdGb7jsM/5BxvbTvekSjYf4X6KYLRg3NnxK3rlU1Uf6E2CHQPt/nx7bt1
hVQcf00OezuhnOf7wfTenGjA/FwfDwOEbG4cb01MNTOECa1J3bl8lvcZPeicurHF
ASYc/C1KfwEcq9VgJL4b8VHQCVtGa4WkNPM+OZ2rC1Qdmc1HWupA+wCEJ9K2vyWo
WBpXJioI9CsYOaH/3U1EY3rOeQsGmfVv/y6cRZZL8/MVPXlQ0Sry1tmoSj3e2lrm
3ZX8gd0biRYJ7mMJJC6yIQ74nyWHKWmNVupy6U0ohFqtIL+tpy6GY8reQ9qr5tyK
Jh1JhM7hRdtX3wmkredengnX0sFurwCt4zVoV6Op4Sd6J3Z1jtK5fmyGDRCuVUjb
f3PQ/2TI92m/jkKmCyeGM7RMK9jrNc6UKubLRuYhEC0iBx9BqoE=
=ZYEZ
-----END PGP SIGNATURE-----
--=-=-=--