Received: by 10.223.185.116 with SMTP id b49csp1893760wrg; Mon, 12 Feb 2018 00:10:01 -0800 (PST) X-Google-Smtp-Source: AH8x227ZOY1/z1ckVWVOwsYaiL+qJ843W3r7ULE4Ij/xr9K1bBfp6NMcRwv7zyf/683fjY6t/mYf X-Received: by 2002:a17:902:4283:: with SMTP id h3-v6mr10207046pld.175.1518423001431; Mon, 12 Feb 2018 00:10:01 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1518423001; cv=none; d=google.com; s=arc-20160816; b=KP2BFJrffg+s1mNSftmB4fvixeJgjnAhaFumK6r1AzxOlbSR/LcFuiYuanthz3pFIE U9w0djwEKq7eOGz7PCK6GmgI/SjcOz6CvAQfhhtpGc+3+JSHp6VlYa/C2rmz/jF9cBF4 ACZBGsa7hYZQWhx2S3n6g2id6qA83jCbOE0Bq8s736gr9BdwRZc/zhHPZkVpQtAAbZwp 7Wt076cDvlLvXNUPoLq9muBIqlwwMtJ6mzzpLgkgSoI4aaYLWW3qWXUenDH4eTBuGDaz rsz8gBoHB7AxVe0jXMs5vbXgf7hwP34bHYm+XLv95pNT2MfankmBHxRK4pLDZUq0yE3W wPgA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature:arc-authentication-results; bh=4NBVVkQAvSvLHuhcnWKiUHga35mB/oaxV8C8Ac8+9nI=; b=Edl42Wb7rKEIWAkysts7yswLicYNjF8ffBWhkxppeKDJgPkF4tIh/rIBLEcDzZIDo/ 0KxPmSOUgq02sbt8tg8aM+MjcW9on5uzO/F4/AoOV//UMEmMzhxZD3Q+PZrJM5LtBfZi 3IfFu7XZyQ7PdRseLtTEnkigFY6hI4/sgMZ/162jSAJTPFN5wl3PouT5DI4swugYEgwn zfETHwlTGXKQC9XQpU14GHexpbgpEUssC9gPqUknh35WaDC1MVQ2Iu3O4x0YHMXyjccl mvuRR1sS1TFB5tVLj9PZTHIL4HtRmXpfmJUnl33eJZ39jO2uIxwBodXUVtihEzrFy/JN Nr8Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2017-10-26 header.b=l6m4/gT2; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r2-v6si3891151pli.324.2018.02.12.00.09.46; Mon, 12 Feb 2018 00:10:01 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2017-10-26 header.b=l6m4/gT2; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753886AbeBLHGj (ORCPT + 99 others); Mon, 12 Feb 2018 02:06:39 -0500 Received: from aserp2130.oracle.com ([141.146.126.79]:60236 "EHLO aserp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751328AbeBLHGi (ORCPT ); Mon, 12 Feb 2018 02:06:38 -0500 Received: from pps.filterd (aserp2130.oracle.com [127.0.0.1]) by aserp2130.oracle.com (8.16.0.22/8.16.0.22) with SMTP id w1C76MPo054166; Mon, 12 Feb 2018 07:06:30 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=corp-2017-10-26; bh=4NBVVkQAvSvLHuhcnWKiUHga35mB/oaxV8C8Ac8+9nI=; b=l6m4/gT2t7Fc76wBXpsYXVI/T3KPJrf2wDKmFB0kPs5Y+bMkCmcULNPlJLFeLXKaPs7/ WIHelyLNx45ykLjVJI+HWb1lRM301tecXh8yWBvRbsnBn9ggC/uR3Mp1L8gmQcEN6tyM +HP6B4O+e/tmJCkH0rjhg4+s66a1jc/CYMO+6dNUmHnFb/xQOtWD9s57ECn5vgKKhqcQ tX083Y2oYyLg0dHyDnrsrFrcu/Js6cw7M4se6Y1YJRfCHIFufKO5fNwyOJe79dhhs3R1 C/Bj2L5P2yw3/4a5Q7/VBhCw/tedBKEBB5Fo5POZw/jB0TKbF9Mkb856r2PX6cbSKzfT JA== Received: from aserv0022.oracle.com (aserv0022.oracle.com [141.146.126.234]) by aserp2130.oracle.com with ESMTP id 2g367tg04s-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 12 Feb 2018 07:06:30 +0000 Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by aserv0022.oracle.com (8.14.4/8.14.4) with ESMTP id w1C6uTUY013811 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 12 Feb 2018 06:56:29 GMT Received: from abhmp0003.oracle.com (abhmp0003.oracle.com [141.146.116.9]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id w1C6uSnh025534; Mon, 12 Feb 2018 06:56:28 GMT Received: from mwanda (/197.254.35.146) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Sun, 11 Feb 2018 22:56:27 -0800 Date: Mon, 12 Feb 2018 09:56:20 +0300 From: Dan Carpenter To: Liam Mark Cc: Laura Abbott , Sumit Semwal , devel@driverdev.osuosl.org, linaro-mm-sig@lists.linaro.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: android: ion: Initialize dma_address of new sg list Message-ID: <20180212065620.iqlzczhqzlrmel5n@mwanda> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170609 (1.8.3) X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=8802 signatures=668668 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=828 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1711220000 definitions=main-1802120091 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Feb 09, 2018 at 10:16:56PM -0800, Liam Mark wrote: > Fix the dup_sg_table function to initialize the dma_address of the new > sg list entries instead of the source dma_address entries. > > Fixes: 17fd283f3870 ("staging: android: ion: Duplicate sg_table") > Signed-off-by: Liam Mark How did you find this bug? What are the user visible effects of this bug? I'm probably going to ask you to send a v2 patch with a new changelog depending on the answers to these questions. regards, dan carpenter