Received: by 10.223.185.116 with SMTP id b49csp1908587wrg; Mon, 12 Feb 2018 00:30:44 -0800 (PST) X-Google-Smtp-Source: AH8x226bQFYKG0BZ4OOmlFzwciIMkVpP06LDBUlvKNaQtYSHsl/zeVKhMwoHNmCDNRtIDa/hWv/x X-Received: by 2002:a17:902:b608:: with SMTP id b8-v6mr10113377pls.404.1518424244692; Mon, 12 Feb 2018 00:30:44 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1518424244; cv=none; d=google.com; s=arc-20160816; b=gk71tzRscP5k6UXIi1WlRlZmBKThsbtRlU/IWAp4NU2OyTpcp54HmToQx6nt53OjCf cpyf3oMqGAzduTxvHIOI4DeM+fsrtoCczJh6FwTFx6Yd72hFZRSyOPaHvYx/4B5MZ9NF 0mG+rPbFytBvuL7QlDIrUzSS1fecNwi6YomKwBaeWKX4eNBgIw+GWZhk2q35HrGSARFH wIQP+ab4jeTiwV2FiYUocVjXqVZX4kLVYTik6+9Chz6KRhUFkyRBJ6a9BG+Bzoqf0t11 wvRumwQRyoPhun2UUN0alpu9nMMOG0JXMG4y+oS38aGTmsDKmac1w7B+fJHLoYkBN4eQ pynA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:to:subject:dkim-signature :arc-authentication-results; bh=As7wS5SyihvyOJoe9GtSlbj+5TAGOhaajAmGpQXVRAA=; b=KqyGUlKc3qLQ7KofF5nm/tglymBnweQRtF7HMkbCCptd11NmLfxigm/3SmQe+bx6Rh Dlzh24KZt5Mgwd38HQCgnUns2h0IRnAvLPV42QaWJVGyj4/vu3d17fpeqibZHdbDsGk/ HRW2W+8JHNFx38Ow0t8qEJXxr1tSNt1cJaTibCz5z5W+N175moGS8pvoDFG1SAGrVFXJ jWLAMEr0jdML3E0GAsyztJRmQ30GNLQnWLbTBxdsGk4u2vS6yz2CWqDo4O0DYjtO2O2B EkzZrtGj0gfk1Nm1A5POKf3UH8EfLqBizS4s+/aNz5xEm9ET4Fee20b6SR3DNoDbQlgq U7AQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=u0ZHaBXK; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v68si4128756pfb.292.2018.02.12.00.30.30; Mon, 12 Feb 2018 00:30:44 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=u0ZHaBXK; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932921AbeBLI1s (ORCPT + 99 others); Mon, 12 Feb 2018 03:27:48 -0500 Received: from mail-wr0-f194.google.com ([209.85.128.194]:36531 "EHLO mail-wr0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932561AbeBLI1q (ORCPT ); Mon, 12 Feb 2018 03:27:46 -0500 Received: by mail-wr0-f194.google.com with SMTP id y3so14252966wrh.3; Mon, 12 Feb 2018 00:27:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=As7wS5SyihvyOJoe9GtSlbj+5TAGOhaajAmGpQXVRAA=; b=u0ZHaBXKenWEjyPsOksqmdQOz20c23ytvkEctj0/ErrEJwFp9mNLnX9rglqWdTxEH1 7w1OYm367tN1HhJg95PLRntld+Gt1ZQviY4ORufhjRU3PZ6lELaT5l8YGN5064zdxNjL BDR9cswd6LJnrurSyLirMYChC2Db3BCJrXE0QJbiGwYGlchOg5ci9IJj6RkwqeFxRRCo tz/uqGZZJBayi20IWyrG62wkk3r2yFCHcwzHLleFcoJyCbj1BHk7LfkC83dkQEsWalQE 2dvBS7DYE7lgCdUuxFnOBJWxCpjfqr/Rcdergq6eVQOddAB0tqG329i5oUEroBBD3bIW yIZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=As7wS5SyihvyOJoe9GtSlbj+5TAGOhaajAmGpQXVRAA=; b=lvg0cTyqXBNpM4pCj8u/6oKRxhnxdj6su/MBscjNh+2oGJnoLF++l4kGaSsjLLFnPn wrjV6rBRLVKdAG+vmtEQEY/Pg3B2fFH+vt5pQ4kmrIrGP+M2/iq1ZLTsTOIzYGwHgS/S iiXGS0KNG/oSICF4j1T4yVw9Lcvk5spK756RwM9/EKKRLsG3SXsVeL21uxENoH4AweMM 0KQrrIX4opCrc8U+GAOlxvv6O5Sc5MvFvvQLRRIUh+4ZvWMqCiF9ATA/Shx3EnUDVz+r DNIFfyo38VYqZp38c2imPpBqBeoCnkLQFzqsJz3fJx1dN7rF059RBYLWv8npKtrdmOIP QA3w== X-Gm-Message-State: APf1xPDgmn8r/PqDRcoY2F3AQbNCe/sH7JojxV8pO0lIOIgs5bDTm5s+ K1gxyvgbdR4rMCaTh+LIKnk= X-Received: by 10.223.159.9 with SMTP id l9mr9617244wrf.30.1518424065313; Mon, 12 Feb 2018 00:27:45 -0800 (PST) Received: from [192.168.10.165] ([82.84.102.245]) by smtp.googlemail.com with ESMTPSA id v72sm5186012wmd.12.2018.02.12.00.27.43 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 12 Feb 2018 00:27:44 -0800 (PST) Subject: Re: [PATCH v2 0/6] Spectre v2 updates To: David Woodhouse , tglx@linutronix.de, karahmed@amazon.de, sironi@amazon.de, x86@kernel.org, kvm@vger.kernel.org, torvalds@linux-foundation.org, linux-kernel@vger.kernel.org, bp@alien8.de, peterz@infradead.org, jmattson@google.com, rkrcmar@redhat.com, arjan.van.de.ven@intel.com, dave.hansen@intel.com References: <1518305967-31356-1-git-send-email-dwmw@amazon.co.uk> From: Paolo Bonzini Message-ID: Date: Mon, 12 Feb 2018 09:27:42 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: <1518305967-31356-1-git-send-email-dwmw@amazon.co.uk> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/02/2018 00:39, David Woodhouse wrote: > Using retpoline ensures the kernel is safe because it doesn't contain > any indirect branches, but firmware still can — and we make calls into > firmware at runtime. Where the IBRS microcode support is available, use > that before calling into firmware. > > While doing that, I noticed that we were calling C functions without > telling the compiler about the call-clobbered registers. Stop that. > > This also contains the always_inline fix for the performance problem > introduced by retpoline in KVM code, and fixes some other issues with > the per-vCPU KVM handling for the SPEC_CTRL MSR. > > Finally, update the microcode blacklist to reflect the latest > information from Intel. > > v2: Drop IBRS_ALL patch for the time being > Add KVM MSR fixes (karahmed) > Update microcode blacklist > > > > David Woodhouse (4): > x86/speculation: Update Speculation Control microcode blacklist > Revert "x86/speculation: Simplify > indirect_branch_prediction_barrier()" > KVM: x86: Reduce retpoline performance impact in > slot_handle_level_range() > x86/speculation: Use IBRS if available before calling into firmware > > KarimAllah Ahmed (2): > X86/nVMX: Properly set spec_ctrl and pred_cmd before merging MSRs > KVM/nVMX: Set the CPU_BASED_USE_MSR_BITMAPS if we have a valid L02 MSR > bitmap > > arch/x86/include/asm/apm.h | 6 ++++++ > arch/x86/include/asm/cpufeatures.h | 1 + > arch/x86/include/asm/efi.h | 17 +++++++++++++++-- > arch/x86/include/asm/nospec-branch.h | 32 ++++++++++++++++++++++++++++---- > arch/x86/include/asm/processor.h | 3 --- > arch/x86/kernel/cpu/bugs.c | 18 +++++++++++------- > arch/x86/kernel/cpu/intel.c | 4 ---- > arch/x86/kvm/mmu.c | 10 +++++----- > arch/x86/kvm/vmx.c | 7 ++++--- > drivers/watchdog/hpwdt.c | 3 +++ > 10 files changed, 73 insertions(+), 28 deletions(-) > Acked-by: Paolo Bonzini