Received: by 10.223.185.116 with SMTP id b49csp1989240wrg; Mon, 12 Feb 2018 02:18:45 -0800 (PST) X-Google-Smtp-Source: AH8x2262ROpvFPOV1gusi1fszGOuiTULTHHftBWHJrDQSVGYoEMe0XxHHqOR4FKDpjYBEErLe4lS X-Received: by 10.101.72.11 with SMTP id h11mr8959619pgs.386.1518430725686; Mon, 12 Feb 2018 02:18:45 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1518430725; cv=none; d=google.com; s=arc-20160816; b=fc9JAH0L9T379HnfbavewqV5AjlyBRYcEfq3U0TlKHMmi7xeDw8IjLBfEnYKFqIzxy iBa42GBfLWVY5xxuE64R20Pvg/oBzxe40tBk9oo1B67S7cU0tQruTORWeo7gxUe6XZ8z dyQ0MCZntdzhq1Er+w0gxEY03vNrSSrusjJwIjS0KJ+MlJZ+2nAZEqNsDVXETJdM2YKa ZXZKKuYulvj32tlvrCUb/iBS6qv2kBozpH6jHK2Dki3wnoG1Wd9bL554CmuPfSUTTHol 9iXXY7Q6IVkXivtaWR5mwgRdtiQeOchXAgaQNdiFHtIrtCD2P+8o/EaqobOV1h5Yc5OX AAjA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date:from :references:to:subject:arc-authentication-results; bh=TdV1ZzCWL6T9htD2L+8QGJ9rSMpVUu0F4P+AKaKhlBc=; b=Ps7C1x5O9Ezrq7Dp8LilUnD8e4IgofAEnITf5j+LK/JIjWg2cmh1qZNghSdvd8LSQQ fqbatknDldSD4LjRA5e9C8RbSDer2TR4l9kBNoX7Xq2E92E4kZlEiKqkDE9evm2Oph5z 5DE8f1eu9kxngjqK35qZfQfhvFCMKsghCtauPJYURtwFc2P7ttAcNUvQHL+OEoF4f3SG BNv0urUj/o7TQtFduYrMf00YxjHLIa7Eshj9pgLx3dyW6svd34Jt2z5woW6axB2edJgN xaG+x6kssVDFIa6zosJROc+iFKe5cJUDyoAihxJd2H/I2wG/YyVuUAWBfWh0rGcEZDmX n68w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g1-v6si3829507plm.153.2018.02.12.02.18.31; Mon, 12 Feb 2018 02:18:45 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933428AbeBLJxM (ORCPT + 99 others); Mon, 12 Feb 2018 04:53:12 -0500 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:55202 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932505AbeBLJxL (ORCPT ); Mon, 12 Feb 2018 04:53:11 -0500 Received: from pps.filterd (m0098393.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w1C9n88n011846 for ; Mon, 12 Feb 2018 04:53:10 -0500 Received: from e06smtp12.uk.ibm.com (e06smtp12.uk.ibm.com [195.75.94.108]) by mx0a-001b2d01.pphosted.com with ESMTP id 2g35j3f1t5-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Mon, 12 Feb 2018 04:53:10 -0500 Received: from localhost by e06smtp12.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 12 Feb 2018 09:53:08 -0000 Received: from b06cxnps3075.portsmouth.uk.ibm.com (9.149.109.195) by e06smtp12.uk.ibm.com (192.168.101.142) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Mon, 12 Feb 2018 09:53:04 -0000 Received: from d06av23.portsmouth.uk.ibm.com (d06av23.portsmouth.uk.ibm.com [9.149.105.59]) by b06cxnps3075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id w1C9r37v66060442; Mon, 12 Feb 2018 09:53:03 GMT Received: from d06av23.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id A5234A4053; Mon, 12 Feb 2018 09:46:24 +0000 (GMT) Received: from d06av23.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id F2FD9A404D; Mon, 12 Feb 2018 09:46:23 +0000 (GMT) Received: from [9.164.182.82] (unknown [9.164.182.82]) by d06av23.portsmouth.uk.ibm.com (Postfix) with ESMTP; Mon, 12 Feb 2018 09:46:23 +0000 (GMT) Subject: Re: linux-4.16-rc1/drivers/misc/ocxl/file.c:320:broken error checking ? To: David Binderman , "andrew.donnellan@au1.ibm.com" , "arnd@arndb.de" , "gregkh@linuxfoundation.org" , "linuxppc-dev@lists.ozlabs.org" , "linux-kernel@vger.kernel.org" References: From: Frederic Barrat Date: Mon, 12 Feb 2018 10:53:02 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 x-cbid: 18021209-0008-0000-0000-000004CBD4A5 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 18021209-0009-0000-0000-00001E5F90FF Message-Id: <6e051309-c236-7715-cffb-b53d2da600b3@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2018-02-12_05:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1709140000 definitions=main-1802120128 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Le 12/02/2018 ? 09:58, David Binderman a ?crit?: > Hello there, > > > linux-4.16-rc1/drivers/misc/ocxl/file.c:320]: (style) Checking if > unsigned variable 'used' is less than zero. > > Source code is > > > ?????? used = append_xsl_error(ctx, &header, buf + sizeof(header)); > ??????? if (used < 0) > ??????????? return used; > > Suggest put return value from function into signed variable, sanity > check it, > > then assign it to an unsigned variable. > > > Also, use of the gcc compiler flag -Wtype-limits will show up this kind > of problem in future. Thanks for reporting it. A patch to address it is working its way up and should land in the next rc release. Fred > > Regards > > > David Binderman > >