Received: by 10.223.185.116 with SMTP id b49csp2004937wrg; Mon, 12 Feb 2018 02:38:50 -0800 (PST) X-Google-Smtp-Source: AH8x2265h6wK0TU4rwj+nhEdwiQ75BYmVg5p2ow4GzM/eV9nAkltoXvUQF/TCDMxxLB6mhsauFSa X-Received: by 10.98.249.4 with SMTP id o4mr10819054pfh.14.1518431930884; Mon, 12 Feb 2018 02:38:50 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1518431930; cv=none; d=google.com; s=arc-20160816; b=MuQxRbF8nNKG+qL/Dr82TCqvMwhinFaEt63lzoeGhQ4b1Arjndyshs3Y8b79cbiziT SSMrPcpSwfrbW9nezV9zyopPVzfEhqKNjpyWpz24X0Mx/7KKYEvB3Ym1rVjaMvVM99yH g5UC0wI/6r/NzP1HfeCXtrUD2fihW5vcZHXKRsIj5Y9QXlYBwTAEv2piOOXnY+IvOL4T KXSvyUbPFPuNc5pm2Sg4vRXB0eP+DJiFG9WggbHOvIMmZlrgRJ3Y+mcbFwZrwrZNigmm ep56LSljsvk8tGuvsaVRykpx6WRRvMHLuet/ABVqjlrbbZiwedpwbbAzziX6khfKU1J+ 45sQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :arc-authentication-results; bh=pI0iTHC1We8DzwczmZY0qMETGoGudnnzlbgSc5Ef7sU=; b=uNn9X+AaE3yuVReykf93n096t7q5NqZ8mZLVR/xKZ4EAqy/TSVYReY8nsYUKwHiiip 6Xdm9eCYMCCk0VQ0NBFxzayA7SXR34tvPkrqaOe806uCThJT73m1h1CR+FNVn9RbYxgY gsRDJVZMlQSB2z/pWLVUIA1DHUjNtFcP4CvxZ0a79vjcgE3NFom452r0g0So4/8BkaOP wkyMp1r7aXmkqRr5+XBTpWlL7P7JCJyheVdmzEO3I+6bNGbInNO7rfP0mEMyQV5dPA+5 IN4ke2A61l4ywOl/QPU+OJ2N6+lr5BenzJI/f1Fmqzt0Jmm56LBnZbXfnLU/OFdnl4av PSJg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c1si2075534pgt.390.2018.02.12.02.38.36; Mon, 12 Feb 2018 02:38:50 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933902AbeBLKVb (ORCPT + 99 others); Mon, 12 Feb 2018 05:21:31 -0500 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:34248 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932868AbeBLKV2 (ORCPT ); Mon, 12 Feb 2018 05:21:28 -0500 Received: from pps.filterd (m0098417.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w1CAJSM6093047 for ; Mon, 12 Feb 2018 05:21:27 -0500 Received: from e06smtp10.uk.ibm.com (e06smtp10.uk.ibm.com [195.75.94.106]) by mx0a-001b2d01.pphosted.com with ESMTP id 2g38yx8a7r-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Mon, 12 Feb 2018 05:21:27 -0500 Received: from localhost by e06smtp10.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 12 Feb 2018 10:21:25 -0000 Received: from b06cxnps4075.portsmouth.uk.ibm.com (9.149.109.197) by e06smtp10.uk.ibm.com (192.168.101.140) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Mon, 12 Feb 2018 10:21:23 -0000 Received: from d06av26.portsmouth.uk.ibm.com (d06av26.portsmouth.uk.ibm.com [9.149.105.62]) by b06cxnps4075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id w1CALM1K37748866; Mon, 12 Feb 2018 10:21:22 GMT Received: from d06av26.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 95E3CAE045; Mon, 12 Feb 2018 10:12:28 +0000 (GMT) Received: from d06av26.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id CEDEAAE055; Mon, 12 Feb 2018 10:12:26 +0000 (GMT) Received: from oc4502181600.ibm.com (unknown [9.84.225.146]) by d06av26.portsmouth.uk.ibm.com (Postfix) with ESMTP; Mon, 12 Feb 2018 10:12:26 +0000 (GMT) From: Shilpasri G Bhat To: rjw@rjwysocki.net Cc: linux-pm@vger.kernel.org, viresh.kumar@linaro.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, mpe@ellerman.id.au, Shilpasri G Bhat Subject: [PATCH] cpufreq: powernv: Check negative value returned by cpufreq_table_find_index_dl() Date: Mon, 12 Feb 2018 15:51:16 +0530 X-Mailer: git-send-email 1.8.3.1 X-TM-AS-GCONF: 00 x-cbid: 18021210-0040-0000-0000-0000040ECC8C X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 18021210-0041-0000-0000-000026128AB1 Message-Id: <1518430876-24464-1-git-send-email-shilpa.bhat@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2018-02-12_05:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=1 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1709140000 definitions=main-1802120134 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This patch fixes the below Coverity warning: *** CID 182816: Memory - illegal accesses (NEGATIVE_RETURNS) /drivers/cpufreq/powernv-cpufreq.c: 1008 in powernv_fast_switch() 1002 unsigned int target_freq) 1003 { 1004 int index; 1005 struct powernv_smp_call_data freq_data; 1006 1007 index = cpufreq_table_find_index_dl(policy, target_freq); >>> CID 182816: Memory - illegal accesses (NEGATIVE_RETURNS) >>> Using variable "index" as an index to array "powernv_freqs". 1008 freq_data.pstate_id = powernv_freqs[index].driver_data; 1009 freq_data.gpstate_id = powernv_freqs[index].driver_data; 1010 set_pstate(&freq_data); 1011 1012 return powernv_freqs[index].frequency; 1013 } Signed-off-by: Shilpasri G Bhat --- drivers/cpufreq/powernv-cpufreq.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/cpufreq/powernv-cpufreq.c b/drivers/cpufreq/powernv-cpufreq.c index 29cdec1..69edfe9 100644 --- a/drivers/cpufreq/powernv-cpufreq.c +++ b/drivers/cpufreq/powernv-cpufreq.c @@ -1005,6 +1005,9 @@ static unsigned int powernv_fast_switch(struct cpufreq_policy *policy, struct powernv_smp_call_data freq_data; index = cpufreq_table_find_index_dl(policy, target_freq); + if (unlikely(index < 0)) + index = get_nominal_index(); + freq_data.pstate_id = powernv_freqs[index].driver_data; freq_data.gpstate_id = powernv_freqs[index].driver_data; set_pstate(&freq_data); -- 1.8.3.1