Received: by 10.223.185.116 with SMTP id b49csp2056846wrg; Mon, 12 Feb 2018 03:38:12 -0800 (PST) X-Google-Smtp-Source: AH8x227riqtHF1dmfU2Rii7SWcocka6k+uQch6mCwehqlbl7YLCsk2ipFamntX0A4PsiUTEofszW X-Received: by 10.98.66.86 with SMTP id p83mr11395726pfa.229.1518435492734; Mon, 12 Feb 2018 03:38:12 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1518435492; cv=none; d=google.com; s=arc-20160816; b=nKmDQKI+eoVi1PuavGX2W31Avq30faxtNihCEqA1sSKbi9CbYdpVEfaRm2e6syAqDp YiNeLa7ROJNNX9hX0dtp5YY5XD+6mCMwGrQRYsCWBuAFa28jak+f/GDfIdmv6P5VpEbx pkXZ4zlo15BCq3y1kNiihbxNLm8cnhAzoYWkJCjosFbo0RxrpB+lmmUYPLZLJLUqcqXg GLTwHv9qHgM+rGGfWNPOk2R/CC2poZKHjYocbBpak6WUVWvyw6BwgYq0NYIJKFj50EPI QcFAx3veILeyjDp5dmAcyWZYbcM6lha68FC2VyVex/UxftQTm4rwSZ/bdMrJ+DyRJmBw Pd0Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:user-agent:in-reply-to :content-disposition:mime-version:references:subject:cc:to:from:date :arc-authentication-results; bh=j7bEYliD6rmBQLBKtPc9YusOpczVh97BEvYmj7DUzmU=; b=DKFw3ZCSN4ualZj7bXimejylE/6UkYiDhmZXq9eZumiVYoX+lGPpUKSapy/eMl0hmq LI3vBuaIqB0foh+EeSbsSnwKc0F8Qb5pqluEFEYVDpq+1olKCiLbi32xXpNN397SwDD2 9omRlWCT9OZRgF+il43Nl3f/I5JbCTTgWZO9DZgjhkk3vwJGa69c6c4axVki179YK2+k d/PBeOtZfiHK18VhFy/aNGdUwcSyuJ7WReJGMGAfedlTJeTIli/v8BI5I6wN4yW0tyLY thY6/fMfhN+zm3veVUKPt9VMulHACl9+FVpn1dksl+EyuJ54qvr1ZoTft0CgayUF4dTD jqSw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z2si1449244pfd.316.2018.02.12.03.37.58; Mon, 12 Feb 2018 03:38:12 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934059AbeBLLgp (ORCPT + 99 others); Mon, 12 Feb 2018 06:36:45 -0500 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:40930 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S933981AbeBLLgn (ORCPT ); Mon, 12 Feb 2018 06:36:43 -0500 Received: from pps.filterd (m0098420.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w1CBZLsK096877 for ; Mon, 12 Feb 2018 06:36:43 -0500 Received: from e06smtp14.uk.ibm.com (e06smtp14.uk.ibm.com [195.75.94.110]) by mx0b-001b2d01.pphosted.com with ESMTP id 2g392kjn3y-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Mon, 12 Feb 2018 06:36:42 -0500 Received: from localhost by e06smtp14.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 12 Feb 2018 11:36:40 -0000 Received: from b06cxnps4076.portsmouth.uk.ibm.com (9.149.109.198) by e06smtp14.uk.ibm.com (192.168.101.144) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Mon, 12 Feb 2018 11:36:37 -0000 Received: from d06av21.portsmouth.uk.ibm.com (d06av21.portsmouth.uk.ibm.com [9.149.105.232]) by b06cxnps4076.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id w1CBaaMk47906954; Mon, 12 Feb 2018 11:36:36 GMT Received: from d06av21.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id C3CC452045; Mon, 12 Feb 2018 10:28:39 +0000 (GMT) Received: from rapoport-lnx (unknown [9.148.8.138]) by d06av21.portsmouth.uk.ibm.com (Postfix) with ESMTPS id A66AA5203F; Mon, 12 Feb 2018 10:28:38 +0000 (GMT) Date: Mon, 12 Feb 2018 13:36:33 +0200 From: Mike Rapoport To: Igor Stoppa Cc: willy@infradead.org, rdunlap@infradead.org, corbet@lwn.net, keescook@chromium.org, mhocko@kernel.org, labbott@redhat.com, jglisse@redhat.com, hch@infradead.org, cl@linux.com, linux-security-module@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-hardening@lists.openwall.com Subject: Re: [PATCH 1/6] genalloc: track beginning of allocations References: <20180211031920.3424-1-igor.stoppa@huawei.com> <20180211031920.3424-2-igor.stoppa@huawei.com> <20180211122444.GB13931@rapoport-lnx> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) X-TM-AS-GCONF: 00 x-cbid: 18021211-0016-0000-0000-00000521DC6C X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 18021211-0017-0000-0000-0000285E9F12 Message-Id: <20180212113633.GC20737@rapoport-lnx> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2018-02-12_05:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1709140000 definitions=main-1802120151 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Feb 12, 2018 at 01:17:01PM +0200, Igor Stoppa wrote: > > > On 11/02/18 14:24, Mike Rapoport wrote: > > On Sun, Feb 11, 2018 at 05:19:15AM +0200, Igor Stoppa wrote: > [...] > > >> +/** > >> + * mem_to_units - convert references to memory into orders of allocation > > > > Documentation/doc-guide/kernel-doc.rst recommends to to include brackets > > for function comments. I haven't noticed any difference in the resulting > > html, so I'm not sure if the brackets are actually required. > > This is what I see in the example from mailine docs: > > /** > * foobar() - Brief description of foobar. > * @argument1: Description of parameter argument1 of foobar. > * @argument2: Description of parameter argument2 of foobar. > * > * Longer description of foobar. > * > * Return: Description of return value of foobar. > */ > int foobar(int argument1, char *argument2) > > > What are you referring to? I'm referring to "foobar() - brief description" vs "foobar - brief description". The generated html looks exactly the same in the browser, so I don't know if the brackets are really required. > [...] > > >> + * @size: amount in bytes > >> + * @order: power of 2 represented by each entry in the bitmap > >> + * > >> + * Returns the number of units representing the size. > > > > Please s/Return/Return:/ > > :-( I thought I had fixed them all. thanks for spotting this. > > [...] > > >> + * Return: If two users alter the same bit, to one it will return > >> + * remaining entries, to the other it will return 0. > > > > And what if there are three or four concurrent users? ;-) > > > > I believe that a more elaborate description about what happens with > > concurrent attempts to alter the bitmap would be really helpful. > > ok > > -- > thanks, igor > -- Sincerely yours, Mike.