Received: by 10.223.185.116 with SMTP id b49csp2148184wrg; Mon, 12 Feb 2018 05:15:02 -0800 (PST) X-Google-Smtp-Source: AH8x224kiHTQQ7pBZF3Y1wryXnY4Veh/Ikgs9Dty6ChJND3MnYcYee9qvoY4plvOi8BCDNQkGXsF X-Received: by 2002:a17:902:a9cb:: with SMTP id b11-v6mr10755736plr.315.1518441302337; Mon, 12 Feb 2018 05:15:02 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1518441302; cv=none; d=google.com; s=arc-20160816; b=j+j0OlneVaACGCDOrQWxDPUqb8VE2kmzwI/ezMazQbcBmSLe8311LDSlC3nsm7bLz/ VjemD+BgINRoTt4o8YTzcbiyL4lsv2YsQtdNAbkqCSXCXjHrZcFmqaR11IoZM7SMBhir JiWw9gTtx24yKm2yH4SZYKyGnHVEM71xIH2CdhRZYDxE7DpBzvbdfPIDdDwg2qt6w8Fp /7v6Qb3IX/u4gFjDl63AMtE13Dh6ZDkpOe+RAWkAAVi2jnM3gLr5eUpDkwyRaIpyEYZ0 BAHTBJX0MiteN7kV0VYS2+y0oEsIasKyJlpdHsqWRFIE9kUaNwcMCxN+ReDLD6HGVY5n 5Ydg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature:arc-authentication-results; bh=QZd+BVippxR8I1Rgy7FiktFdIDg+Mo2sHX3mVqqQF0M=; b=COR4lsbwYp+pRK1YMBW+7SCpnoWQWQSHPbI2JGUDLTm6N14GwpAs4NyiPWElgyLmz/ giM2HNFUUaF4dcxKk6x97hen5Ue4xiht2pR2Xu88g2vdaZHSbVVSIT9Bn/1hqS7TXS3F yWNzTjfSR5HBmuplStLosF88OM3T5eavVqDAZUlKQ/uWgSSggRSgx/0ZhOs/Rh70XB/o Y/SNR9KyUe9m9ADZ5c1BP4Imnvi9Pevyf4o2AyxTx+3/BrzOuoD7q1mLBbleR0rtXvZf qLaleuw/QSoYrJUxLydXAs66cvKd8qU5cGU0WjNSobRqhdrcPU4ulzrPwwWj9g2ZyS11 2E8w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Cp/eiFNL; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m3-v6si5810149plb.330.2018.02.12.05.14.48; Mon, 12 Feb 2018 05:15:02 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Cp/eiFNL; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933681AbeBLKke (ORCPT + 99 others); Mon, 12 Feb 2018 05:40:34 -0500 Received: from mail-pg0-f45.google.com ([74.125.83.45]:46380 "EHLO mail-pg0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932629AbeBLKkd (ORCPT ); Mon, 12 Feb 2018 05:40:33 -0500 Received: by mail-pg0-f45.google.com with SMTP id a11so7251107pgu.13 for ; Mon, 12 Feb 2018 02:40:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=QZd+BVippxR8I1Rgy7FiktFdIDg+Mo2sHX3mVqqQF0M=; b=Cp/eiFNLqNrDMp6+2586s+zQ3FSmL7hm4yEwQxfzBB8fgLK8OhkwqolDf5o4xLD1ry yElsVIpD3i7PzlvYK7TNXny4s6ldgIn5YdzK16Axg7F0JIYT3d9xRiMk301klfkNBb8u DJTnfMIvbm528ybB6G3N4qTojaKl3dHB0pZUQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=QZd+BVippxR8I1Rgy7FiktFdIDg+Mo2sHX3mVqqQF0M=; b=DHjUiDOeQ1V5C/jHwQgbKqrPDJiA4anIVMVswsxNJHVkF8Zbp/iPL0zu2pIPhAWDW4 HYJdnhrgrY9gKVcC8LWfqd3ofBgjQEho6eGxAYlflyIKx5Hc2UgrcMYiOjS2yoLJ5BZx RnNF0qAl/A21fCcx9XOj9ks+TxO5Qe1BoVxFzqKKia9ahsIJUEV41kfjG/oDsx5Sxstl Ug/4HmfWgPdaEFw8KhBejxEtaK7UN/3OZd6kYUHl2mj4rb006w0vQ3ghQFErWVWJ96nn 8Xvh+eETZpNwgp0xxv3IYozG/ZZJw6RAwGDZ/m1tbl5rz/Ee02k4pEAO9G/Rcq8hW5Jw D+Iw== X-Gm-Message-State: APf1xPAO8kQ3rrvgefef5fEq6SqYj3D0YK1JE1nGIcp5SRhziCK0qKX6 iA8sqCw4toQ1WK4eFvijkcuXoA== X-Received: by 10.101.68.138 with SMTP id l10mr9096101pgq.119.1518432032765; Mon, 12 Feb 2018 02:40:32 -0800 (PST) Received: from localhost ([122.172.134.6]) by smtp.gmail.com with ESMTPSA id u26sm25132368pfk.126.2018.02.12.02.40.31 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 12 Feb 2018 02:40:32 -0800 (PST) Date: Mon, 12 Feb 2018 16:10:30 +0530 From: Viresh Kumar To: Shilpasri G Bhat Cc: rjw@rjwysocki.net, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, mpe@ellerman.id.au Subject: Re: [PATCH] cpufreq: powernv: Check negative value returned by cpufreq_table_find_index_dl() Message-ID: <20180212104030.GV28462@vireshk-i7> References: <1518430876-24464-1-git-send-email-shilpa.bhat@linux.vnet.ibm.com> <20180212102900.GU28462@vireshk-i7> <14e2fe70-7628-4377-664d-3c4b0071e08d@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <14e2fe70-7628-4377-664d-3c4b0071e08d@linux.vnet.ibm.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12-02-18, 16:03, Shilpasri G Bhat wrote: > I agree too. There is no way we can get -1 with initialized cpu frequency table. > We don't initialize powernv-cpufreq if we don't have valid CPU frequency > entries. Is there any other way to suppress the Coverity tool warning apart from > ignoring it? So IIUC, this warning is generated by an external tool after static analysis of the code ? If yes, then just ignore the warning. We shouldn't try fixing the kernel because a tool isn't smart enough to catch intentional ignorance of the return value here. -- viresh