Received: by 10.223.185.116 with SMTP id b49csp2257496wrg; Mon, 12 Feb 2018 06:59:19 -0800 (PST) X-Google-Smtp-Source: AH8x225dXWy+TptsjLXqX8RKsYWPvK/IuhypcTdUYoHUN+N4vdfpKzDtYsgrREdS4v54GtpYf97z X-Received: by 10.101.71.193 with SMTP id f1mr9380714pgs.91.1518447559777; Mon, 12 Feb 2018 06:59:19 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1518447559; cv=none; d=google.com; s=arc-20160816; b=eONf+re0nMM2WOIGlNpWNKPA1KLrT+V6SBokJgEi7dZgkTW8qN477SOyuUeOcllHWc 8od0Aoa89PuAYGtjJMyfHQ0zGIZZzpWEfQtVZXOgkvZOeaIBnONYIYXzkyPHTV+beFC2 hX28cTZ42E/D2HVdwkI6haFP0wYH4mk0QpHDqM42JeEWafOcGDRv4aRD963E7JSrK2Wu GmRI8ibygKd/VFB61Zo7OxttUxRNfaqIQThjyApmU2e0A/vi43BCmIaG0cTAC3K810L8 pau95IPfq2iyIICaNZkQwuCVK8uHFv+Pg38XepwY1br5AqMln5MIMVcwYRg9Mp6fY7P2 4i/g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :references:in-reply-to:mime-version:dkim-signature :arc-authentication-results; bh=nEILkAGrNJoD67/EvzDIhCBT/hE9t/y51xiqJ+dz2zA=; b=sqW5FxJm15veGi7G2PvBqJa6FUjyN+k/rHDHYHKnBbtiVeBb9MQMvM0N0aOhhxBxvq AHHKINSaEEuAFbO//+/U/JOA9Be3FHZLF8651uB8DwGDXc42QdgIyFoD2N14OWQdx/3d YgYv8Z7egsYSgelDs5KbD0/ZE4aR16heKCfn2TSZow0iPzjJlFRkyqv+/E/gGlHp2847 m+ABM6B6lYwwBPAWYGMU11fiB1AyTRb3GZSfKLnV8gP5zrg/3pIVCCvDKvGQR6gf3y25 qzzLufQeONiBcEqTQXgsbHSL5aqsWBaZEkVjRnhbL/7CzrB6GUISvkKumh6hP5VVlyxG RI2g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@nexb-com.20150623.gappssmtp.com header.s=20150623 header.b=aYKSloV6; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q12-v6si405407pls.509.2018.02.12.06.59.05; Mon, 12 Feb 2018 06:59:19 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@nexb-com.20150623.gappssmtp.com header.s=20150623 header.b=aYKSloV6; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935827AbeBLOQX (ORCPT + 99 others); Mon, 12 Feb 2018 09:16:23 -0500 Received: from mail-wr0-f196.google.com ([209.85.128.196]:41619 "EHLO mail-wr0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933892AbeBLOQV (ORCPT ); Mon, 12 Feb 2018 09:16:21 -0500 Received: by mail-wr0-f196.google.com with SMTP id q11so3567200wre.8 for ; Mon, 12 Feb 2018 06:16:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nexb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=nEILkAGrNJoD67/EvzDIhCBT/hE9t/y51xiqJ+dz2zA=; b=aYKSloV692vbfFR9zcEd9gNzdY13eRVWFhPyORP9O2K6AxwtQlrkuNt1zM90DLOEf7 yCEA5LHV7P3JL3rDxUl0tNG9y4bA7QufkVfs9WAOT4LhEZlAliLftc5jhw/lGfLRWbk1 ehoHUpRhu7+PvI56frcx0xYxxBTP4oz6pEU9+ylLNcPMNfGdh6KhKT+KGCxTHjlpe25g r6WErstNUCodU3JP/J9ZwuLxcfoU5Rvi5L/L/AxpO2W05maOwgeAVfjukjJxlamiMHDq u0l7Xk1dtZue7kmpOx2ZdwrySU0QwngNoiLz+BogxQbYdR+0DmOuX7zBMc0K+mnE4XzG vRTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=nEILkAGrNJoD67/EvzDIhCBT/hE9t/y51xiqJ+dz2zA=; b=f1/d/b8XItmHa/iJIgYU4G3JebraB/RZDagi6kyQ81EQ+ZZKE+nApUaIRlhUdNW4vA Tz/sq+3OKm5UvkPCUexU6d9b2ZexLF96JO009/cRWpDJppVrDdF7kV2D6kg0pX+cU0hr +CDiHekDNB3GlGQ0CNr8Ocedmo4dFnhjVITU6JnG4NpaJOfowZY9bAOCNvZuUpZKZTdi ZW4kQmopj18RgjeYQtNzuqa9emIDIFK4wKwekLQocuVptt7vGe969FpshSnvcqSw7SEE fHb7iaPBgl7eApj8uJmrcWDjtZcUZZS0+Fp4cHFuNH9+oJh3XKXaEJEgKhG0rfsLEb+g W4Xw== X-Gm-Message-State: APf1xPCax2YUAlYhLByfrzx1IIXuMFxfkCflnyXJLBH46dnKf3FW4mDl R7tsDEg0GvbXyxm7dwf4xPvo0pRaL4Te2In8jIbTgw== X-Received: by 10.223.170.12 with SMTP id p12mr9407789wrd.171.1518444980144; Mon, 12 Feb 2018 06:16:20 -0800 (PST) MIME-Version: 1.0 Received: by 10.223.195.139 with HTTP; Mon, 12 Feb 2018 06:15:39 -0800 (PST) In-Reply-To: <20180212120600.5cghrzz4jqvvkgz6@dell> References: <1518100057-23234-1-git-send-email-amelie.delaunay@st.com> <1518100057-23234-3-git-send-email-amelie.delaunay@st.com> <20180212120600.5cghrzz4jqvvkgz6@dell> From: Philippe Ombredanne Date: Mon, 12 Feb 2018 15:15:39 +0100 Message-ID: Subject: Re: [PATCH 2/6] mfd: Add ST Multi-Function eXpander core driver To: Amelie Delaunay Cc: Lee Jones , Linus Walleij , Rob Herring , Mark Rutland , Russell King , Alexandre Torgue , Maxime Coquelin , linux-gpio@vger.kernel.org, LKML , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Amelie, On Mon, Feb 12, 2018 at 1:06 PM, Lee Jones wrote: > On Thu, 08 Feb 2018, Amelie Delaunay wrote: > >> ST Multi-Function eXpander (MFX) is a slave controller using I2C >> for communication with the main MCU. Main features are: >> - 16 fast GPIOs individually configurable in input/output >> - 8 alternate GPIOs individually configurable in input/output >> - Main MCU IDD measurement >> - Resistive touchscreen controller >> >> Only GPIO expander (16 fast GPIOs + 8 alternate) feature is >> supported for the moment. >> >> Signed-off-by: Amelie Delaunay >> --- /dev/null >> +++ b/drivers/mfd/st-mfx.c >> @@ -0,0 +1,526 @@ >> +/* >> + * STMicroelectronics Multi-Function eXpander (ST-MFX) Core Driver >> + * >> + * Copyright (C) 2017, STMicroelectronics - All Rights Reserved >> + * Author(s): Amelie Delaunay for STMicroelectronics. > > You don't need to put "for STMicroelectronics". This was something we > made up when submitting from a different (!st.com) email address. > >> + * License terms: GPL V2.0. >> + * >> + * st-mfx Core Driver is free software; you can redistribute it and/or modify it >> + * under the terms of the GNU General Public License version 2 as published by >> + * the Free Software Foundation. >> + * >> + * st-mfx Core Driver is distributed in the hope that it will be useful, but >> + * WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or >> + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for more >> + * details. >> + * >> + * You should have received a copy of the GNU General Public License along with >> + * st-mfx Core Driver. If not, see . > > You should be able to use the short version of the licensing > agreement. Also, please grep for "SPDX". You can check the doc for the (fairly new) way to remove legalese boilerplate at Documentation/process/license-rules.rst or [1] It helps keep the focus on the code and less on licensing! [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/license-rules.rst -- Cordially Philippe Ombredanne