Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4236921104
Date:   Mon, 12 Feb 2018 12:04:52 -0500
From:   Steven Rostedt <rostedt@goodmis.org>
To:     "Du, Changbin" <changbin.du@intel.com>
Cc:     mingo@redhat.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] tracing/power: Don't share template for cpu_idle and
 cpu_frequency
Message-ID: <20180212120452.50abd9bf@gandalf.local.home>
In-Reply-To: <20180211105004.p55ajlt5kw36qwxi@intel.com>
References: <1518226624-8931-1-git-send-email-changbin.du@intel.com>
        <20180209214458.1ed36c3c@vmware.local.home>
        <20180211105004.p55ajlt5kw36qwxi@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Sun, 11 Feb 2018 18:50:04 +0800
"Du, Changbin" <changbin.du@intel.com> wrote:

> Steve, How abount DEFINE_EVENT_PRINT as below?

Yes, DEFINE_EVENT_PRINT is better.

> 
> diff --git a/include/trace/events/power.h b/include/trace/events/power.h
> index 908977d..e71ce98 100644
> --- a/include/trace/events/power.h
> +++ b/include/trace/events/power.h
> @@ -14,12 +14,12 @@
> 
>  DECLARE_EVENT_CLASS(cpu,
> 
> -       TP_PROTO(unsigned int state, unsigned int cpu_id),
> +       TP_PROTO(int state, unsigned int cpu_id),
> 
>         TP_ARGS(state, cpu_id),
> 
>         TP_STRUCT__entry(
> -               __field(        u32,            state           )
> +               __field(        s32,            state           )
>                 __field(        u32,            cpu_id          )
>         ),
> 
> @@ -28,13 +28,12 @@ DECLARE_EVENT_CLASS(cpu,
>                 __entry->cpu_id = cpu_id;
>         ),
> 
> -       TP_printk("state=%lu cpu_id=%lu", (unsigned long)__entry->state,
> -                 (unsigned long)__entry->cpu_id)

Yous still need the type casting, because s32/u32 on 32 bit machines
can be defined as "long".

-- Steve

> +       TP_printk("state=%d cpu_id=%u", __entry->state, __entry->cpu_id)
>  );
> 
>  DEFINE_EVENT(cpu, cpu_idle,
> 
> -       TP_PROTO(unsigned int state, unsigned int cpu_id),
> +       TP_PROTO(int state, unsigned int cpu_id),
> 
>         TP_ARGS(state, cpu_id)
>  );
> @@ -141,11 +140,13 @@ TRACE_EVENT(pstate_sample,
>                 { PM_EVENT_RESTORE, "restore" }, \
>                 { PM_EVENT_RECOVER, "recover" })
> 
> -DEFINE_EVENT(cpu, cpu_frequency,
> +DEFINE_EVENT_PRINT(cpu, cpu_frequency,
> 
> -       TP_PROTO(unsigned int frequency, unsigned int cpu_id),
> +       TP_PROTO(int state, unsigned int cpu_id),
> 
> -       TP_ARGS(frequency, cpu_id)
> +       TP_ARGS(state, cpu_id),
> +
> +       TP_printk("frequency=%u cpu_id=%lu", __entry->state, __entry->cpu_id)
>  );