Received: by 10.223.185.116 with SMTP id b49csp2413499wrg; Mon, 12 Feb 2018 09:09:16 -0800 (PST) X-Google-Smtp-Source: AH8x225RCAYqw9Eyoggm3fHRMR/RgIQKiAjWmT3ahDQ17wpi7ttmisAiXioazcCFj9QakzQ5gQKq X-Received: by 2002:a17:902:2cc3:: with SMTP id n61-v6mr11242316plb.440.1518455356847; Mon, 12 Feb 2018 09:09:16 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1518455356; cv=none; d=google.com; s=arc-20160816; b=wqcZodHoU571AQ5x4uXYYbIfEUaI1pTE5a2jbHbSp+pWgI7LLmjr9EhNuqz4Nv6bjd dolcjIVr8VwA9eVo+xZQ2sPhSHb+r/WZ74yDa5FIytE3zpGILkf50yFCKiaupZJ6dP4n vN6v76DSDtgBpf60LhL7ozyH++66RWhVvbwZNd42CP3JVKUeym4jK6ob4FOTAuzE2Wu9 zPKtKae+TsgrBOUTGv5lfvZEAoy42Ygva3UGcxnfT8wV3GVuuVykxz+gH4Kxx3CpDiuZ SOfw1+lEkegOET5CPQyG8CGitoVs9HlvNQLyMvGVD6zUWiVwNoDxxizguCuhslAQvhas zEeA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature:arc-authentication-results; bh=d2Y5SU5RGjY+qYjy6me5bu4WeCBfvNMJ/9+EcVgj3fE=; b=WVO45cPd0Kze+haVQDM7RkJKjhPnOtQJZk5yEolTXyDHqmT32qSI+jktwyncHQIJql FQFBszomz9FIyKSAJl9ZeCBpnENsIwy8YcFYWkf93RpQ8FdM3+uo5PhRtrGKfNwzoB4K hSochJILG/SHq2G9GSXu2lFYBEmy4toEOE1XiInO1zxqAbqXKltEmFVsyCs5AnCgma2o OzyspWyl58xEoGkdW65yt5jEGVmEjESiPfqa+zx0VjrbSKwP6jSaZXFss8aCro8p8uyo Fb2dEhTVPGeSjocsH/ouLQBk+fAp6qaKTUGUhsv9e9tDRMRI91xFOT3H2Z7k8frsexM6 mbSg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=jeRwLQNk; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t5si6516726pfj.99.2018.02.12.09.09.01; Mon, 12 Feb 2018 09:09:16 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=jeRwLQNk; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753288AbeBLRHy (ORCPT + 99 others); Mon, 12 Feb 2018 12:07:54 -0500 Received: from mail-qk0-f179.google.com ([209.85.220.179]:33732 "EHLO mail-qk0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751156AbeBLRHu (ORCPT ); Mon, 12 Feb 2018 12:07:50 -0500 Received: by mail-qk0-f179.google.com with SMTP id c82so19203875qka.0 for ; Mon, 12 Feb 2018 09:07:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=d2Y5SU5RGjY+qYjy6me5bu4WeCBfvNMJ/9+EcVgj3fE=; b=jeRwLQNklFclU72UC61JEmYH3FWdv0AiWfipUqNpNZSCiiA/gCg44gsTGqAmr4czZS zaiTYcMgwK6sIbqKSVZAIDwzZBsaSphZMr7ez3SCCZqh1uh/+YQSGxlfhIYFFDMmzcwv KQXMWEq8NoswmxnFSeVLkW0FUgR0NuVMA6R0XXaQdLrZDVFPStCLmkJJ7CcbmRk9+fBC M1PbPNqaB31wlj0FUhQNR55Uflln2ZJlCWGBRFoSEA4iwho0oPpet0jKjPvlt017vk4D UkLEmJV/eKGW2ljSxOTsYKAPf5OfYimRVnfyQZ6VdQxWsK+XgKu/FSaB0M1lpPm4KI4c zCDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=d2Y5SU5RGjY+qYjy6me5bu4WeCBfvNMJ/9+EcVgj3fE=; b=h4hW+Vbi9gWa12YEVenluSPLIJSI9zSTvgmjs8tklj9M7jynvB3BQh1RGVJggFJ5kr oIijb76OWCuxifM417Zdb39oZAi+fUMKbiQW8Bor4BySYCQuKanW6JjU1jaCNV/7ZWxF fA7rMZ5dRSutxhISYmfx3pPDLT77dzJrT1aWZrjyawuzveDVIbQBFDxnrzYOELqGVYXk XlDyTNChcnq/4lriofnwlmQ8674S0oHv+lESq4fYKdsNaNHbr1Ig5RtCdq4zB2e5Y986 clvgyfEd9H1fcym0AE5QRMNVWi8UuDkewW4pDFh5S4SRUWCPh77+KLss0R5+zLzKl0fD vbTQ== X-Gm-Message-State: APf1xPB/mQvou5J+xjm1vsOK+LnMcrUwlXBVK4KSs+L24CUZhKpV6EkQ JAaRMWMwG3ZeXV1MKZ65F9I= X-Received: by 10.55.195.138 with SMTP id r10mr16866000qkl.269.1518455269834; Mon, 12 Feb 2018 09:07:49 -0800 (PST) Received: from localhost (dhcp-ec-8-6b-ed-7a-cf.cpe.echoes.net. [72.28.5.223]) by smtp.gmail.com with ESMTPSA id l10sm7007801qta.45.2018.02.12.09.07.49 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 12 Feb 2018 09:07:49 -0800 (PST) Date: Mon, 12 Feb 2018 09:07:47 -0800 From: Tejun Heo To: Lukas Wunner Cc: Lai Jiangshan , Alex Deucher , Dave Airlie , Ben Skeggs , dri-devel@lists.freedesktop.org, Peter Wu , nouveau@lists.freedesktop.org, Lyude Paul , Hans de Goede , Pierre Moreau , linux-kernel@vger.kernel.org, Ismo Toijala , intel-gfx@lists.freedesktop.org, Liviu Dudau , Archit Taneja Subject: Re: [PATCH 1/5] workqueue: Allow retrieval of current task's work struct Message-ID: <20180212170747.GX695913@devbig577.frc2.facebook.com> References: <2d8f603074131eb87e588d2b803a71765bd3a2fd.1518338788.git.lukas@wunner.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2d8f603074131eb87e588d2b803a71765bd3a2fd.1518338788.git.lukas@wunner.de> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, On Sun, Feb 11, 2018 at 10:38:28AM +0100, Lukas Wunner wrote: > Introduce a helper to retrieve the current task's work struct if it is > a workqueue worker. > > This allows us to fix a long-standing deadlock in several DRM drivers > wherein the ->runtime_suspend callback waits for a specific worker to > finish and that worker in turn calls a function which waits for runtime > suspend to finish. That function is invoked from multiple call sites > and waiting for runtime suspend to finish is the correct thing to do > except if it's executing in the context of the worker. > > Cc: Tejun Heo > Cc: Lai Jiangshan > Cc: Dave Airlie > Cc: Ben Skeggs > Cc: Alex Deucher > Signed-off-by: Lukas Wunner I wonder whether it's too generic a name but there are other functions named in a similar fashion and AFAICS current_work isn't used by anyone in the tree, so it seems okay. Acked-by: Tejun Heo Please feel free to route as you see fit. Thanks. -- tejun