Received: by 10.223.185.116 with SMTP id b49csp2474075wrg; Mon, 12 Feb 2018 10:06:17 -0800 (PST) X-Google-Smtp-Source: AH8x225FWN4+E75fIhlBy0dWaJJ1qG/xRHh0jiqkVeC0cgaJS7XoBNLfN3/bft5akTMyahphJmzT X-Received: by 10.98.16.9 with SMTP id y9mr12551353pfi.189.1518458777129; Mon, 12 Feb 2018 10:06:17 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1518458777; cv=none; d=google.com; s=arc-20160816; b=k5IFg0oWvWz5lYC8sR3gB/Zv8arpMZ5ixNlWKt3+Vqf58ssxTdfGcTaYEvo0AYIjfa IcoKa7HZUptgzmghseY8Zp9e4WOgvIqE5kAux8JX4zk0riO4eufyAx9p1gAc8bSUAD3X QEFLMgHbYE5oeU+BT2RaJQISf7oeRJGAZNIqS1kwscTUoYu7nhyiHeFvugHtM6bc7MU1 AilqIggIinoBrgASvp76y3sSQ3URexMKphO0lXpZqPjQM4FpTpIKDs1rV4N9G/fSfQP1 UF4+LpW4GCqCgwEKoWu+5fqFoU6IQPe5OHSNf3t/pLCtr35wxmgI6tXzGwwzju1WIp3w lkvg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:arc-authentication-results; bh=RbUHLDdUs6kUMWWlLC/9qk8W5mNsCvATTqoBhi96Zc0=; b=AeiRKRM2YIIH+aYAZP6Gz/MalqDErsa1m6Me1v6vDyJREuwZWtduRXcHBSbrb0Yqlw MPOFz4a1+muPBJXhacDS49iF2ErR1hy3Bx7TKLbAtBJUMlxhJJizjUjV8C0S/JB+s3ks 9glF1b7pCLL2gW5DhOyFaWN7dUt/dr8MisQK8ZI/Q92MKZtXIk95T0P5zTUpH/ATv3RC kb3e5KtUrmU3cni5KBapJc6ZBJDe5ne97ccw2tcYAYj9L0CAevmuvHte9wosu2zGKriW BuR/v0JWXP99ifJzIujvlwntLhZ+z8XSJ8Qd5Fs11cs5Lb44rnGcJFhcW/ckudDmGh4C T0KQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a9si2397274pff.338.2018.02.12.10.06.01; Mon, 12 Feb 2018 10:06:17 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753519AbeBLSEj (ORCPT + 99 others); Mon, 12 Feb 2018 13:04:39 -0500 Received: from gateway33.websitewelcome.com ([192.185.145.216]:49540 "EHLO gateway33.websitewelcome.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752741AbeBLSEi (ORCPT ); Mon, 12 Feb 2018 13:04:38 -0500 Received: from cm11.websitewelcome.com (cm11.websitewelcome.com [100.42.49.5]) by gateway33.websitewelcome.com (Postfix) with ESMTP id 60F36285CD for ; Mon, 12 Feb 2018 12:04:37 -0600 (CST) Received: from gator4166.hostgator.com ([108.167.133.22]) by cmsmtp with SMTP id lISzej0cPvkfxlISzeB98F; Mon, 12 Feb 2018 12:04:37 -0600 Received: from [189.175.4.238] (port=46316 helo=[192.168.1.66]) by gator4166.hostgator.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.89_1) (envelope-from ) id 1elISy-0033Zw-NN; Mon, 12 Feb 2018 12:04:36 -0600 Subject: Re: [PATCH] spi: bcm2835aux: use 64-bit arithmetic instead of 32-bit To: Ard Biesheuvel , "Gustavo A. R. Silva" Cc: Mark Brown , Eric Anholt , Stefan Wahren , Florian Fainelli , Ray Jui , Scott Branden , bcm-kernel-feedback-list@broadcom.com, Linux Kernel Mailing List , linux-rpi-kernel@lists.infradead.org, linux-arm-kernel , linux-spi@vger.kernel.org References: <20180207160002.GA9292@embeddedgus> From: "Gustavo A. R. Silva" Message-ID: <275feee3-7140-498b-714f-4c88a302d3f6@embeddedor.com> Date: Mon, 12 Feb 2018 12:04:34 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator4166.hostgator.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - embeddedor.com X-BWhitelist: no X-Source-IP: 189.175.4.238 X-Source-L: No X-Exim-ID: 1elISy-0033Zw-NN X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: ([192.168.1.66]) [189.175.4.238]:46316 X-Source-Auth: garsilva@embeddedor.com X-Email-Count: 9 X-Source-Cap: Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20= X-Local-Domain: yes Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Ard, On 02/08/2018 03:54 AM, Ard Biesheuvel wrote: > On 7 February 2018 at 16:00, Gustavo A. R. Silva wrote: >> Add suffix ULL to constant 9 in order to give the compiler complete >> information about the proper arithmetic to use. Notice that this >> constant is used in a context that expects an expression of type >> unsigned long long (64 bits, unsigned). >> >> The expression tfr->len * 9 * 1000000 is currently being evaluated >> using 32-bit arithmetic. >> >> Addresses-Coverity-ID: 1339619 > > What does this number mean? If it is an index into some internal > database, please remove it. > This is a unique Coverity identifier. We want to keep information like public Bugzilla IDs and tools like Coverity on the commit message. Thanks -- Gustavo