Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH RESENT] nvme-pci: suspend queues based on online_queues
To:     Jianchao Wang <jianchao.w.wang@oracle.com>, keith.busch@intel.com,
        axboe@fb.com, hch@lst.de
Cc:     linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org
References: <1518440713-1031-1-git-send-email-jianchao.w.wang@oracle.com>
From:   Sagi Grimberg <sagi@grimberg.me>
Message-ID: <5011398b-8797-ece6-9df0-436c32aed33e@grimberg.me>
Date:   Mon, 12 Feb 2018 20:37:48 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.6.0
MIME-Version: 1.0
In-Reply-To: <1518440713-1031-1-git-send-email-jianchao.w.wang@oracle.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


> nvme cq irq is freed based on queue_count. When the sq/cq creation
> fails, irq will not be setup. free_irq will warn 'Try to free
> already-free irq'.
> 
> To fix it, we only increase online_queues when adminq/sq/cq are
> created and associated irq is setup. Then suspend queues based
> on online_queues.
> 
> Signed-off-by: Jianchao Wang <jianchao.w.wang@oracle.com>

Can I get a review for this?