Received: by 10.223.185.116 with SMTP id b49csp2659161wrg; Mon, 12 Feb 2018 13:32:51 -0800 (PST) X-Google-Smtp-Source: AH8x224EyON0GeYMBAkQB5F9/e7n7OYZyL7K1ixlru0Zs6IzF6hav2yMV+lDD26+mD3jEU0CqGgi X-Received: by 10.98.0.17 with SMTP id 17mr12659491pfa.63.1518471170955; Mon, 12 Feb 2018 13:32:50 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1518471170; cv=none; d=google.com; s=arc-20160816; b=EpVmnYGRzZGd637KX/Qq3l6Snnhm5e+Kq55sBlg9DLsNFoe3NYJLNxBBDKriCQkn36 K/mvU3b0DwS9EWbvAAwTXcK5APcmv5Ya4FuflhdcfzwSt27WFvk4c4vmCXBF4roUUxwy poOY55tcouvxe46Y99EW28AeYQY4udhQkuXpapWIdtZhbzo3BPPu7wTHuSGsImKV9tS8 99MEOyMPfyCo6jCalbAu2nQXzJfns2Cs4WWaxY7SIG9IMeEnIxQxt6+gPKfboaEg6Wa1 nlpSD/pGubRrnzRUrVV9gZ3ud1NLViuk6IuL4mSheBbvY4tmEe3o75k0AnCqj/EeZaWE 8S2Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :arc-authentication-results; bh=TYbH/8c8AO/11hzTYJM5J6sAQh+RUOw0NDMlNgbC14g=; b=Io5PmhrcOSq/bUwLEDaRdW+gA4Ta3KHSZz8gHpJ82zmyUJhOySsE69URDfGXfYhrGw NH+x42MudAaH2Yx73RW46fZalI4vIAML6FlC2BiiXiTFs8ySzXBrboCnYgEDBVJl6zf9 MAoT4B4bg0nCXt+xBjbtm5XOZoTVkbOdaK8QssrppdbqD5js8u+dDh25daRN0NDAsfKE Hf4U1PwwzFOmYjUGZrveceH2EwNaNrbXAFU/DHang3Ptz7Wqtjx0glUkl6z8WYCiX8D1 0VsTqeUlwDWOpKU/1jgV/3YeTUucaFckJsy78J6QckQsbtT4JSE3P5HgHT2fU+9Y8biY 8XWg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id bg3-v6si6232895plb.28.2018.02.12.13.32.36; Mon, 12 Feb 2018 13:32:50 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932562AbeBLVbp (ORCPT + 99 others); Mon, 12 Feb 2018 16:31:45 -0500 Received: from mail.free-electrons.com ([62.4.15.54]:35128 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932496AbeBLVbl (ORCPT ); Mon, 12 Feb 2018 16:31:41 -0500 Received: by mail.free-electrons.com (Postfix, from userid 110) id 444C6207CF; Mon, 12 Feb 2018 22:31:40 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mail.free-electrons.com X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,SHORTCIRCUIT, URIBL_BLOCKED shortcircuit=ham autolearn=disabled version=3.4.0 Received: from bbrezillon (91-160-177-164.subs.proxad.net [91.160.177.164]) by mail.free-electrons.com (Postfix) with ESMTPSA id 093612071C; Mon, 12 Feb 2018 22:31:40 +0100 (CET) Date: Mon, 12 Feb 2018 22:31:39 +0100 From: Boris Brezillon To: Alexey Khoroshilov Cc: Boris Brezillon , ldv-project@linuxtesting.org, Richard Weinberger , linux-kernel@vger.kernel.org, Stefan Agner , linux-mtd@lists.infradead.org Subject: Re: [PATCH v4 0/3] mtd: nand: vf610: fix error handling in vf610_nfc_probe() Message-ID: <20180212223139.2e5404a9@bbrezillon> In-Reply-To: <1518215316-21504-1-git-send-email-khoroshilov@ispras.ru> References: <20180130141141.7f4fd15a@bbrezillon> <1518215316-21504-1-git-send-email-khoroshilov@ispras.ru> X-Mailer: Claws Mail 3.15.0-dirty (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 10 Feb 2018 01:28:33 +0300 Alexey Khoroshilov wrote: > vf610_nfc_probe() misses error handling of mtd_device_register() > and contains unneeded of_node_put() on error path. Applied the whole series. Thanks, Boris > > v2: Add nand_cleanup() to undone nand_scan_tail() as Boris Brezillon noted. > v3: Rename error labels, remove of_node_put() per Boris Brezillon request. > v4: Separate fix in to 3 patches. > > Alexey Khoroshilov (3): > mtd: nand: vf610: remove the unnecessary of_node_put() > mtd: nand: vf610: improve readability of error label > mtd: nand: vf610: check mtd_device_register() return code > > drivers/mtd/nand/vf610_nfc.c | 29 ++++++++++++++++------------- > 1 file changed, 16 insertions(+), 13 deletions(-) > -- Boris Brezillon, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering http://bootlin.com