Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   "Yang, Shunyong" <shunyong.yang@hxt-semitech.com>
To:     "linux@rasmusvillemoes.dk" <linux@rasmusvillemoes.dk>
CC:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "andriy.shevchenko@linux.intel.com" 
        <andriy.shevchenko@linux.intel.com>,
        "Zheng, Joey" <yu.zheng@hxt-semitech.com>,
        "me@tobin.cc" <me@tobin.cc>
Subject: Re: [PATCH] vsprintf: replace space with readable '=' before crng
 is ready
Thread-Topic: [PATCH] vsprintf: replace space with readable '=' before crng
 is ready
Thread-Index: AQHTpJMy03PZ12s5rE2BmcmzlD2+sKOhZgCAgAALbQA=
Date:   Tue, 13 Feb 2018 07:57:50 +0000
Message-ID: <1518508670.3326.6.camel@hxt-semitech.com>
References: <1518502848-7694-1-git-send-email-shunyong.yang@hxt-semitech.com>
         <CAKwiHFiLQjFc3x9Q9=GEgnuiDPH_aBf7P1-=wPB7WtTo2ExDaA@mail.gmail.com>
In-Reply-To: <CAKwiHFiLQjFc3x9Q9=GEgnuiDPH_aBf7P1-=wPB7WtTo2ExDaA@mail.gmail.com>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="iso-8859-15"
Content-ID: <30E61B702F14C94588059CEB4C178DEA@hxt-semitech.com>
Content-Transfer-Encoding: 8BIT
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi,?Rasmus,

On Tue, 2018-02-13 at 08:16 +0100, Rasmus Villemoes wrote:
> On 13 February 2018 at 07:20, Shunyong Yang
> <shunyong.yang@hxt-semitech.com> wrote:
> 
> > 
> > 
> > This patch replaces space with readable "=" when output needs
> > padding.
> > Following is the output after applying the patch,
> > 
> > Suggested-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
> > 
> > ????????if (unlikely(!have_filled_random_ptr_key)) {
> > +???????????????char *ptrval_str = "(ptrval)";
> > +???????????????char str[default_width + 1];
> > +???????????????int len = strlen(ptrval_str);
> > +
> > +???????????????if (default_width > len) {
> > +???????????????????????int pos;
> > +
> > +???????????????????????pos = (default_width - len) / 2;
> > +???????????????????????memset(str, '=', default_width);
> > +???????????????????????memcpy(str + pos + 1, ptrval_str + 1, len -
> > 2);
> > +???????????????????????str[0] = '(';
> > +???????????????????????str[default_width - 1] = ')';
> > +???????????????????????str[default_width] = 0;
> > +???????????????????????ptrval_str = str;
> > +???????????????}
> > +
> I'm sorry, but that's way too convoluted.
> 
> > 
> > ????????????????spec.field_width = default_width;
> > ????????????????/* string length must be less than default_width */
> > -???????????????return string(buf, end, "(ptrval)", spec);
> > +???????????????return string(buf, end, ptrval_str, spec);
> > ????????}
> I was thinking of just doing something like
> 
> -???????????????return string(buf, end, "(ptrval)", spec);
> +???????????????return string(buf, end, sizeof(void *) == 8 ?
> "(====ptrval====)" : "(ptrval)", spec);
> 

Thanks a lot! It's more straightforward considering 32/64-bit system.

Thanks.
Shunyong.