Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
In-Reply-To: <20180213072328.GA1636@1wt.eu>
References: <1516095490-83827-1-git-send-email-wangxiongfeng2@huawei.com>
 <CANiq72=AeytaT5KBtujTBUkfbNTFFxMPAeToqzmZJOr790R6yw@mail.gmail.com>
 <a1034df8-246d-e979-e2ee-2974ae31dde7@huawei.com> <20180213072328.GA1636@1wt.eu>
From:   Arnd Bergmann <arnd@arndb.de>
Date:   Tue, 13 Feb 2018 09:28:18 +0100
Message-ID: <CAK8P3a0k=XTmys46cvAd2k-TRPO0YLawFur4PzGA_scwr5mChQ@mail.gmail.com>
Subject: Re: [PATCH V2] auxdisplay: use correct string length
To:     Willy Tarreau <w@1wt.eu>
Cc:     Xiongfeng Wang <wangxiongfeng2@huawei.com>,
        Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>,
        Dan <dan.carpenter@oracle.com>,
        linux-kernel <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, Feb 13, 2018 at 8:23 AM, Willy Tarreau <w@1wt.eu> wrote:
> On Tue, Feb 13, 2018 at 09:19:21AM +0800, Xiongfeng Wang wrote:

>> This may suppress the gcc warning.
>
> In fact there are two big problems with gcc warnings :
>   - writing -Wno-something-unknown triggers an error on versions where
>     "something-unknown" isn't known, making it difficult to permanently
>     disable warnings (though in the kernel we handle this pretty fine)

We have the $(call cc-disable-warning) helper for this.

>   - warnings and diagnostics are conflated. Some warnings should only be
>     provided when the developer explicitly asks for suspicious stuff
>     (-Wsecurity, -Wsuspicious, etc) that would *not* be part of -Wall
>     since -Wall is usually used to report real warnings.

And this is what the W=1 and W=2 make options are for.

I originally asked Xiongfeng to look at some of the new gcc-8 warnings,
but must have miscommunicated at some point. I think we do want to
enable the new -Wstringop-overflow warnings by default and fix all
instances, including the false-positive ones. This is a useful warning
because it tells you when you actually write past a buffer, e.g. using
strcpy() with a source string that is longer than the destination.

For  -Wstringop-truncation, we can decide whether it should be W=1
or W=2, but I'd still make it possible for users and maintainers to
easily enable the warning when test building new code.

       Arnd