Received: by 10.223.185.116 with SMTP id b49csp3352522wrg; Tue, 13 Feb 2018 01:01:46 -0800 (PST) X-Google-Smtp-Source: AH8x2253RtSp7jvNPE22N9J+YBtwlgVL0jTvIDIK6khT+1h55gTrkrQSo03phhWBHEX0EQcph48V X-Received: by 10.101.77.134 with SMTP id p6mr440673pgq.230.1518512506173; Tue, 13 Feb 2018 01:01:46 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1518512506; cv=none; d=google.com; s=arc-20160816; b=YJl8W1rchDVxbRpc1KCoR1SyjFrHZQy7KfTppknu1a+bIh53IpkzsoCmwnPVYK07tg 8SORZuyM50Cu08ttdfJ2ujdM0mTUJvDQjK0z8l1l08/fIe3Nl+oowqk7qkets8kya2Ly 3dgQDI+r62NB29f1utJAV6mnbAMTidSHWMyoQ5cKbRkDRgkyl06jd0P4deyZNAjpCTrh r1lMYM1bqDSi+mEavqj7wl3cgcJG4ksuhBO0TR4P+4QjebPDARIG+pYJjt0ozPKekIJC nQuDySUS6Or6EMH6CfDwEmcM0GhXDzN7YKAOk7vrOuuw1Fmc4CxM17muYWGHLOUk4erF ZZCA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :references:in-reply-to:mime-version:dkim-signature:dkim-filter :arc-authentication-results; bh=OoHN3L+EgMi3QdRVCikhsLANjFHuDxATT8s2PGOuNn0=; b=Hv4Sx3x4+gawFztH+EPyBqI44l74gQ26XQ1wX2thQ4iulZPESPIT0gMiVidFjRJb+H UTtr+b3Cbhht/2nBCQobw5Qi7nWfQq5XuJGNDCjHvna/hD9aqiCAaZZbqXmPpLHi6gmy HW66AqUTJz1knoHEI3aFTBwIsr84/jXOf9OBdFMum88aOGev1PM8VJ4SlzBhli1RGCpF x4LMNJCYjDDBUVwzwVnhVZC1TtJEvPPLUIl11sLgB7iU+7Gkq0Lxiw8zIjaCKhdvhkqU BLkLKZ9l6kJWwLXQOjzAOXPv+G+fys9gpCV0Qya7MkdIuyAUXvRYCqvemBVtprik8hH1 pkeA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@nifty.com header.s=dec2015msa header.b=QH7LZWwI; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f7si903947pgt.231.2018.02.13.01.01.31; Tue, 13 Feb 2018 01:01:46 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@nifty.com header.s=dec2015msa header.b=QH7LZWwI; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933868AbeBMJAR (ORCPT + 99 others); Tue, 13 Feb 2018 04:00:17 -0500 Received: from conssluserg-03.nifty.com ([210.131.2.82]:24972 "EHLO conssluserg-03.nifty.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933588AbeBMJAP (ORCPT ); Tue, 13 Feb 2018 04:00:15 -0500 Received: from mail-vk0-f46.google.com (mail-vk0-f46.google.com [209.85.213.46]) (authenticated) by conssluserg-03.nifty.com with ESMTP id w1D906sC005556; Tue, 13 Feb 2018 18:00:07 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conssluserg-03.nifty.com w1D906sC005556 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com; s=dec2015msa; t=1518512407; bh=OoHN3L+EgMi3QdRVCikhsLANjFHuDxATT8s2PGOuNn0=; h=In-Reply-To:References:From:Date:Subject:To:Cc:From; b=QH7LZWwICKyUOy+qp0SCb4iEhUxTTDA8IGYHbfwzprsdRbLjj0AbmmoGJwoLNv31X tWzkUyKElJmV30a2wBEUw5+1rqJzx7OB5FwwYGnaNTV2md9xFiHjqpP0vIeH8vrKZ4 aewjP4bPaf97fmTxXGDQmffRNSw9XHD4YxAcJxJ4oqcYf2nQPZQ9fNkqMWF9AzpLN1 U6w9lyj7dMEboI8zHQ4OtobJak8mClpjyyJe5y84qGRMxaur4d4pKve+gmwdtqqLGV lt4fBjdbnzdtBgrBx6ZBUEeJYIP6zDjMILSnz3AbUSdcaWmtRmeomL8fCjqCBQhc04 2VCAv94R2RMTg== X-Nifty-SrcIP: [209.85.213.46] Received: by mail-vk0-f46.google.com with SMTP id n132so10403074vke.2; Tue, 13 Feb 2018 01:00:06 -0800 (PST) X-Gm-Message-State: APf1xPDbD8FD6Eat1TJOlogwk/ggcG+mgk/hQSc/ngiHLbNBSBtVF8B0 40zd4XLM+l+OTpqwjpk8XsidzW6plX8cDKDn91o= X-Received: by 10.31.85.193 with SMTP id j184mr419495vkb.152.1518512405644; Tue, 13 Feb 2018 01:00:05 -0800 (PST) MIME-Version: 1.0 Received: by 10.176.83.212 with HTTP; Tue, 13 Feb 2018 00:59:25 -0800 (PST) In-Reply-To: References: <20180210054843.z3g7wvcmlccvww3h@huvuddator> <20180210074924.3nhxsza5zdbaahxx@huvuddator> <20180210080556.mycqsjhxbaguwhay@huvuddator> <20180210085519.737ckf4bcl57h4g2@huvuddator> <20180211103432.pf2ot6nd7nbhdhsy@huvuddator> <49c196ec-891d-2030-bd6c-7222feb22059@infradead.org> From: Masahiro Yamada Date: Tue, 13 Feb 2018 17:59:25 +0900 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [RFC PATCH 4/7] kconfig: support new special property shell= To: Arnd Bergmann Cc: Randy Dunlap , Kees Cook , Ulf Magnusson , Linus Torvalds , Linux Kbuild mailing list , Greg Kroah-Hartman , Andrew Morton , Nicolas Pitre , "Luis R . Rodriguez" , Sam Ravnborg , Michal Marek , Martin Schwidefsky , Pavel Machek , linux-s390 , Jiri Kosina , Linux Kernel Mailing List , Tejun Heo , Ingo Molnar , "Van De Ven, Arjan" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 2018-02-13 17:35 GMT+09:00 Arnd Bergmann : > On Tue, Feb 13, 2018 at 2:53 AM, Randy Dunlap wrote: >> On 02/12/2018 05:41 PM, Masahiro Yamada wrote: >>> 2018-02-13 8:48 GMT+09:00 Randy Dunlap : >>>> On 02/12/2018 07:24 AM, Kees Cook wrote: >>>>> On Mon, Feb 12, 2018 at 6:39 AM, Masahiro Yamada >>>>> wrote: >>>> >>>>>>> (And in thinking about this, does Kconfig know the true $CC in use? >>>>>>> i.e. the configured cross compiler, etc?) >>>>>> >>>>>> I was thinking of removing CONFIG_CROSS_COMPILE. >>>>>> >>>>>> A user can dynamically change CROSS_COMPILE from >>>>>> "make menuconfig". >>>>> >>>>> Most builds I've seen implement cross compilers as an environment >>>>> variable during all "make" invocations. >>>> >>>> I agree. I think you would break a bunch of build bots if you remove that. >>> >>> >>> For clarification, I suggested to remove CONFIG_CROSS_COMPILE. >>> >>> The following code: >>> https://github.com/torvalds/linux/blob/v4.16-rc1/Makefile#L315 >>> https://github.com/torvalds/linux/blob/v4.16-rc1/init/Kconfig#L58 >>> >>> I hope build bots are not using this. >>> >>> >>> Passing CROSS_COMPILE via the command line, environment >>> is still supported. >> >> OK, I misunderstood. That one can go away IMO. > > Removing it will break the workflow for some people in a minor way > though. Could we have the top-level Makefile try to detect the > CROSS_COMPILE? Instead of just using CC=gcc as the default, > we could check for ${ARCH}!=`uname -m` and then see if $PATH > contains a ${ARCH}-linux-gcc, ${ARCH}-elf-gcc or ${ARCH}-gcc. > > it will need slightly more complexity to deal with architectures > that have different identifiers in linux and gcc, but I think it would > be a nice feature anyway. > > Arnd Some architectures such as m68k, mips, etc. do this in their arch/*/Makefile by using $(call cc-cross-prefix, ...) But, currently we do not do this globally. It would be possible to do it, but it does not mean backward-compatible with CONFIG_CROSS_COMPILE. -- Best Regards Masahiro Yamada