Received: by 10.223.185.116 with SMTP id b49csp3643206wrg; Tue, 13 Feb 2018 05:36:11 -0800 (PST) X-Google-Smtp-Source: AH8x22706MSmv/rhP8Zi2yO2G5dPcTmxV0jXYtBGMFSqiZ8k65lDH3LKpPxEqeY+4TuDjBIdQgrN X-Received: by 2002:a17:902:8c81:: with SMTP id t1-v6mr1126819plo.363.1518528970981; Tue, 13 Feb 2018 05:36:10 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1518528970; cv=none; d=google.com; s=arc-20160816; b=GC/qWxuSGTSgYiuAksqwnYXqtEY68EwHMdfZoQS2oAjJ/IOWcLAKl1L+E3pxl/jMji FBq5XFDvIFvNlqpmSmtDU1pfUf6zIJHcXqGHgS9HFclSJdeYgJiVGMV8GzDNpCkan9PG OI7Ofcf2JyTeSo2+Vn47lpdly70YPjaPrc+FUyOooCbAL7Z0Wm33gT7QJjALq1x+qVXr KUfNMeDTS9adtujlUtU1xnnPNAi40vrtBJnVu++Zg+UXJnmVSl8G0qKlbQ82PrZROsxM 2+nMWpECMMfViBtsyOThTQPjRwCmbHwtGzr5+vO+9p6/PfDdAfVzdfjW4bnpRfyeNQFU ukjw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :references:in-reply-to:mime-version:dkim-signature :arc-authentication-results; bh=/4NDhV+Pl2QCAvz0f9BOgUlvG4SWq1wTVS+rO7yvkmA=; b=qAL1mP8FOUFN3BzsmQwqRc1mB6DyHE85qz615TQXIB0rF/+5ShVPtC10gocdlZiwyY 4k7G2JPRnk2exs3JUw/+rykRwC/Idfjjb1rx+i5LmgPSHR71GV2I+lrQ/uCbVuP7OGZs LskHsTbrYGvB/z61HgXzOx4ecIHzMgcHaU+0TMpoC/jvcYEHWt/e47wk30Zj14ladrxh QZgGp1/ffNylIHOgktaSD+bLFX4EgzpffUB1T96E3voRjf2VLxUirpyWeWljbZmpjX+M pctkU4MdZmSTxwRq9+d+ooykv4MtK8uaqnj73yAhebNx1wWV3TSWXDwipZ41zS/S71gq ymOA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=BQZDcZnQ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j77si1569996pfa.216.2018.02.13.05.35.56; Tue, 13 Feb 2018 05:36:10 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=BQZDcZnQ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964842AbeBMNeM (ORCPT + 99 others); Tue, 13 Feb 2018 08:34:12 -0500 Received: from mail-lf0-f66.google.com ([209.85.215.66]:38132 "EHLO mail-lf0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964776AbeBMNeK (ORCPT ); Tue, 13 Feb 2018 08:34:10 -0500 Received: by mail-lf0-f66.google.com with SMTP id g72so25080665lfg.5; Tue, 13 Feb 2018 05:34:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=/4NDhV+Pl2QCAvz0f9BOgUlvG4SWq1wTVS+rO7yvkmA=; b=BQZDcZnQrkTiuzEy6EzxSPeKsz4FIQLC8lvcy7ngYltT9O/RZsRaJmtVJ3A0wIxCr0 X3GUu89MKGeRBA8eCli4y1pU5Gp33Fdk9ZZF3nCdQXIpzqBZJ/1TKHeMUhD6CO8JXo8G nxmRDh6PqIald4gXpfTzLYiGpnaoZ4KR7k1gX/ZGOt6CYBdhJXCzq3VTFEQ8nYe40zEI Ol636ZdGFL6jtWLwhfq/9BvdhfRKcVww4fkTeQ0I2fQ/3Dg7nptLcMDA59tPlUG2VFBJ A3pb1+9irS+BSLTJJ+T6RMW2ukti/iPOESSz6+NPed6bpZ+F7rDGgqCy97aP32FC1AIH hepA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=/4NDhV+Pl2QCAvz0f9BOgUlvG4SWq1wTVS+rO7yvkmA=; b=DsXRPrAvGACGWZwakKAv0P6DB6N7E49aOY35o8Rw6f9TYprjz3M/Y6BjzcSbFhxQPK kuWABYwu4JqNWbMc5s/el+mEXK179r8UnwCYizwMhng+t3jrwlR/WjmvkpPKeKRD80/R cRGmMiD+LkFDiChNPlQFVAYvL9iC5gpu7oIv9kXPqADbgrdXHjZWZRbTDMZXfw78wA+x 6/OMFIZdQ+YRLpKswy+G/yvJqfLz3xXeMiKsjh5QEmBuyOpNac2pJ/IG9hZuQZzgTINy lSIMevNJW45i3B4lfKtj9SmpVG6pjVkU/sFdw/Y0ShK4KIUVtW73D3gkGPA2H2Trwc0o n+Sw== X-Gm-Message-State: APf1xPAAQoDGSd+tYznq4x83iIyVn1lLENfzzdZarN/PoO4NGru1gHGi M7N+Bu1I8tNXqk5Bw/xIKkdIyNl+mPfxZ7k8CXY= X-Received: by 10.25.22.69 with SMTP id m66mr1090072lfi.27.1518528848695; Tue, 13 Feb 2018 05:34:08 -0800 (PST) MIME-Version: 1.0 Received: by 10.25.23.22 with HTTP; Tue, 13 Feb 2018 05:34:07 -0800 (PST) In-Reply-To: <20180209133934.259299920@linuxfoundation.org> References: <20180209133931.211869118@linuxfoundation.org> <20180209133934.259299920@linuxfoundation.org> From: Nick Lowe Date: Tue, 13 Feb 2018 13:34:07 +0000 Message-ID: Subject: Re: [PATCH 4.9 43/92] x86/pti: Do not enable PTI on CPUs which are not vulnerable to Meltdown To: Greg Kroah-Hartman Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, David Woodhouse , Thomas Gleixner , Borislav Petkov , Dave Hansen , gnomes@lxorguk.ukuu.org.uk, ak@linux.intel.com, ashok.raj@intel.com, karahmed@amazon.de, arjan@linux.intel.com, torvalds@linux-foundation.org, peterz@infradead.org, Borislav Petkov , pbonzini@redhat.com, tim.c.chen@linux.intel.com, gregkh@linux-foundation.org Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, This does not seem to have subsumed the AMD specific code in x86/pti: Do not enable PTI on CPUs which are not vulnerable to Meltdown Commit a8799fd14d9f7f385a5a5c86cde247caf4bb0320 https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git/commit/?h=v4.9.81&id=a8799fd14d9f7f385a5a5c86cde247caf4bb0320 x86/kaiser: Check boottime cmdline params Commit 8018307a45a90ab2eecfd03d48b7efb31707df37 https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git/commit/arch/x86/mm/kaiser.c?h=v4.9.75&id=8018307a45a90ab2eecfd03d48b7efb31707df37 Here, we can see: +skip: + if (boot_cpu_data.x86_vendor == X86_VENDOR_AMD) + goto disable; Refer to 4.9.81's kaiser.c https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git/tree/arch/x86/mm/kaiser.c?h=v4.9.81 Also 4.4.115's kaiser.c https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git/tree/arch/x86/mm/kaiser.c?h=v4.4.115 Cheers, Nick