Received: by 10.223.185.116 with SMTP id b49csp3764098wrg; Tue, 13 Feb 2018 07:25:14 -0800 (PST) X-Google-Smtp-Source: AH8x224+X1DUQBjGmeX2Mxz9sGjQ5JMZ246wqam13FobvzJEQGqLUPyTgZr/J4SHLAppOByMBZj4 X-Received: by 2002:a17:902:a617:: with SMTP id u23-v6mr1452617plq.201.1518535514345; Tue, 13 Feb 2018 07:25:14 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1518535514; cv=none; d=google.com; s=arc-20160816; b=N+IkIJCBWCQHFU3luUKp8aOLHVod37hFP1DFc6fyU8zry4XpXIA2kE19Tsqsy1+DH+ 59sQ4aQH8EB/xvUzv3R+cw5IUNRfyJ59Q8CxOoFDf0CRN5OKYD2hNHKMze8357nFzLUm xXuRj8haVpKFkHdHBE5E/+eAV5qqgtHgR4qXJVeBOx/2H3ihWWVnGfcAlS0TWLaJd9se q5+YNOJgMCuJpja6UVouAYTfu1W/g6yEpcC75E1RgEYQmwicAmZpOxBlOSAT7X2KPG9a Ev7QTzqRAUYaD+7WcG8nENgYt09eLHXGyMWjVldEFr/R63IM4dzV2mR9m3MWZGvAEw5Z pSDA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :references:in-reply-to:mime-version:dkim-signature :arc-authentication-results; bh=iiikmbMEwObwrZijmDRBuLYyoi/sBxFmIoPJkpX/8G0=; b=man9ddqlAfkinRvBuqRp4QBrT/vr2DREzpOW+Xmx/GxAf7i2vuyez5KdKzggSOocd/ z5ZVrDXeWe00zKYd9D7UR17H4Hs9RYEnG3k+HET1MgEuI+s23tgWe2DoRJp+O0PSXYh+ 5HVIQVVwaviQPjVZN13ggvV3o+55vAv6TJczXjSQ1HoB+VYm5WoVuBsO71/qW3QHPBGj fMWDOhfGVuxhNw+d9GniCGqEUOLAF0XoB0rgjTGmKSHjB/4u6QkI8winFArDQXsiWHxf ksBdXg7kJE4KvZOG0uGrIKPCo9VJybly2PPkVb9i6yJ4hAEHWBQbrES4TuNMyxaJCB/h /wWw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=VcZJn/s/; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 72-v6si5717574ple.299.2018.02.13.07.24.57; Tue, 13 Feb 2018 07:25:14 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=VcZJn/s/; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965066AbeBMPXN (ORCPT + 99 others); Tue, 13 Feb 2018 10:23:13 -0500 Received: from mail-vk0-f66.google.com ([209.85.213.66]:36531 "EHLO mail-vk0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964913AbeBMPXL (ORCPT ); Tue, 13 Feb 2018 10:23:11 -0500 Received: by mail-vk0-f66.google.com with SMTP id m197so11021311vka.3 for ; Tue, 13 Feb 2018 07:23:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=iiikmbMEwObwrZijmDRBuLYyoi/sBxFmIoPJkpX/8G0=; b=VcZJn/s/ul4mmfiG5IiAeMi1I1OKQc1pfofw7z9AT8lXTzbbs0wElXDk4Y9Hvh+t5B B/qjEDIfFfObAiQwE4EM4OD1VgzjkSZTDNAWckqR+bpNBy5k6zCeRWWsLRDnV+Sdt5QF IaCrxDLTiv6oVSkAQBNCe847A6GIkZn9ScfsjbSJaQFHfBQHDUKUIA7oLzZFBHteG1Ea zq6ctlWHhP7hd55xJ41RZUt3QtuCjFVNfag4d5dj7XiaWVlVpoQUnhgBeQs6m9zd1dKY L0ZNtIdfgmUm3nQ+7y8dgUWyPrC8iA88t2DQBND4a3ZvTudB5gjyECPVgaJZZmpYctJK 9t1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=iiikmbMEwObwrZijmDRBuLYyoi/sBxFmIoPJkpX/8G0=; b=g+ss8Ay0zE/0NMGPUyNKw8fu1toGrYvMH8UAkxCgQIWs13qqSa/Q77JWk5LVdhGavA c4VF+Y0BIjjPKo4YwzMrDdrB2JdvxFacIi9+0ulYFhPpe1AFC1zqLtNoeiBSjqo0m/ZC gqPQ3G8wVL2HUEqz1Nk6ZTELTlOdDDr8FuNSToBVwRjCpXIIf3UD87J+xiDQG51GYyOp yk1xh43LY3PuLhXpnQProjkMwG+WNksETuj+9FqC/nYCDhl6nbRnTuUg6jwQbK6lQELs gL9hOGp7kGO+xgflMK3v6ILkmWlgIf7l/IrUAVrg/r5dbZ6S822p9h4v1NrV+3dp1a7O isfA== X-Gm-Message-State: APf1xPB1asiZkyxr4n0nr9lhC+47ANqbRoPBdBh7DflCJS05Iq+MzHRz OrtLiszp+KT7AuBSyiT8oFG1KgB+Qhtnpzq/pSMeEDrl X-Received: by 10.31.48.71 with SMTP id w68mr1448285vkw.62.1518535390415; Tue, 13 Feb 2018 07:23:10 -0800 (PST) MIME-Version: 1.0 Received: by 10.159.38.193 with HTTP; Tue, 13 Feb 2018 07:22:50 -0800 (PST) In-Reply-To: <20180213145120.GA14657@lst.de> References: <20180213145120.GA14657@lst.de> From: Mathieu Malaterre Date: Tue, 13 Feb 2018 16:22:50 +0100 X-Google-Sender-Auth: lD3z45NyCPCWig-Hxe8Peufka1g Message-ID: Subject: Re: pata-macio WARNING at dmam_alloc_coherent+0xec/0x110 To: Christoph Hellwig Cc: Meelis Roos , iommu@lists.linux-foundation.org, linuxppc-dev , Linux Kernel list Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Tue, Feb 13, 2018 at 3:51 PM, Christoph Hellwig wrote: > Does this fix your warning? > > diff --git a/drivers/macintosh/macio_asic.c b/drivers/macintosh/macio_asic.c > index 62f541f968f6..07074820a167 100644 > --- a/drivers/macintosh/macio_asic.c > +++ b/drivers/macintosh/macio_asic.c > @@ -375,6 +375,7 @@ static struct macio_dev * macio_add_one_device(struct macio_chip *chip, > dev->ofdev.dev.of_node = np; > dev->ofdev.archdata.dma_mask = 0xffffffffUL; > dev->ofdev.dev.dma_mask = &dev->ofdev.archdata.dma_mask; > + dev->ofdev.dev.coherent_dma_mask = dev->ofdev.archdata.dma_mask; > dev->ofdev.dev.parent = parent; > dev->ofdev.dev.bus = &macio_bus_type; > dev->ofdev.dev.release = macio_release_dev; Indeed, Thanks much! If needed: Tested-by: Mathieu Malaterre System: Mac Mini G4 ref: https://www.mail-archive.com/linuxppc-dev@lists.ozlabs.org/msg128662.html