Received: by 10.223.185.116 with SMTP id b49csp3790286wrg; Tue, 13 Feb 2018 07:49:28 -0800 (PST) X-Google-Smtp-Source: AH8x225eJ/G9bxyDv7YTPgjPlzw+Gy9XuRx9/aH8RQUbXIs8hcUyJ5aBL7sUBB/Q3QtKa4b0toUa X-Received: by 10.98.147.209 with SMTP id r78mr1685049pfk.204.1518536968065; Tue, 13 Feb 2018 07:49:28 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1518536968; cv=none; d=google.com; s=arc-20160816; b=k3LzHCkk4a+wa6yT8T4daT2Oprpz2w5J4IbSElSP7lpONYpy7icuGqjcL0EVjeHsjH gCM7C0j6casLB2JdqW62psVPC9n/LgONykU3Fs6SVAXNYg2Gq0Y4UfZtoa591KQ5YJoA opJuwRagQ4LsJbU1mHS/3hvv+gIk2awtDzCcSEzBMEC+hnZZwvCKX0EhqS9kCXEn0bqW DNQQcKl5yNl8Uxvgogxr/5N2cAtm58fwvuIwEmwIUUEtDZUTsOuY4c+l1c74bZxndk0+ qqCp9tdIGRBQS4juo0oC+bFtRmycEx/svqsPfaMRlDk0nGOhMMDTwsxXZ3Txpk8gLrYd 1zQw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:cms-type:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature:dkim-filter :arc-authentication-results; bh=Sg/sNE3fLqKALq6mrvYiQtEAePATntvQvPW6rGz6f00=; b=wijfcAEx/K9Fhz49G+euJ76UpXeJakoNWVpSu82uCi47AjVB0DAp//63BbsSZymCTh FM/5Jt66ShiMBx9hCljJ/QOukMU1LMXyaS/Cv+3CkxlA4QLXFXntElqauwxo8ppefV1A 5xkppEyesmii8kyUL0Eop4Y2uYvyK2Hlt1X7ug+r/V1clPhtIYjuErxHQkj2dzx5QBO6 vtig2kA0kvSh7z1VUR3ga+Tt/Lq56KIENf5i033Iy6fhg5fPemzJ5OxoZgSfYyeWUF9c PtXPYl/uvCKUzzsh/Li6oHTZdA7euZYbB7W+3gR/pRnw/VsCNlCqNS3mQZhwwgRk4NG/ t1lg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@samsung.com header.s=mail20170921 header.b=f2/UGbjY; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=samsung.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z79si1832034pfi.381.2018.02.13.07.49.13; Tue, 13 Feb 2018 07:49:28 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@samsung.com header.s=mail20170921 header.b=f2/UGbjY; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=samsung.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934067AbeBMPr5 (ORCPT + 99 others); Tue, 13 Feb 2018 10:47:57 -0500 Received: from mailout3.samsung.com ([203.254.224.33]:31028 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933594AbeBMPrz (ORCPT ); Tue, 13 Feb 2018 10:47:55 -0500 Received: from epcas1p1.samsung.com (unknown [182.195.41.45]) by mailout3.samsung.com (KnoxPortal) with ESMTP id 20180213154753epoutp037e51bfc09e5d0c37eec2d1f7f69925a7~S7T2jBFTR2594625946epoutp03g; Tue, 13 Feb 2018 15:47:53 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout3.samsung.com 20180213154753epoutp037e51bfc09e5d0c37eec2d1f7f69925a7~S7T2jBFTR2594625946epoutp03g DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1518536873; bh=Sg/sNE3fLqKALq6mrvYiQtEAePATntvQvPW6rGz6f00=; h=From:To:Cc:Subject:Date:In-reply-to:References:From; b=f2/UGbjYmvXq6Omb2nzwA1euSGayyPTNwiHlSKCzMYpE1G92SfU6HceYrCbPaNI1s SfEePxof7qZU72Zk/xiysE4r7TwmFO56sm/xpw1MT/IRfDDIVEUuQr5reUW8ecRAOI d/JmhMv/nmfMX3lGQofNC6+CUG+JLXi3ZFiPXpgc= Received: from epsmges1p3.samsung.com (unknown [182.195.42.55]) by epcas1p3.samsung.com (KnoxPortal) with ESMTP id 20180213154752epcas1p3003741bb93c37bd3ec2c233746671b45~S7T1lnn_11063610636epcas1p3A; Tue, 13 Feb 2018 15:47:52 +0000 (GMT) Received: from epcas1p3.samsung.com ( [182.195.41.47]) by epsmges1p3.samsung.com (Symantec Messaging Gateway) with SMTP id B2.62.04137.8A8038A5; Wed, 14 Feb 2018 00:47:52 +0900 (KST) Received: from epsmgms2p1new.samsung.com (unknown [182.195.42.142]) by epcas1p3.samsung.com (KnoxPortal) with ESMTP id 20180213154752epcas1p35e3c13d150d2108a06342781ec5e64d7~S7T1ZMcmi1454614546epcas1p3s; Tue, 13 Feb 2018 15:47:52 +0000 (GMT) X-AuditID: b6c32a37-44bff70000001029-85-5a8308a8c8df Received: from epmmp2 ( [203.254.227.17]) by epsmgms2p1new.samsung.com (Symantec Messaging Gateway) with SMTP id CD.AA.03826.7A8038A5; Wed, 14 Feb 2018 00:47:52 +0900 (KST) Received: from test-PowerEdge-R720.sisodomain.com ([107.108.221.212]) by mmp2.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTPA id <0P43009JCIJN8870@mmp2.samsung.com>; Wed, 14 Feb 2018 00:47:51 +0900 (KST) From: Nitesh Shetty To: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org Cc: axboe@kernel.dk, axboe@fb.com, linux-nvme@lists.infradead.org, nj.shetty@samsung.com, joshi.k@samsung.com Subject: [PATCH v3] blk: optimization for classic polling Date: Tue, 13 Feb 2018 21:18:12 +0530 Message-id: <1518536892-2051-1-git-send-email-nj.shetty@samsung.com> X-Mailer: git-send-email 2.7.4 In-reply-to: <3578876466-3733-1-git-send-email-nj.shetty@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrPIsWRmVeSWpSXmKPExsWy7bCmvu4KjuYogwsnhSz+7znGZrH6bj+b xdH/b9ks9t7Stri8aw6bxfxlT9kttv2ez+zA7jGx+R27x+WzpR6bl9R79G1ZxejxeZNcAGsU l01Kak5mWWqRvl0CV8bL59eZC/6yV0xe9IulgfEMWxcjJ4eEgInE5okdzF2MXBxCAjsYJTbO uccG4XxnlFgzcRYzTNXEx5ehqjYwSjzfvRSqqp1J4t2fi+xdjBwcbALaEqf/c4A0iAjYSsw9 do0FJMwskC/xdZEYSFhYwFJiT/d9FhCbRUBVov/hRzCbV8BFou9gIyPELjmJm+c6wfZyCrhK /HnbCbZXQqCDTeLn2tNQZ7tIfNrwkx3CFpZ4dXwL2AkSAtISl47aQtR3M0rcaF0NNXQKo8SM ufoQtr3ExT1/mUBsZgE+iXdfe1ghenklOtqEIEo8JPa8fcMEYTtKbHp1kRXi3RmMEm0zNjBN YJRawMiwilEstaA4Nz212LDAWK84Mbe4NC9dLzk/dxMjOBq1zHcwbjjnc4hRgINRiYeX421T lBBrYllxZe4hRgkOZiUR3oT7QCHelMTKqtSi/Pii0pzU4kOM0hwsSuK8AQEuUUIC6Yklqdmp qQWpRTBZJg5OqQZGx5eNr8JlZrRxyCaxCuVLPt6gH5j39pPyhfScYzu9jkx7c8xlZ+CML1fv ZfWH3Tqx4wbzgYh6/URL7yqXy6H3zQxzQhJY1tyNUT/S98X+h338JYHrB9VZEoOj1A+HL3Lc MLH39RSF3llvZkRcnMGxKiraMXUnh/4BCYHjnrFHco6cz2Avf6GsxFKckWioxVxUnAgAOxo+ usICAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFupgluLIzCtJLcpLzFFi42I5/e+xoO4KjuYog2NHmC3+7znGZrH6bj+b xdH/b9ks9t7Stri8aw6bxfxlT9kttv2ez+zA7jGx+R27x+WzpR6bl9R79G1ZxejxeZNcAGsU l01Kak5mWWqRvl0CV8bL59eZC/6yV0xe9IulgfEMWxcjJ4eEgInExMeXmbsYuTiEBNYxSpw5 dpcVwulkkrj36TZQFQcHm4C2xOn/HCANIgK2EnOPXWMBsZkF8iW6fnxgArGFBSwl9nTfB4uz CKhK9D/8CGbzCrhI9B1sZIRYJidx81wnM4jNKeAq8ecthC0EVHNifRPrBEaeBYwMqxglUwuK c9Nzi40KDPNSy/WKE3OLS/PS9ZLzczcxAsNn22Gtvh2M95fEH2IU4GBU4uHd8KopSog1say4 MvcQowQHs5IIb8J9oBBvSmJlVWpRfnxRaU5q8SFGaQ4WJXHe23nHIoUE0hNLUrNTUwtSi2Cy TBycUg2MC48eFjr2n4sjYJOXm/e8VTyy5zamX1Cd76Dy6+LjH1OM72Ut3tD9YefXP5Zzftaz bJFc9eL5l2mfzm6qXxmc4/HbKmJ55Gvu1TuSfIOP7fr9boHX1S8PF6+LLlX74nvX5Yi66vrv XBWxRtP1mXa/mleR2l3DJHRAnUM1RCj4dsrnypcaF041GymxFGckGmoxFxUnAgA1+pH6GwIA AA== X-CMS-MailID: 20180213154752epcas1p35e3c13d150d2108a06342781ec5e64d7 X-Msg-Generator: CA CMS-TYPE: 101P X-CMS-RootMailID: 20180213154752epcas1p35e3c13d150d2108a06342781ec5e64d7 X-RootMTR: 20180213154752epcas1p35e3c13d150d2108a06342781ec5e64d7 References: <3578876466-3733-1-git-send-email-nj.shetty@samsung.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This removes the dependency on interrupts to wake up task. Set task state as TASK_RUNNING, if need_resched() returns true, while polling for IO completion. Earlier, polling task used to sleep, relying on interrupt to wake it up. This made some IO take very long when interrupt-coalescing is enabled in NVMe. Reference: http://lists.infradead.org/pipermail/linux-nvme/2018-February/015435.html Changes since v2->v3: -using __set_current_state() instead of set_current_state() Changes since v1->v2: -setting task state once in blk_poll, instead of multiple callers. Signed-off-by: Nitesh Shetty --- block/blk-mq.c | 1 + 1 file changed, 1 insertion(+) diff --git a/block/blk-mq.c b/block/blk-mq.c index df93102..3574927 100644 --- a/block/blk-mq.c +++ b/block/blk-mq.c @@ -3164,6 +3164,7 @@ static bool __blk_mq_poll(struct blk_mq_hw_ctx *hctx, struct request *rq) cpu_relax(); } + __set_current_state(TASK_RUNNING); return false; } -- 2.7.4