Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 13 Feb 2018 17:20:18 +0100 (CET)
From:   Thomas Gleixner <tglx@linutronix.de>
To:     Ingo Molnar <mingo@kernel.org>
cc:     Jia-Ju Bai <baijiaju1990@gmail.com>, mingo@redhat.com,
        hpa@zytor.com, jgross@suse.com, douly.fnst@cn.fujitsu.com,
        kkamagui@gmail.com, gregkh@linuxfoundation.org, mka@chromium.org,
        linux-kernel@vger.kernel.org, x86@kernel.org
Subject: Re: [PATCH] kernel: x86: apic: Replace GFP_ATOMIC with GFP_KERNEL
 in __add_pin_to_irq_node
In-Reply-To: <20180213161659.aribhtrooupdv4m4@gmail.com>
Message-ID: <alpine.DEB.2.21.1802131720030.1130@nanos.tec.linutronix.de>
References: <1516758015-7236-1-git-send-email-baijiaju1990@gmail.com> <20180213155604.62ulolc34snh5n3p@gmail.com> <alpine.DEB.2.21.1802131705050.1130@nanos.tec.linutronix.de> <20180213161659.aribhtrooupdv4m4@gmail.com>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, 13 Feb 2018, Ingo Molnar wrote:
> * Thomas Gleixner <tglx@linutronix.de> wrote:
> > On Tue, 13 Feb 2018, Ingo Molnar wrote:
> > > * Jia-Ju Bai <baijiaju1990@gmail.com> wrote:
> > > 
> > > > The function __add_pin_to_irq_node is not called in atomic context.
> > > > Thus GFP_ATOMIC is not necessary, and it can be replaced with GFP_KERNEL.
> > > > 
> > > > Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
> > > > ---
> > > >  arch/x86/kernel/apic/io_apic.c |    2 +-
> > > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > > 
> > > > diff --git a/arch/x86/kernel/apic/io_apic.c b/arch/x86/kernel/apic/io_apic.c
> > > > index 201579d..665c013 100644
> > > > --- a/arch/x86/kernel/apic/io_apic.c
> > > > +++ b/arch/x86/kernel/apic/io_apic.c
> > > > @@ -379,7 +379,7 @@ static int __add_pin_to_irq_node(struct mp_chip_data *data,
> > > >  		if (entry->apic == apic && entry->pin == pin)
> > > >  			return 0;
> > > >  
> > > > -	entry = kzalloc_node(sizeof(struct irq_pin_list), GFP_ATOMIC, node);
> > > > +	entry = kzalloc_node(sizeof(struct irq_pin_list), GFP_KERNEL, node);
> > > >  	if (!entry) {
> > > >  		pr_err("can not alloc irq_pin_list (%d,%d,%d)\n",
> > > >  		       node, apic, pin);
> > > 
> > > NAK: this is called in an atomic section: with IRQs disabled ...
> > 
> > The only invocation where this happens with IRQs disabled is the early
> > check_timer() code which runs _before_ the scheduler is working. GFP_KERNEL
> > is valid during that phase. All other call sites have interrupts enabled.
> 
> Yeah, so at minimum there's a mismatch between the changelog:
> 
> > > > The function __add_pin_to_irq_node is not called in atomic context.
> 
> ... and actual behavior. What you wrote should be part of the changelog I suspect.

Fair enough.