Received: by 10.223.185.116 with SMTP id b49csp3925424wrg; Tue, 13 Feb 2018 09:51:12 -0800 (PST) X-Google-Smtp-Source: AH8x225mXO9AMLSKEY3+VrJUDlj4FbqcpLUDrzxpzrYN5urv5tJUSOAuTeAK4D4NCpVXRAzbGIzZ X-Received: by 10.98.76.11 with SMTP id z11mr2034485pfa.114.1518544272603; Tue, 13 Feb 2018 09:51:12 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1518544272; cv=none; d=google.com; s=arc-20160816; b=FHPfq2IaSqI8VzOd7oaGICdj1eu/h1q+5ETSt9a4ZZI3mNglIttUxXPUOMSzKOEP8M g3bLNRUmsrgf9Z27ITmqilglcSZQxG8GxX+6+NvQPpPXIdoWrYC9v9MICwvAdRu4/mjt bG3VfVzMPXsiPts6R8egS45CarKn/hgcMk8Rdha7yqTiI2/8tlofv0MMhSvZ5Og/9kk1 MlssCpbr7NeGGo36QLCjtmFyXwBBF5dEuMOg4IIDQVsbjDfMGwLplGuavYF1O01Hvjju FnpwAFdo6kNaH6ZvsTN2+RF56H+yt40ziP53q5DMRP86a3tdaS1qM6AEeo7Yq2hV1LCX AVfg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature:arc-authentication-results; bh=4WhUhxgoogoG3iDTgqNQZnBDgaCui+vVrdNxVZ58e/k=; b=mRdMeiju/6gCbmkyk26CsYnWkeGbF2iuSb1jSa7xoMgOo2xU2oZRw89vja/PUQUUOZ 0PLeZoHCU+/iIaZMq2u9qWj1ozWdNfQjrjmotF+zspW6kotQmsVnp76RdqoJSSlYiNvt js3iYx5DkmGS05P3sZsyxwUvkVWDSiLFXefIfw/WmF8/waN04vdNT24jaEZTJwTad4W6 2IFp1p+wFeiYHN1UA5GoE4N+1MY5PuTAm3GuKDAYpEBjZMLXcSNeW8dJqKKJvjpL9V0l J1L4bT0Dk+iVUb9enOHeMSRYqQQzQzMmLinnYYHI4Tt1el3OmaGYdYgV8446yed4mwj9 Ds5Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=qgA9JoSl; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i75si3516143pfi.398.2018.02.13.09.50.58; Tue, 13 Feb 2018 09:51:12 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=qgA9JoSl; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965496AbeBMRt4 (ORCPT + 99 others); Tue, 13 Feb 2018 12:49:56 -0500 Received: from mail-pl0-f68.google.com ([209.85.160.68]:46816 "EHLO mail-pl0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965260AbeBMRtw (ORCPT ); Tue, 13 Feb 2018 12:49:52 -0500 Received: by mail-pl0-f68.google.com with SMTP id x2so2997449plr.13; Tue, 13 Feb 2018 09:49:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=4WhUhxgoogoG3iDTgqNQZnBDgaCui+vVrdNxVZ58e/k=; b=qgA9JoSl03PwioUNt6i7GoKWI6GBIPHAngo3CnLjDWHhedfC6onicJkhOkYzGEohca QaEaUd8O4rQ/a8oeDLpuBiYIcQ7EqoALMLEa+BKz1vlmWsO/3H0CdxEf+u05shjpxaee Y7ws3XQmRbHe1CYQaN5D7a8Yr9Avbqr16/1smzZbgGmDB7MO3j7CMiR+IkG6+SOitNE+ 91fdWSKtZB2nml0CETUAxR5tCt4n5fka8KlgBH4fth/l+TxlFqO7f7HC3gLBZiRhmfDo c6uVqnOF757++QDANIrnQe1cF1nC3MjhQ1vxTEBlVcZ++YfHQbvxcD+WXmsyd54brLKo NVcQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=4WhUhxgoogoG3iDTgqNQZnBDgaCui+vVrdNxVZ58e/k=; b=J0ZtvWRPH5pu7p274B701d93uaGrR66N9aEUst1X4qp8o5diM0mO3tU2HrNAKWsO/R JxRar39o44ZiS0Nhj4XsMP96nt5GdribWif8LANhUTtbKLzgMME7jbXUALYc1ZAn/Lzp tvSvHDNV+HIICemWfGNDKt5DojsMYXnLFzVyUPtS6fJh7/yUBVz8/jI0ieOJvlpSnlJ0 26GX2KwRjkfx5ucESF/wSePNyqTd9pOglc5cvOR76KE0HiqDY22Cmm3ggMVqxvHQjoWd d8GOyBoJ965+mhFtfpmHPWebl8ODrNbsihUSPlVXMfVDvof+6JU4CyiW0DI5jPrCVw7e NUAw== X-Gm-Message-State: APf1xPBXpLNGXxqciNAcutdjryoYi+cxgdA4/jPQdrPPHtE+TgMHH65J 8blKDnOsqypwSP5T8MjenY4= X-Received: by 2002:a17:902:9893:: with SMTP id s19-v6mr1808962plp.101.1518544191757; Tue, 13 Feb 2018 09:49:51 -0800 (PST) Received: from localhost (108-223-40-66.lightspeed.sntcca.sbcglobal.net. [108.223.40.66]) by smtp.gmail.com with ESMTPSA id v69sm34516171pfi.65.2018.02.13.09.49.50 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 13 Feb 2018 09:49:51 -0800 (PST) Date: Tue, 13 Feb 2018 09:49:50 -0800 From: Guenter Roeck To: Jerry Hoemann Cc: wim@linux-watchdog.org, linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org, rwright@hpe.com, maurice.a.saldivar@hpe.com Subject: Re: [PATCH v2 05/11] watchdog/hpwdt: Update Module info. Message-ID: <20180213174950.GC22401@roeck-us.net> References: <20180212052111.12010-1-jerry.hoemann@hpe.com> <20180212052111.12010-6-jerry.hoemann@hpe.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180212052111.12010-6-jerry.hoemann@hpe.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Feb 11, 2018 at 10:21:05PM -0700, Jerry Hoemann wrote: > Update Module Author and permission on parameters so that the > parameters show up in sysfs. > Does it really add value to see the module parameters in sysfs ? You would get both in standardized form by enabling WATCHDOG_SYSFS. > Signed-off-by: Jerry Hoemann > --- > drivers/watchdog/hpwdt.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/drivers/watchdog/hpwdt.c b/drivers/watchdog/hpwdt.c > index ee9a92220ece..dead59f9ca80 100644 > --- a/drivers/watchdog/hpwdt.c > +++ b/drivers/watchdog/hpwdt.c > @@ -432,20 +432,20 @@ static struct pci_driver hpwdt_driver = { > .remove = hpwdt_exit, > }; > > -MODULE_AUTHOR("Tom Mingarelli"); > -MODULE_DESCRIPTION("hp watchdog driver"); > +MODULE_AUTHOR("Jerry Hoemann"); > +MODULE_DESCRIPTION("hpe watchdog driver"); > MODULE_LICENSE("GPL"); > MODULE_VERSION(HPWDT_VERSION); > > -module_param(soft_margin, int, 0); > +module_param(soft_margin, int, 0444); > MODULE_PARM_DESC(soft_margin, "Watchdog timeout in seconds"); > > -module_param(nowayout, bool, 0); > +module_param(nowayout, bool, 0444); > MODULE_PARM_DESC(nowayout, "Watchdog cannot be stopped once started (default=" > __MODULE_STRING(WATCHDOG_NOWAYOUT) ")"); > > #ifdef CONFIG_HPWDT_NMI_DECODING /* { */ > -module_param(allow_kdump, int, 0); > +module_param(allow_kdump, int, 0444); > MODULE_PARM_DESC(allow_kdump, "Start a kernel dump after NMI occurs"); > #endif /* } */ > > -- > 2.13.6 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html