Received: by 10.223.185.116 with SMTP id b49csp3958652wrg; Tue, 13 Feb 2018 10:21:56 -0800 (PST) X-Google-Smtp-Source: AH8x227x3qyCjwxbJi2Hgen75L67WNZ/1/w794ZOTpEkPVgKtpaxJhKsDvbKN3Sn5/KfzvvaXxiF X-Received: by 10.98.25.207 with SMTP id 198mr2106656pfz.83.1518546116005; Tue, 13 Feb 2018 10:21:56 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1518546115; cv=none; d=google.com; s=arc-20160816; b=TQM4Foj9o05BAZZXEJj/kCwZWTGUhqItmkUkHjPf8zgRJQMrTplXrI3kf8gXhd0M1O xVst1NHfu8+sewI9ie7q6oBQYF+hesPCNfHURndhzxnz8ysMygPOqxTt9kxdGfYTFXJK d4nebIcBjjh8hvlWDuLeKXEnUwskqcjDX4koUCPH8WqDTbihoitw0A6QrPzCe+cjNP4N LmCfcYWxaaXYW8/T3fHM8w8eyGFf/2Mx3sd1pHCcnDFboksMTcAaEqhGXCy9NYDM1P1J bUj0pbC8McN8xKgkzgLC/A3dDfyRE4DUzMmXRKkDsyxXoakRO8r3LnMlT5F4lxKPciNn K/3w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature:arc-authentication-results; bh=wW7WgCebiqebhmy9oDQTk9wHg97e1nAHg5kNbeOASCI=; b=bgSL7RHEghoG8rdQdPuhnv1GNaY5MRjx2prKxWnc65l/tpOBGnCzN9bEsNo+DXg+6o lsr3ag66ZETgMqRRVHZGUzm1yz++dqsiMr5ufy0ZtyXjV4zKTNC/7ai68gfodXCTSdwH VncSHgFHQimfUyLuhuKq48C06fhCqgTbtuF3WCOKQVTqedrGle7vtkv9HaNq4ccGe7bi eRVua72SZehyQ6MSyG+GPt4/sIDJvx6uBnbfefmgv1gptXHD8jprZsnld9LKIAdaywYW I0H1wDbPIxJG9d9dOYEatum1vEAD3xtWHrisHuKaGK/n166zZ3yT6QGHNEdypr+gFJL2 qXdA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=ZQ73RNoL; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y6si6818371pgc.112.2018.02.13.10.21.41; Tue, 13 Feb 2018 10:21:55 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=ZQ73RNoL; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965446AbeBMSUq (ORCPT + 99 others); Tue, 13 Feb 2018 13:20:46 -0500 Received: from mail-pl0-f68.google.com ([209.85.160.68]:47045 "EHLO mail-pl0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965286AbeBMSUo (ORCPT ); Tue, 13 Feb 2018 13:20:44 -0500 Received: by mail-pl0-f68.google.com with SMTP id x2so3038885plr.13; Tue, 13 Feb 2018 10:20:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=wW7WgCebiqebhmy9oDQTk9wHg97e1nAHg5kNbeOASCI=; b=ZQ73RNoLae6dB043XmaCwRwZ1JkYfxWZep2/rLh+jNJDgfnzBh02K0pmNhrjq+I5JT kE5LHN40iRnTLR99E7QH5tOUbmxStvBASGUFmhubRqTM91GCE4Q50a+qz9c+voE9eP66 2YB46EK78wev4M4oB3BboX5nE9ddWSdnsGRizamIR5c3pBtJPEv8Ye77b7FbcUWoObFB mnqNBEtlkMKjiw+Vien2zDMgxmRZjpTj4AspTwDpNiG1XIrj8H+z7U0YkEfVEdzApgiF xYlW+fp5jAFEnKR8NXrmpeMf43jTiOVtceBrO8FNMtWh8OEZRrCuVH494KvR31wzqFhr otlw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=wW7WgCebiqebhmy9oDQTk9wHg97e1nAHg5kNbeOASCI=; b=d/OsjPb5rlQ3SuLw1QesqDrS/2XPA8aZMp+WVI5BWNQWMp9a2geHgJxUxvx24UtMxN 58/fwdLNUUFfl/K6FGY9LBm90vbdbT7p+gAXkMyAsjsGDdKYp/MMxb1CCTWsWJzsS1Ul nlofxXaP6OJnHp4HOHKlMgR5f4tw0s9BtWcKV2tpL60BIG7zNe/KzgPfbUlb+K70SzPH OMM8qw86UHoecuWkZjCycMTd/AKlULJyaCglm23P4CGTO56b9pjpNHDcUu9N6sASiG5F iMXR7bhq45WQziJGgaL1KsVZ/yk9qatYKnEWa+che8WnF25XQ4Iyii/Ly4wSZ41g4Ux8 GyyQ== X-Gm-Message-State: APf1xPAY44btlFitvk1mjKFNanFsNHJCeMaweA++M1u3gf/H3ED5ZGS4 6VRlSxCEhysrTopTxGm1miI= X-Received: by 2002:a17:902:5a4a:: with SMTP id f10-v6mr1918336plm.308.1518546044441; Tue, 13 Feb 2018 10:20:44 -0800 (PST) Received: from localhost (108-223-40-66.lightspeed.sntcca.sbcglobal.net. [108.223.40.66]) by smtp.gmail.com with ESMTPSA id j1sm26655513pff.94.2018.02.13.10.20.43 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 13 Feb 2018 10:20:43 -0800 (PST) Date: Tue, 13 Feb 2018 10:20:42 -0800 From: Guenter Roeck To: Jerry Hoemann Cc: wim@linux-watchdog.org, linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org, rwright@hpe.com, maurice.a.saldivar@hpe.com Subject: Re: [PATCH v2 10/11] watchdog/hpwdt: remove allow_kdump module parameter. Message-ID: <20180213182042.GA26558@roeck-us.net> References: <20180212052111.12010-1-jerry.hoemann@hpe.com> <20180212052111.12010-11-jerry.hoemann@hpe.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180212052111.12010-11-jerry.hoemann@hpe.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Feb 11, 2018 at 10:21:10PM -0700, Jerry Hoemann wrote: > The intent of this parameter is unclear and it sets up a > race between the reset of the system by ASR and crashdump. > > The length of time between receipt of the pretimeout NMI > and the ASR reset of the system is fixed by hardware. > > Turning the parameter off doesn't necessairly prevent a crash dump. > Also, having the ASR reset occur while the system is crash dumping > doesn't imply that the dump was hung given the short duration > between the NMI and the reset. > > This parameter is not a substitute for having a architected watchdog > crashdump hang detection paridigm. > > Signed-off-by: Jerry Hoemann > --- > drivers/watchdog/hpwdt.c | 7 +------ > 1 file changed, 1 insertion(+), 6 deletions(-) > > diff --git a/drivers/watchdog/hpwdt.c b/drivers/watchdog/hpwdt.c > index e9e54fe20804..bb0dcc8709b8 100644 > --- a/drivers/watchdog/hpwdt.c > +++ b/drivers/watchdog/hpwdt.c > @@ -33,7 +33,6 @@ > static unsigned int soft_margin = DEFAULT_MARGIN; /* in seconds */ > static bool nowayout = WATCHDOG_NOWAYOUT; > #ifdef CONFIG_HPWDT_NMI_DECODING > -static unsigned int allow_kdump = 1; At the end of hpwdt_init_nmi_decoding(), there used to be a log message showing the value of allow_kdump. Maybe that was removed in another patch, but it really belongs to this patch, or am I missing something ? Guenter > static bool pretimeout = 1; > #else > static bool pretimeout; > @@ -149,8 +148,7 @@ static int hpwdt_pretimeout(unsigned int ulReason, struct pt_regs *regs) > if (iLO5 && (ulReason == NMI_UNKNOWN) && !mynmi) > return NMI_DONE; > > - if (allow_kdump) > - hpwdt_stop(&hpwdt_dev); > + hpwdt_stop(&hpwdt_dev); > > panic_msg[0] = hexdigit((mynmi>>4)&0xf); > panic_msg[1] = hexdigit(mynmi&0xf); > @@ -351,9 +349,6 @@ MODULE_PARM_DESC(nowayout, "Watchdog cannot be stopped once started (default=" > __MODULE_STRING(WATCHDOG_NOWAYOUT) ")"); > > #ifdef CONFIG_HPWDT_NMI_DECODING /* { */ > -module_param(allow_kdump, int, 0444); > -MODULE_PARM_DESC(allow_kdump, "Start a kernel dump after NMI occurs"); > - > module_param(pretimeout, bool, 0444); > MODULE_PARM_DESC(pretimeout, "Watchdog pretimeout enabled"); > #endif /* } */ > -- > 2.13.6 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html